From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [PATCH v7 6/8] net/i40e: add FDIR support for GTP-C
	and GTP-U
Date: Thu, 5 Oct 2017 03:09:25 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F810E89C9A@SHSMSX103.ccr.corp.intel.com>
References: <1506662342-18966-1-git-send-email-beilei.xing@intel.com>
 <1506700252-34949-1-git-send-email-beilei.xing@intel.com>
 <1506700252-34949-7-git-send-email-beilei.xing@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Chilikin, Andrey" <andrey.chilikin@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
To: "Xing, Beilei" <beilei.xing@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 7F8213256
 for <dev@dpdk.org>; Thu,  5 Oct 2017 05:09:30 +0200 (CEST)
In-Reply-To: <1506700252-34949-7-git-send-email-beilei.xing@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> @@ -975,27 +1003,30 @@ i40e_flow_fdir_fill_eth_ip_head(const struct i40e_=
fdir_input
> *fdir_input,
>  	raw_pkt +=3D sizeof(uint16_t);
>  	len +=3D sizeof(uint16_t);
>=20
> -	switch (fdir_input->pctype) {
> -	case I40E_FILTER_PCTYPE_L2_PAYLOAD:
> +	if (is_customized_pctype) {
> +		cus_pctype =3D i40e_flow_fdir_find_customized_pctype(pf, pctype);
> +		if (!cus_pctype)
> +			PMD_DRV_LOG(ERR, "unknown pctype %u.",
> +				    fdir_input->pctype);
Doesn't return here?
If it is impossible cus_pctype is NULL, the check is unnecessary.
Because you used the cus_ptype below.

Thanks
Jingjing