From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [PATCH v10 1/3] bus/ifpga: Add Intel FPGA BUS Library
Date: Thu, 10 May 2018 08:43:42 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F81108EC6C@SHSMSX103.ccr.corp.intel.com>
References: <1521553556-62982-1-git-send-email-rosen.xu@intel.com>
 <1525851801-16101-1-git-send-email-rosen.xu@intel.com>
 <1525851801-16101-2-git-send-email-rosen.xu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Xu, Rosen" <rosen.xu@intel.com>, "Zhang, Roy Fan"
 <roy.fan.zhang@intel.com>, "Doherty, Declan" <declan.doherty@intel.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>, "shreyansh.jain@nxp.com"
 <shreyansh.jain@nxp.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Zhang, Tianfei"
 <tianfei.zhang@intel.com>, "Liu, Song" <song.liu@intel.com>, "Wu, Hao"
 <hao.wu@intel.com>, "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>
To: "Xu, Rosen" <rosen.xu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "thomas@monjalon.net" <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by dpdk.org (Postfix) with ESMTP id A06E1AA97
 for <dev@dpdk.org>; Thu, 10 May 2018 10:43:47 +0200 (CEST)
In-Reply-To: <1525851801-16101-2-git-send-email-rosen.xu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi, Rosen

Few comments below.


Thanks
Jingjing

[......]
> +static struct rte_ifpga_device *
> +ifpga_find_ifpga_dev(const struct rte_rawdev *rdev)
> +{
> +	struct rte_ifpga_device *ifpga_dev =3D NULL;
> +
> +	TAILQ_FOREACH(ifpga_dev, &ifpga_device_list, next) {
> +		if (rdev &&
rdev -> ifpage_dev  ??

> +			ifpga_dev->rdev &&
> +			ifpga_dev->rdev =3D=3D rdev)
> +			return ifpga_dev;
> +	}
> +	return NULL;
> +}
> +
> +static struct rte_afu_device *
> +ifpga_find_afu_dev(const struct rte_ifpga_device *ifpga_dev,
> +	const struct rte_afu_id *afu_id)
> +{
> +	struct rte_afu_device *afu_dev =3D NULL;
> +
> +	TAILQ_FOREACH(afu_dev, &ifpga_dev->afu_list, next) {
> +		if (!ifpga_afu_id_cmp(&afu_dev->id, afu_id))
Add checking afu_dev?

[...]

> +static int
> +ifpga_parse(const char *name, void *addr)
> +{
> +	int *out =3D addr;
> +	struct rte_rawdev *rawdev =3D NULL;
> +	char rawdev_name[RTE_RAWDEV_NAME_MAX_LEN];
> +	char *c1 =3D NULL, *c2 =3D NULL;
According to coding style, we need to two lines for the definition like:
char *c1 =3D NULL;
char *c2 =3D NULL;

> +	int port =3D IFPGA_BUS_DEV_PORT_MAX;
> +	char str_port[8];
> +	int str_port_len =3D 0;
> +	int ret;
> +
> +	memset(str_port, 0, 8);
> +	c1 =3D strchr(name, '|');
> +	if (c1 !=3D NULL) {
> +		str_port_len =3D c1-name;
According to coding style, spaces are required around opreations.
> +		c2 =3D c1+1;
> +	}