From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wu, Jingjing" Subject: Re: [PATCH 2/4] i40e: split function for input set change of hash and fdir Date: Thu, 21 Jan 2016 01:28:59 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8D8AB7A@SHSMSX104.ccr.corp.intel.com> References: <1451032200-24973-1-git-send-email-jingjing.wu@intel.com> <1451032200-24973-3-git-send-email-jingjing.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: "Chilikin, Andrey" , "dev@dpdk.org" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 77D428E8F for ; Thu, 21 Jan 2016 02:29:03 +0100 (CET) In-Reply-To: Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Andrey Thanks for your comments. You are correct, I removed the I40E_INSET_FLEX_PA= YLOAD from valid fdir input set values, and this is one reason why I splited func= tion for input set change of hash and and it is because all flex payload configuration can be set in struct rte_fdir_conf during device configure phase. And it is a more= flexible configuration including flexpayload's selection, input set selection by word and mask set= ting in bits. If I enable it in the input set change API, it will be duplicate. And the i= nput set change on flexible payload only on word, just some ability compared with rte_fdir_con= f. If flexible selection isn't done in struct rte_fdir_conf, the input set=20 selection in input set change API doesn't make sense. If flexible selection= is done in struct rte_fdir_conf, why not selection input set in struct rte_fdir_conf a= t the same time? And about you concern, "when application has to run on an old NIC and on a = new one", The rte_fdir_conf is for each eth_dev, so it will be fine. Thanks Jingjing =20 > -----Original Message----- > From: Chilikin, Andrey > Sent: Thursday, January 21, 2016 4:05 AM > To: Wu, Jingjing; dev@dpdk.org > Cc: Zhang, Helin; Pei, Yulong; Ananyev, Konstantin > Subject: RE: [PATCH 2/4] i40e: split function for input set change of has= h and > fdir >=20 > Hi Jingjing, >=20 > As I can see this patch not only splits fdir functionality from common > fdir/hash code but also removes compatibility with DPDK 2.2 as it deletes > I40E_INSET_FLEX_PAYLOAD from valid fdir input set values. Yes, flexible > payload configuration can be set for fdir separately at the port initiali= zation, > but this is more legacy from the previous generations of NICs which did n= ot > support dynamic input set configuration. I believe it would better to hav= e > I40E_INSET_FLEX_PAYLOAD valid for fdir input set same as in DPDK 2.2. So = in > legacy mode, when application has to run on an old NIC and on a new one, > only legacy configuration would be used, but for applications targeting n= ew > HW single point of configuration would be used instead of mix of two. >=20 > Regards, > Andrey >=20