All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wyborny, Carolyn" <carolyn.wyborny@intel.com>
To: David Miller <davem@davemloft.net>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"nhorman@redhat.com" <nhorman@redhat.com>,
	"sassmann@redhat.com" <sassmann@redhat.com>,
	"jogreene@redhat.com" <jogreene@redhat.com>
Subject: RE: [net-next 05/11] i40e: fix for queue timing delays
Date: Mon, 27 Mar 2017 16:12:37 +0000	[thread overview]
Message-ID: <9BBC4E0CF881AA4299206E2E1412B626503F4598@ORSMSX102.amr.corp.intel.com> (raw)
In-Reply-To: <20170325.200045.766752589165691684.davem@davemloft.net>

> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Saturday, March 25, 2017 8:01 PM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
> Cc: Wyborny, Carolyn <carolyn.wyborny@intel.com>;
> netdev@vger.kernel.org; nhorman@redhat.com; sassmann@redhat.com;
> jogreene@redhat.com
> Subject: Re: [net-next 05/11] i40e: fix for queue timing delays
> 
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Sat, 25 Mar 2017 01:12:59 -0700
> 
> > From: Carolyn Wyborny <carolyn.wyborny@intel.com>
> >
> > This patch adds a delay to Rx queue disables to accommodate HW needs.
> >
[..]
> > +	/* HW needs up to 50ms to finish RX queue disable*/
> > +	mdelay(50);
> 
> You just polled a register which indicates that the request is finished.
> Needing futher time for the operation to complete doesn't make any
> sense.
> 
> If this is really needed, you need to explain in the commit message, in
> detail, what is really the problem here.
> 
> THanks.

It's a hw limitation, will submit an updated patch with more detail.

Thanks,

Carolyn

Carolyn Wyborny 
Linux Development 
Networking Division 
Intel Corporation 

  reply	other threads:[~2017-03-27 16:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-25  8:12 [net-next 00/11][pull request] 40GbE Intel Wired LAN Driver Updates 2017-03-25 Jeff Kirsher
2017-03-25  8:12 ` [net-next 01/11] i40e/i40evf: Update code to better handle incrementing page count Jeff Kirsher
2017-03-25  8:12 ` [net-next 02/11] i40e: fix configuration of RSS table with DCB Jeff Kirsher
2017-03-25  8:12 ` [net-next 03/11] i40e/i40evf: Fix use after free in Rx cleanup path Jeff Kirsher
2017-03-25  8:12 ` [net-next 04/11] i40e: Fixed race conditions in VF reset Jeff Kirsher
2017-03-25  8:12 ` [net-next 05/11] i40e: fix for queue timing delays Jeff Kirsher
2017-03-25 10:31   ` Sergei Shtylyov
2017-03-26  3:00   ` David Miller
2017-03-27 16:12     ` Wyborny, Carolyn [this message]
2017-03-25  8:13 ` [net-next 06/11] i40e: removed no longer needed delays Jeff Kirsher
2017-03-25  8:13 ` [net-next 07/11] i40e/i40evf: Clean-up process_skb_fields Jeff Kirsher
2017-03-25  8:13 ` [net-next 08/11] i40e: Drop FCoE code from core driver files Jeff Kirsher
2017-03-25  8:13 ` [net-next 09/11] i40e: Drop FCoE code that always evaluates to false or 0 Jeff Kirsher
2017-03-25  8:13 ` [net-next 10/11] i40evf: dereference VSI after VSI has been null checked Jeff Kirsher
2017-03-25  8:13 ` [net-next 11/11] i40e: initialize params before notifying of l2_param_changes Jeff Kirsher
2017-03-27 23:38 ` [net-next 00/11][pull request] 40GbE Intel Wired LAN Driver Updates 2017-03-25 Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9BBC4E0CF881AA4299206E2E1412B626503F4598@ORSMSX102.amr.corp.intel.com \
    --to=carolyn.wyborny@intel.com \
    --cc=davem@davemloft.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jogreene@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.