From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Saleem, Shiraz" Subject: RE: [PATCH] RDMA/uverbs: Fix the check for port number Date: Thu, 3 Aug 2017 23:34:27 +0000 Message-ID: <9DD61F30A802C4429A01CA4200E302A75AFA5D75@fmsmsx116.amr.corp.intel.com> References: <1501085686-12916-1-git-send-email-mustafa.ismail@intel.com> <20170803224149.GF2396@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20170803224149.GF2396-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> Content-Language: en-US Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Greg KH , "Ismail, Mustafa" Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , "Tung, Chien Tin" , "# v4 . 2-v4 . 9" , "security-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Doug Ledford , Steve Wise , "Marciniszyn, Mike" List-Id: linux-rdma@vger.kernel.org > Subject: Re: [PATCH] RDMA/uverbs: Fix the check for port number > > On Wed, Jul 26, 2017 at 11:14:46AM -0500, Mustafa Ismail wrote: > > The port number is only valid if IB_QP_PORT is set in the mask. > > So only check port number if it is valid to prevent modify_qp from > > failing due to an invalid port number. > > > > Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds") > > Cc: # v4.2-v4.9 > > Cc: > > Cc: Doug Ledford > > Cc: Steve Wise > > Cc: Mike Marciniszyn > > > > Signed-off-by: Mustafa Ismail > > > > Upstream commit 5a7a88f1b488("Fix the check for port number") Modified > > from upstream commit: helper function rdma_is_port_valid does not > > exist in these kernel versions. > > Note, you sent this 3 times for some reason, why? > > Also, it was hard to figure out what to do with it, I think it was ment for me to apply > to the 4.4 and 4.9-stable trees, right? If so, I've done that, if not, please let me > know. > Hi Greg - Mustafa is on vacation. Yes. The patch is meant for 4.4 and 4.9 stable tree. Shiraz -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com ([192.55.52.115]:28984 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbdHCXe3 (ORCPT ); Thu, 3 Aug 2017 19:34:29 -0400 From: "Saleem, Shiraz" To: Greg KH , "Ismail, Mustafa" CC: "linux-rdma@vger.kernel.org" , "e1000-rdma@lists.sourceforge.net" , "Tung, Chien Tin" , "# v4 . 2-v4 . 9" , "security@kernel.org" , "Doug Ledford" , Steve Wise , "Marciniszyn, Mike" Subject: RE: [PATCH] RDMA/uverbs: Fix the check for port number Date: Thu, 3 Aug 2017 23:34:27 +0000 Message-ID: <9DD61F30A802C4429A01CA4200E302A75AFA5D75@fmsmsx116.amr.corp.intel.com> References: <1501085686-12916-1-git-send-email-mustafa.ismail@intel.com> <20170803224149.GF2396@kroah.com> In-Reply-To: <20170803224149.GF2396@kroah.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: > Subject: Re: [PATCH] RDMA/uverbs: Fix the check for port number > > On Wed, Jul 26, 2017 at 11:14:46AM -0500, Mustafa Ismail wrote: > > The port number is only valid if IB_QP_PORT is set in the mask. > > So only check port number if it is valid to prevent modify_qp from > > failing due to an invalid port number. > > > > Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds") > > Cc: # v4.2-v4.9 > > Cc: > > Cc: Doug Ledford > > Cc: Steve Wise > > Cc: Mike Marciniszyn > > > > Signed-off-by: Mustafa Ismail > > > > Upstream commit 5a7a88f1b488("Fix the check for port number") Modified > > from upstream commit: helper function rdma_is_port_valid does not > > exist in these kernel versions. > > Note, you sent this 3 times for some reason, why? > > Also, it was hard to figure out what to do with it, I think it was ment for me to apply > to the 4.4 and 4.9-stable trees, right? If so, I've done that, if not, please let me > know. > Hi Greg - Mustafa is on vacation. Yes. The patch is meant for 4.4 and 4.9 stable tree. Shiraz