From: "Saleem, Shiraz" <shiraz.saleem@intel.com>
To: 'Jason Gunthorpe' <jgg@ziepe.ca>, Gal Pressman <galpress@amazon.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Ismail, Mustafa" <mustafa.ismail@intel.com>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
Yossi Leybovich <sleybo@amazon.com>
Subject: RE: [RFC v1 12/19] RDMA/irdma: Implement device supported verb APIs
Date: Tue, 26 Feb 2019 21:09:36 +0000 [thread overview]
Message-ID: <9DD61F30A802C4429A01CA4200E302A7A5A4FBAC@fmsmsx124.amr.corp.intel.com> (raw)
In-Reply-To: <20190225185015.GD21863@ziepe.ca>
>Subject: Re: [RFC v1 12/19] RDMA/irdma: Implement device supported verb APIs
>
[..]
>> > + ret = irdma_alloc_rsrc(iwdev->rf,
>> > + iwdev->rf->allocated_mrs, iwdev->rf->max_mr,
>> > + &stag_index, &next_stag_index);
>> > + if (!ret) {
>> > + stag = stag_index << IRDMA_CQPSQ_STAG_IDX_S;
>> > + stag |= driver_key;
>> > + stag += (u32)consumer_key;
>> > + irdma_add_devusecount(iwdev);
>> > + }
>>
>> This is confusing IMHO, better to test for 'if (ret)' and keep the
>> main flow unindented.
>
>Yes please follow the standard 'success oriented flow'
>
OK.
next prev parent reply other threads:[~2019-02-26 21:09 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 17:10 [RFC v1 00/19] Add unified Intel Ethernet RDMA driver (irdma) Shiraz Saleem
2019-02-15 17:10 ` [RFC v1 01/19] net/i40e: Add peer register/unregister to struct i40e_netdev_priv Shiraz Saleem
2019-02-15 17:22 ` Jason Gunthorpe
2019-02-21 2:19 ` Saleem, Shiraz
2019-02-21 19:35 ` Jason Gunthorpe
2019-02-22 20:13 ` Ertman, David M
2019-02-22 20:23 ` Jason Gunthorpe
2019-03-13 2:11 ` Jeff Kirsher
2019-03-13 13:28 ` Jason Gunthorpe
2019-05-10 13:31 ` Shiraz Saleem
2019-05-10 18:17 ` Jason Gunthorpe
2019-02-15 17:10 ` [RFC v1 02/19] net/ice: Create framework for VSI queue context Shiraz Saleem
2019-02-15 17:10 ` [RFC v1 03/19] net/ice: Add support for ice peer devices and drivers Shiraz Saleem
2019-02-15 17:10 ` [RFC v1 04/19] RDMA/irdma: Add driver framework definitions Shiraz Saleem
2019-02-24 15:02 ` Gal Pressman
2019-02-24 15:02 ` Gal Pressman
2019-02-26 21:08 ` Saleem, Shiraz
2019-02-15 17:10 ` [RFC v1 05/19] RDMA/irdma: Implement device initialization definitions Shiraz Saleem
2019-02-15 17:10 ` [RFC v1 06/19] RDMA/irdma: Implement HW Admin Queue OPs Shiraz Saleem
2019-02-15 17:10 ` [RFC v1 07/19] RDMA/irdma: Add HMC backing store setup functions Shiraz Saleem
2019-02-15 17:10 ` [RFC v1 08/19] RDMA/irdma: Add privileged UDA queue implementation Shiraz Saleem
2019-02-24 11:42 ` Gal Pressman
2019-02-24 11:42 ` Gal Pressman
2019-02-15 17:10 ` [RFC v1 09/19] RDMA/irdma: Add QoS definitions Shiraz Saleem
2019-02-15 17:10 ` [RFC v1 10/19] RDMA/irdma: Add connection manager Shiraz Saleem
2019-02-24 11:21 ` Gal Pressman
2019-02-24 11:21 ` Gal Pressman
2019-02-25 18:46 ` Jason Gunthorpe
2019-02-26 21:07 ` Saleem, Shiraz
2019-02-15 17:10 ` [RFC v1 11/19] RDMA/irdma: Add PBLE resource manager Shiraz Saleem
2019-02-27 6:58 ` Leon Romanovsky
2019-02-15 17:10 ` [RFC v1 12/19] RDMA/irdma: Implement device supported verb APIs Shiraz Saleem
2019-02-15 17:35 ` Jason Gunthorpe
2019-02-15 22:19 ` Shiraz Saleem
2019-02-15 22:32 ` Jason Gunthorpe
2019-02-20 14:52 ` Saleem, Shiraz
2019-02-20 16:51 ` Jason Gunthorpe
2019-02-24 14:35 ` Gal Pressman
2019-02-24 14:35 ` Gal Pressman
2019-02-25 18:50 ` Jason Gunthorpe
2019-02-26 21:09 ` Saleem, Shiraz [this message]
2019-02-26 21:09 ` Saleem, Shiraz
2019-02-27 7:31 ` Gal Pressman
2019-02-15 17:11 ` [RFC v1 13/19] RDMA/irdma: Add RoCEv2 UD OP support Shiraz Saleem
2019-02-27 6:50 ` Leon Romanovsky
2019-02-15 17:11 ` [RFC v1 14/19] RDMA/irdma: Add user/kernel shared libraries Shiraz Saleem
2019-02-15 17:11 ` [RFC v1 15/19] RDMA/irdma: Add miscellaneous utility definitions Shiraz Saleem
2019-02-15 17:47 ` Jason Gunthorpe
2019-02-20 7:51 ` Leon Romanovsky
2019-02-20 14:53 ` Saleem, Shiraz
2019-02-20 16:53 ` Jason Gunthorpe
2019-02-15 17:11 ` [RFC v1 16/19] RDMA/irdma: Add dynamic tracing for CM Shiraz Saleem
2019-02-15 17:11 ` [RFC v1 17/19] RDMA/irdma: Add ABI definitions Shiraz Saleem
2019-02-15 17:16 ` Jason Gunthorpe
2019-02-20 14:52 ` Saleem, Shiraz
2019-02-20 16:50 ` Jason Gunthorpe
2019-02-15 17:11 ` [RFC v1 18/19] RDMA/irdma: Add Kconfig and Makefile Shiraz Saleem
2019-02-15 17:11 ` [RFC v1 19/19] RDMA/irdma: Update MAINTAINERS file Shiraz Saleem
2019-02-15 17:20 ` [RFC v1 00/19] Add unified Intel Ethernet RDMA driver (irdma) Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9DD61F30A802C4429A01CA4200E302A7A5A4FBAC@fmsmsx124.amr.corp.intel.com \
--to=shiraz.saleem@intel.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=galpress@amazon.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=mustafa.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sleybo@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.