Re: [PATCH] oe-selftest: qemutest: add tests for qemu boot and shutdown

["Yeoh, Ee Peng" <ee.peng.yeoh@intel.com>]

Noted, let me rework on this. Thank you for your feedback! 

-----Original Message-----
From: Alexander Kanavin [mailto:alexander.kanavin@linux.intel.com] 
Sent: Thursday, April 5, 2018 5:56 PM
To: Yeoh, Ee Peng <ee.peng.yeoh@intel.com>; openembedded-core@lists.openembedded.org
Cc: Eggleton, Paul <paul.eggleton@intel.com>
Subject: Re: [OE-core] [PATCH] oe-selftest: qemutest: add tests for qemu boot and shutdown

On 04/05/2018 11:09 AM, Yeoh, Ee Peng wrote:
> I had developed this selftest testcase to test qemu can boot nfs &
> ext4 and finally shutdown for various qemu architecture.
> 
> Initially, I was thinking to develop this automated test as part of 
> testimage but as this test involve shutting down qemu, testimage 
> testcases executed after this will face lost connection to qemu.
> Furthermore, when I tried to add this test to selftest runqemu.py, I 
> realized runqemu was dedicated for MACHINE=qemux86-64 and it was 
> testing various live image (iso and hddimg) but live image was not 
> supported by other qemu architecture. Therefore, this test was 
> developed as independent selftest testcase.
> 
> Please let me know your inputs and feedback.
It's totally okay to have several test classes in a single .py file (see for example signing.py). I think this should go to runqemu.py, as otherwise there would be two different files doing roughly same thing and named very similarly (runqemu and qemutest?), which is confusing.

You can add comments to both classes to explain what they do and why, and how they are different. (generally, be generous with comments every time there is possibility for confusion, or the code does unusual things
etc.)

Alex