Re: [PATCH v2] Bluetooth: btusb: Add Realtek 8723/8761 support

From: Marcel Holtmann <marcel@holtmann.org>
To: 陈艳萍 <champion_chen@realsil.com.cn>
Cc: Daniel Drake <drake@endlessm.com>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	"Gustavo F. Padovan" <gustavo@padovan.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Linux Bluetooth mailing list <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH v2] Bluetooth: btusb: Add Realtek 8723/8761 support
Date: Fri, 11 Jul 2014 13:19:37 +0200	[thread overview]
Message-ID: <9E14663D-314D-4C07-9C92-22DE693F5B2A@holtmann.org> (raw)
In-Reply-To: <54F70642BAB21D4498E1AA3EFE3D519A45FC1F15@rsex2.realsil.com.cn>

Hi Champion,

> 	The setup function is provided in kernel v3.12 , before this version we do not have ways to add in btusb.c and we do not want to change the generic driver too much so we rewrite rtk_btusb.c. 
> 	If the setup function is the way you preferred, we will develop based on generic driver. This seems make btusb.c more complex. We will provide you all the firmware after complete test . If you want to get them before test complete I will send later.

the hdev->setup function is the preferred way since I do not want to duplicate any HCI USB transport logic in any driver.

> 	Most modules can work properly without config file, but some customers may want a special way for example they want to use own bt MAC address rather than the one in modules. The config file provide a flex software way instead of rewrite effuse setting in modules. The config file here is an example and customers may change it if they need. This depend on customer , most notebook products may not need , but smart phone or tablet may use it. I think we cannot cover all the situations and just provide the most common settings.

The case with using an OEM specific BD_ADDR is solved. You just need to add support for hdev->set_bdaddr driver callback and you can modify your Bluetooth public device address. We have a whole set of APIs that just deal with configuring this. The only requirement is that it uses HCI transport.

We also fully integrate chips that have no valid BD_ADDR. Then you just set HCI_QUIRK_INVALID_BDADDR and the kernel keeps the device in unconfigured state until Set Public Address management command is used.

I send details about this to the mailing list. This is tested with chips from Intel and Broadcom in all combinations and works nicely.

Regards

Marcel