From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hu, Robert" Subject: Re: [PATCH OSSTEST 02/12] Increase boot timer to accomodate to nest test Date: Fri, 13 Feb 2015 08:13:22 +0000 Message-ID: <9E79D1C9A97CFD4097BCE431828FDD31B15EE8@SHSMSX103.ccr.corp.intel.com> References: <1423648341-203755-1-git-send-email-robert.hu@intel.com> <1423648341-203755-3-git-send-email-robert.hu@intel.com> <21723.27496.422247.308479@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21723.27496.422247.308479@mariner.uk.xensource.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: "Pang, LongtaoX" , "jfehlig@suse.com" , "wei.liu2@citrix.com" , "ian.campbell@citrix.com" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org > -----Original Message----- > From: Ian Jackson [mailto:Ian.Jackson@eu.citrix.com] > Sent: Wednesday, February 11, 2015 10:47 PM > To: Hu, Robert > Cc: xen-devel@lists.xen.org; jfehlig@suse.com; wei.liu2@citrix.com; > ian.campbell@citrix.com; Pang, LongtaoX > Subject: Re: [PATCH OSSTEST 02/12] Increase boot timer to accomodate to nest > test > > Robert Ho writes ("[PATCH OSSTEST 02/12] Increase boot timer to accomodate > to nest test"): > > In nested test case, guest boot will take more time. > > Increase the timer to 200 seconds. > > Can we make this conditional somehow ? > > I think it should probably be picked up from a runvar. > > We don't currently have timeouts directly in runvars and we probably > don't want them in make-flight. So perhaps we should have a runvar > named after the host indicating that it is a nested virt host. So how about reconsider this? I would suggest that just increase the timer here, since, though it is increased, the timer gets return as long as guest boots up, no impact to existing test cases. > > Obviously that would mean this patch would have to come later in the > series. I'll have to look at the rest of the series to have a clearer > idea what the right thing looks like. > > Thanks, > Ian.