Re: [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm for nested test

["Hu, Robert" <robert.hu@intel.com>]

> -----Original Message-----
> From: Ian Jackson [mailto:Ian.Jackson@eu.citrix.com]
> Sent: Wednesday, April 22, 2015 8:50 PM
> To: Ian Campbell
> Cc: Pang, LongtaoX; xen-devel@lists.xen.org; wei.liu2@citrix.com; Hu, Robert
> Subject: Re: [OSSTEST Nested PATCH v8 3/7] Edit some APIs in TestSupport.pm
> for nested test
> 
> Ian Campbell writes ("Re: [OSSTEST Nested PATCH v8 3/7] Edit some APIs in
> TestSupport.pm for nested test"):
> > It will, I think, need to be integrated with the existing assignment to
> > $ho->{Ip} in select host, so something like:
> >
> >         if ( $r{"${ident}_ip"} ) {
> >             $ho->{Ip}= $r{"${ident}_ip"};
> >         } else {
> >             $ho->{Ip}= $ho->{IpStatic};
> >         }
> 
> Yes.
Yes, otherwise the code would go 'die' somewhere later.
> 
> > or perhaps:
> >
> >         $ho->{Ip} = $r{"${ident}_ip"} ? $r{"${ident}_ip"} : $ho->{IpStatic};
> 
> The shortest way to spell this is to use //, eg:
> 
>       $ho->{Ip} = $r{"${ident}_ip"} // $ho->{IpStatic};
Ah, yes!
> 
> Ian.