From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Hu, Robert" <robert.hu@intel.com>
Subject: Re: [OSSTest Nested v12 19/21] Selecthost uses dynamic
 IP address if the host is not configured static IP.
Date: Mon, 12 Oct 2015 03:05:42 +0000
Message-ID: <9E79D1C9A97CFD4097BCE431828FDD31F3E2F2@SHSMSX103.ccr.corp.intel.com>
References: <1440774490-16725-1-git-send-email-robert.hu@intel.com>
	<1440774490-16725-20-git-send-email-robert.hu@intel.com>
	<22021.32095.128347.295363@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <22021.32095.128347.295363@mariner.uk.xensource.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "Jin, Gordon" <gordon.jin@intel.com>, "wei.liu2@citrix.com" <wei.liu2@citrix.com>, "ian.campbell@citrix.com" <ian.campbell@citrix.com>, "Zheng,
	Di" <di.zheng@intel.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

> -----Original Message-----
> From: Ian Jackson [mailto:Ian.Jackson@eu.citrix.com]
> Sent: Saturday, September 26, 2015 12:59 AM
> To: Hu, Robert <robert.hu@intel.com>
> Cc: xen-devel@lists.xen.org; ian.campbell@citrix.com; wei.liu2@citrix.com;
> Jin, Gordon <gordon.jin@intel.com>; Zheng, Di <di.zheng@intel.com>
> Subject: Re: [OSSTest Nested v12 19/21] Selecthost uses dynamic IP address
> if the host is not configured static IP.
> 
> Robert Ho writes ("[OSSTest Nested v12 19/21] Selecthost uses dynamic IP
> address if the host is not configured static IP."):
> > In this patch
> > 1. in check_ip(), we change $lstash to use {Name} key-value, rather
> > than {Guest}, because {Name} is both usable by $ho and $gho hash.
> > 2. $ho->{Ether} assignment: if configured in host property, good, use
> > it; otherwise, try to see if runvar has the assignment (this is the
> > case of nested test).
> 
> I am going to drop this patch from my v14 of the nested HVM tests
> series.
> 
> This is not because this change is valueless.  But, in the context of
> my other changes, it is no longer needed for supporting L1 guests: L1
> guests do not any longer run through the code path that this patch
> modifies.
> 
> This patch might still be valuable in the future to support physical
> hosts without static IP addresses.  But AFAIAA none of our
> environments have such things and dropping this patch will avoid me
> having to review this code.
> 
> It will also avoid anyone having to test it.
OK. I have no objection if current L1 running around this code path.
> 
> Ian.