Re: [PATCH v5 2/2] nilfs2: use atomic_long_t type for inodes_count and blocks_count fields in nilfs_root struct

[Vyacheslav Dubeyko <slava-yeENwD64cLxBDgjK7y7TUQ@public.gmane.org>]

On May 24, 2013, at 11:01 PM, Jörn Engel wrote:

> On Fri, 24 May 2013 23:30:10 +0400, Vyacheslav Dubeyko wrote:
>> On May 24, 2013, at 9:54 PM, Jörn Engel wrote:
>>> On Fri, 24 May 2013 17:32:52 +0400, Vyacheslav Dubeyko wrote:
>>>> 
>>>> Subject: [PATCH v5 2/2] nilfs2: use atomic_long_t type for inodes_count
>>> ...
>>>> The cp_inodes_count and cp_blocks_count are represented as
>>>> __le64 type in on-disk structure (struct nilfs_checkpoint).
>>> 
>>> Isn't atomic_long_t defined to be 32bit on 32bit architectures?
>> 
>> As I understand, yes.
> 
> And it doesn't concern you to use a 32bit memory structure to
> represent a 64bit on-disk structure? ;)
> 

I suppose that you mean possibility to mount NILFS2 volume under 32 bit architecture
after working with this volume under 64 bit architecture. Am I correct?

Have you any concrete remarks about code of the patch? Feel free to offer your vision.

Thanks,
Vyacheslav Dubeyko.

> Jörn
> 
> --
> Measure. Don't tune for speed until you've measured, and even then
> don't unless one part of the code overwhelms the rest.
> -- Rob Pike
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html