All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Charles Krinke" <ckrinke@istor.com>
To: "Andy Fleming" <afleming@freescale.com>
Cc: Randy Brown <rbrown@istor.com>,
	Chris Carlson <ccarlson@istor.com>,
	Kevin Smith <ksmith@istor.com>,
	linuxppc-embedded@ozlabs.org
Subject: RE: How do external irq's get mapped?
Date: Wed, 2 May 2007 15:11:27 -0700	[thread overview]
Message-ID: <9F3F0A752CAEBE4FA7E906CC2FBFF57C06A201@MERCURY.inside.istor.com> (raw)
In-Reply-To: <762644B1-26D0-4D16-BA36-55364CACB0D4@freescale.com>

> The new problem is that if I set the irq to 112, when it is =20
> insmodded, I
> get an error from open_pic.c of the form:
>
> Open_pic.c:720 invalid irq 112
>
> This seems to be coming from the macro at line 144 in open_pic.c
>
> #define check_arg_irq(irq) \
>     if (irq < open_pic_irq_offset || irq >=3D
> NumSources+open_pic_irq_offset \
> 	|| ISR[irq - open_pic_irq_offset] =3D=3D 0) { \
>       printk("open_pic.c:%d: invalid irq %d\n", __LINE__, irq); \
>       dump_stack(); }


Any  chance you can identify:

1) Where this macro is being called from when it fails

2) Which of the 3 conditions above are actually true

Andy

Dear Andy:

In our system, open_pic_irq_offset=3D80, numSources=3D60, *but* ISR[irq =
-
open_pic_irq_offset]=3DNULL when irq 112 is enabled.

It looks to me like each call to openpic_set_sources inits ISR[]
elements according to the first two arguments. We have two calls to
openpic_set_sources.=20

Internal irqs 00..31, 1st openpic_set_sources(0, 32) -- ISR[0..32]
External irqs 48..60, 2nd openpic_set_sources(48, 12) -- ISR[48..60]=20

But ISR[112] is never initialized in the source base.

I tried the cheap shot of adding a third openpic_set_sources(112, 12),
but I suspect the real answer is a bit more complicated then that.

Again, I thank you for your kind words while I struggle through this
external interrupt initalization for the PPC8541 in the Linux-2.6.17.11
kernel.

Charles Krinke

  reply	other threads:[~2007-05-02 22:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-26 16:10 gcj & PPC405 Patrick Olinet
2007-04-26 18:36 ` IRQ questions & puzzles Charles Krinke
2007-04-27 15:17   ` Charles Krinke
2007-04-27 15:41   ` Jon Loeliger
2007-04-27 16:55     ` How do external irq's get mapped? Charles Krinke
2007-04-27 17:03       ` Sergei Shtylyov
2007-04-27 17:35         ` Jon Loeliger
2007-04-27 17:38         ` Charles Krinke
2007-04-27 17:46           ` Sergei Shtylyov
2007-04-27 18:05             ` Charles Krinke
2007-04-27 18:42               ` Sergei Shtylyov
2007-04-27 19:34                 ` Charles Krinke
2007-04-27 20:58                 ` Charles Krinke
2007-04-27 21:23                   ` Andy Fleming
2007-04-27 22:51                     ` Charles Krinke
2007-04-28  2:30                       ` Zhang Wei-r63237
2007-04-30 16:25                       ` I2C support for 8541 Charles Krinke
2007-05-02 10:43                         ` Clemens Koller
2007-10-13 13:52                         ` Vitaly Bordug
2007-04-30 14:32                 ` How do external irq's get mapped? Charles Krinke
2007-05-01  0:22                   ` Andy Fleming
2007-05-01 23:11                     ` Charles Krinke
2007-05-02 18:42                       ` Andy Fleming
2007-05-02 22:11                         ` Charles Krinke [this message]
2007-05-02 22:43                           ` Andy Fleming
2007-05-03 20:19                             ` Charles Krinke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9F3F0A752CAEBE4FA7E906CC2FBFF57C06A201@MERCURY.inside.istor.com \
    --to=ckrinke@istor.com \
    --cc=afleming@freescale.com \
    --cc=ccarlson@istor.com \
    --cc=ksmith@istor.com \
    --cc=linuxppc-embedded@ozlabs.org \
    --cc=rbrown@istor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.