From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qlq0p-0003Q2-4N for qemu-devel@nongnu.org; Tue, 26 Jul 2011 18:22:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qlq0o-0003ba-9D for qemu-devel@nongnu.org; Tue, 26 Jul 2011 18:22:03 -0400 Received: from va3ehsobe005.messaging.microsoft.com ([216.32.180.31]:22890 helo=VA3EHSOBE005.bigfish.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qlq0o-0003bO-6n for qemu-devel@nongnu.org; Tue, 26 Jul 2011 18:22:02 -0400 From: Yoder Stuart-B08248 Date: Tue, 26 Jul 2011 21:51:45 +0000 Message-ID: <9F6FE96B71CF29479FF1CDC8046E15031876FA@039-SN1MPN1-002.039d.mgd.msft.net> References: <1311670746-20498-1-git-send-email-wuzhy@linux.vnet.ibm.com> <1311670746-20498-2-git-send-email-wuzhy@linux.vnet.ibm.com> <20110726192618.GA8126@amt.cnet> In-Reply-To: <20110726192618.GA8126@amt.cnet> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 04/25] Add hard build dependency on glib List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-devel@nongnu.org" , "aliguori@us.ibm.com" > From: Anthony Liguori >=20 > GLib is an extremely common library that has a portable thread implementa= tion > along with tons of other goodies. >=20 > GLib and GObject have a fantastic amount of infrastructure we can leverag= e in > QEMU including an object oriented programming infrastructure. >=20 > Short term, it has a very nice thread pool implementation that we could l= everage > in something like virtio-9p. It also has a test harness implementation t= hat > this series will use. >=20 > Signed-off-by: Anthony Liguori > Signed-off-by: Michael Roth > Signed-off-by: Luiz Capitulino > --- > Makefile | 2 ++ > Makefile.objs | 1 + > Makefile.target | 1 + > configure | 13 +++++++++++++ > 4 files changed, 17 insertions(+), 0 deletions(-) >=20 > diff --git a/Makefile b/Makefile > index b3ffbe2..42ae4e5 100644 > --- a/Makefile > +++ b/Makefile > @@ -106,6 +106,8 @@ audio/audio.o audio/fmodaudio.o: QEMU_CFLAGS +=3D=20 > $(FMOD_CFLAGS) > =20 > QEMU_CFLAGS+=3D$(CURL_CFLAGS) > =20 > +QEMU_CFLAGS+=3D$(GLIB_CFLAGS) > + > ui/cocoa.o: ui/cocoa.m > =20 > ui/sdl.o audio/sdlaudio.o ui/sdl_zoom.o baum.o: QEMU_CFLAGS +=3D $(SDL_C= FLAGS) > diff --git a/Makefile.objs b/Makefile.objs > index c43ed05..55d18bb 100644 > --- a/Makefile.objs > +++ b/Makefile.objs > @@ -376,3 +376,4 @@ vl.o: QEMU_CFLAGS+=3D$(GPROF_CFLAGS) > =20 > vl.o: QEMU_CFLAGS+=3D$(SDL_CFLAGS) > =20 > +vl.o: QEMU_CFLAGS+=3D$(GLIB_CFLAGS) > diff --git a/Makefile.target b/Makefile.target > index e20a313..cde509b 100644 > --- a/Makefile.target > +++ b/Makefile.target > @@ -204,6 +204,7 @@ QEMU_CFLAGS +=3D $(VNC_TLS_CFLAGS) > QEMU_CFLAGS +=3D $(VNC_SASL_CFLAGS) > QEMU_CFLAGS +=3D $(VNC_JPEG_CFLAGS) > QEMU_CFLAGS +=3D $(VNC_PNG_CFLAGS) > +QEMU_CFLAGS +=3D $(GLIB_CFLAGS) > =20 > # xen support > obj-$(CONFIG_XEN) +=3D xen-all.o xen_machine_pv.o xen_domainbuild.o=20 > xen-mapcache.o > diff --git a/configure b/configure > index e57efb1..c0c8fdf 100755 > --- a/configure > +++ b/configure > @@ -1803,6 +1803,18 @@ EOF > fi > =20 > ########################################## > +# glib support probe > +if $pkg_config --modversion gthread-2.0 gio-2.0 > /dev/null 2>&1 ; then > + glib_cflags=3D`$pkg_config --cflags gthread-2.0 gio-2.0 2>/dev/null` > + glib_libs=3D`$pkg_config --libs gthread-2.0 gio-2.0 2>/dev/null` > + libs_softmmu=3D"$glib_libs $libs_softmmu" > + libs_tools=3D"$glib_libs $libs_tools" > +else > + echo "glib-2.0 required to compile QEMU" > + exit 1 > +fi I am having issues with this in a cross compilation=20 environment. In Power embedded, almost all our development is using cross toolchains. Neither glib or pkg-config are in our cross build environment and I'm having issues getting them built and installed. Not even sure if pkg-config is even supposed to work in a cross development environment...I'm new to that tool and poking around a bit with google raises some questions. Wanted to make you aware of the issue... Stuart