From: Jacob Keller <jacob.e.keller@intel.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: TonyWWang-oc@zhaoxin.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, bp@alien8.de, bp@suse.de,
hpa@zytor.com, jacob.jun.pan@linux.intel.com,
jarkko.sakkinen@linux.intel.com, jmattson@google.com,
jolsa@redhat.com, joro@8bytes.org, kvm@vger.kernel.org,
lenb@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-pm@vger.kernel.org, mark.rutland@arm.com, mingo@redhat.com,
namhyung@kernel.org, pbonzini@redhat.com, peterz@infradead.org,
rkrcmar@redhat.com, shuah@kernel.org, tglx@linutronix.de,
tony.luck@intel.com, vkuznets@redhat.com, wanpengli@tencent.com,
x86@kernel.org
Subject: Re: [PATCH v5 13/19] x86/cpufeatures: Add flag to track whether MSR IA32_FEAT_CTL is configured
Date: Wed, 26 Feb 2020 13:03:01 -0800 [thread overview]
Message-ID: <9a0a7373-f469-f2ae-c218-5821f805f0d8@intel.com> (raw)
In-Reply-To: <20200226205745.GQ9940@linux.intel.com>
On 2/26/2020 12:57 PM, Sean Christopherson wrote:
> Bummer. Using clear_cpu_cap() instead of setup_clear_cpu_cap() was me
> being fancy and trying to allow KVM to identify the case where VMX is
> available and configured on some CPUs but not all. I'll work on a fix.
>
Hmm. Right. For that to work, you'd need to make this disabling happen
significantly later, and/or fix setup_pku to somehow honor this properly.
But it looks like rdmsr is global and not tied to a given CPU anyways?
Thanks,
Jake
next prev parent reply other threads:[~2020-02-26 21:03 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-21 4:44 [PATCH v5 00/19] x86/cpu: Clean up handling of VMX features Sean Christopherson
2019-12-21 4:44 ` [PATCH v5 01/19] x86/msr-index: Clean up bit defines for IA32_FEATURE_CONTROL MSR Sean Christopherson
2020-01-14 10:16 ` [tip: x86/cpu] " tip-bot2 for Sean Christopherson
2019-12-21 4:44 ` [PATCH v5 02/19] selftests: kvm: Replace manual MSR defs with common msr-index.h Sean Christopherson
2020-01-14 10:16 ` [tip: x86/cpu] selftests, " tip-bot2 for Sean Christopherson
2019-12-21 4:44 ` [PATCH v5 03/19] tools arch x86: Sync msr-index.h from kernel sources Sean Christopherson
2020-01-14 10:16 ` [tip: x86/cpu] tools/x86: " tip-bot2 for Sean Christopherson
2019-12-21 4:44 ` [PATCH v5 04/19] x86/intel: Initialize IA32_FEAT_CTL MSR at boot Sean Christopherson
2020-01-14 10:16 ` [tip: x86/cpu] " tip-bot2 for Sean Christopherson
2019-12-21 4:44 ` [PATCH v5 05/19] x86/mce: WARN once if IA32_FEAT_CTL MSR is left unlocked Sean Christopherson
2020-01-14 10:16 ` [tip: x86/cpu] " tip-bot2 for Sean Christopherson
2019-12-21 4:45 ` [PATCH v5 06/19] x86/centaur: Use common IA32_FEAT_CTL MSR initialization Sean Christopherson
2020-01-14 10:16 ` [tip: x86/cpu] " tip-bot2 for Sean Christopherson
2019-12-21 4:45 ` [PATCH v5 07/19] x86/zhaoxin: " Sean Christopherson
2020-01-14 10:16 ` [tip: x86/cpu] " tip-bot2 for Sean Christopherson
2019-12-21 4:45 ` [PATCH v5 08/19] x86/cpu: Clear VMX feature flag if VMX is not fully enabled Sean Christopherson
2020-01-14 10:16 ` [tip: x86/cpu] " tip-bot2 for Sean Christopherson
2020-01-14 20:25 ` [PATCH] x86/cpu: Print "VMX disabled" error message iff KVM is enabled Sean Christopherson
2020-01-15 12:34 ` Borislav Petkov
2020-01-15 12:39 ` [tip: x86/cpu] " tip-bot2 for Sean Christopherson
2019-12-21 4:45 ` [PATCH v5 09/19] x86/vmx: Introduce VMX_FEATURES_* Sean Christopherson
2020-01-14 10:16 ` [tip: x86/cpu] " tip-bot2 for Sean Christopherson
2019-12-21 4:45 ` [PATCH v5 10/19] x86/cpu: Detect VMX features on Intel, Centaur and Zhaoxin CPUs Sean Christopherson
2020-01-14 10:16 ` [tip: x86/cpu] " tip-bot2 for Sean Christopherson
2019-12-21 4:45 ` [PATCH v5 11/19] x86/cpu: Print VMX flags in /proc/cpuinfo using VMX_FEATURES_* Sean Christopherson
2020-01-14 10:16 ` [tip: x86/cpu] " tip-bot2 for Sean Christopherson
2019-12-21 4:45 ` [PATCH v5 12/19] x86/cpu: Set synthetic VMX cpufeatures during init_ia32_feat_ctl() Sean Christopherson
2020-01-14 10:16 ` [tip: x86/cpu] " tip-bot2 for Sean Christopherson
2019-12-21 4:45 ` [PATCH v5 13/19] x86/cpufeatures: Add flag to track whether MSR IA32_FEAT_CTL is configured Sean Christopherson
2020-01-14 10:16 ` [tip: x86/cpu] " tip-bot2 for Sean Christopherson
2020-02-25 21:49 ` [PATCH v5 13/19] " Jacob Keller
2020-02-25 22:12 ` Sean Christopherson
2020-02-25 22:52 ` Jacob Keller
2020-02-25 23:29 ` Sean Christopherson
2020-02-25 23:35 ` Jacob Keller
2020-02-25 23:54 ` Jacob Keller
2020-02-26 0:41 ` Jacob Keller
2020-02-26 0:42 ` Sean Christopherson
2020-02-26 0:58 ` Jacob Keller
2020-02-26 20:41 ` Jacob Keller
2020-02-26 20:57 ` Sean Christopherson
2020-02-26 21:03 ` Jacob Keller [this message]
2020-02-26 21:25 ` Sean Christopherson
2020-02-26 21:53 ` Jacob Keller
2020-02-27 2:12 ` Sean Christopherson
2020-02-27 4:20 ` Huang, Kai
2020-02-27 18:09 ` Jacob Keller
2019-12-21 4:45 ` [PATCH v5 14/19] KVM: VMX: Drop initialization of IA32_FEAT_CTL MSR Sean Christopherson
2020-01-14 10:16 ` [tip: x86/cpu] " tip-bot2 for Sean Christopherson
2019-12-21 4:45 ` [PATCH v5 15/19] KVM: VMX: Use VMX feature flag to query BIOS enabling Sean Christopherson
2020-01-14 10:16 ` [tip: x86/cpu] " tip-bot2 for Sean Christopherson
2019-12-21 4:45 ` [PATCH v5 16/19] KVM: VMX: Check for full VMX support when verifying CPU compatibility Sean Christopherson
2020-01-14 10:16 ` [tip: x86/cpu] " tip-bot2 for Sean Christopherson
2019-12-21 4:45 ` [PATCH v5 17/19] KVM: VMX: Use VMX_FEATURE_* flags to define VMCS control bits Sean Christopherson
2020-01-13 18:32 ` Borislav Petkov
2020-01-13 18:37 ` Sean Christopherson
2020-01-13 18:38 ` Borislav Petkov
2020-01-13 18:42 ` Sean Christopherson
2020-01-13 18:52 ` [PATCH] KVM: VMX: Rename define to CPU_BASED_USE_TSC_OFFSETTING Borislav Petkov
2020-01-13 20:16 ` Sean Christopherson
2020-01-14 9:31 ` Borislav Petkov
2020-01-14 17:27 ` Sean Christopherson
2020-01-14 10:16 ` [tip: x86/cpu] KVM: VMX: Use VMX_FEATURE_* flags to define VMCS control bits tip-bot2 for Sean Christopherson
2019-12-21 4:45 ` [PATCH v5 18/19] perf/x86: Provide stubs of KVM helpers for non-Intel CPUs Sean Christopherson
2020-01-14 10:16 ` [tip: x86/cpu] " tip-bot2 for Sean Christopherson
2019-12-21 4:45 ` [PATCH v5 19/19] KVM: VMX: Allow KVM_INTEL when building for Centaur and/or Zhaoxin CPUs Sean Christopherson
2020-01-14 10:16 ` [tip: x86/cpu] " tip-bot2 for Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a0a7373-f469-f2ae-c218-5821f805f0d8@intel.com \
--to=jacob.e.keller@intel.com \
--cc=TonyWWang-oc@zhaoxin.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jmattson@google.com \
--cc=jolsa@redhat.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.