From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Mon, 12 Sep 2016 12:24:01 -0600
Subject: [U-Boot] [PATCH v1 5/5] colibri_t20: enable dfu also for nand
In-Reply-To: <1473437441-938-6-git-send-email-marcel.ziswiler@toradex.com>
References: <1473437441-938-1-git-send-email-marcel.ziswiler@toradex.com>
 <1473437441-938-6-git-send-email-marcel.ziswiler@toradex.com>
Message-ID: <9a1d3f3d-91fb-1043-b102-cdb489ec1eaf@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 09/09/2016 10:10 AM, Marcel Ziswiler wrote:
> Enable USB gadget DFU functionality for NAND as well.

> diff --git a/include/configs/colibri_t20.h b/include/configs/colibri_t20.h

> +/* USB DFU */
> +#define CONFIG_DFU_NAND

Oh, I see this file already includes tegra-common-usb-gadget.h, so USB 
device-mode is already enabled for this board. Does that make sense 
given that it doesn't actually work?

> +#define DFU_ALT_NAND_INFO	"u-boot part 0,1;ubi part 0,4"
> +
>  #define BOARD_EXTRA_ENV_SETTINGS \
> +	"dfu_alt_info=" DFU_ALT_NAND_INFO "\0" \

I would defer this to the user, since people may choose different flash 
layouts.