From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752456AbeEOH26 (ORCPT ); Tue, 15 May 2018 03:28:58 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:45221 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752433AbeEOH2z (ORCPT ); Tue, 15 May 2018 03:28:55 -0400 X-Google-Smtp-Source: AB8JxZp/Xa3T+/8mDsVk22WO/XZ/1coPMkkBJDJPO9oUs5JFRd1dezq7y7IlRXQzE1dTmxy7onqhMw== Subject: Re: [RFC PATCH 2/5] media: cec-notifier: Get notifier by device and connector name To: Hans Verkuil , airlied@linux.ie, hans.verkuil@cisco.com, lee.jones@linaro.org, olof@lixom.net, seanpaul@google.com Cc: sadolfsson@google.com, felixe@google.com, bleung@google.com, darekm@google.com, marcheu@chromium.org, fparent@baylibre.com, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1526337639-3568-1-git-send-email-narmstrong@baylibre.com> <1526337639-3568-3-git-send-email-narmstrong@baylibre.com> From: Neil Armstrong Openpgp: preference=signencrypt Autocrypt: addr=narmstrong@baylibre.com; prefer-encrypt=mutual; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT7CwHsEEwEKACUC GyMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheABQJXDO2CAhkBAAoJEBaat7Gkz/iubGIH/iyk RqvgB62oKOFlgOTYCMkYpm2aAOZZLf6VKHKc7DoVwuUkjHfIRXdslbrxi4pk5VKU6ZP9AKsN NtMZntB8WrBTtkAZfZbTF7850uwd3eU5cN/7N1Q6g0JQihE7w4GlIkEpQ8vwSg5W7hkx3yQ6 2YzrUZh/b7QThXbNZ7xOeSEms014QXazx8+txR7jrGF3dYxBsCkotO/8DNtZ1R+aUvRfpKg5 ZgABTC0LmAQnuUUf2PHcKFAHZo5KrdO+tyfL+LgTUXIXkK+tenkLsAJ0cagz1EZ5gntuheLD YJuzS4zN+1Asmb9kVKxhjSQOcIh6g2tw7vaYJgL/OzJtZi6JlIXOwE0ETVkGzwEIALyKDN/O GURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYpQTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXM coJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hi SvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY4yG6xI99NIPEVE9lNBXBKIlewIyVlkOa YvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoMMtsyw18YoX9BqMFInxqYQQ3j/HpVgTSv mo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUXoUk33HEAEQEAAcLAXwQYAQIACQUCTVkG zwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfnM7IbRuiSZS1unlySUVYu3SD6YBYnNi3G 5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa33eDIHu/zr1HMKErm+2SD6PO9umRef8V8 2o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCSKmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+ RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJ C3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTTQbM0WUIBIcGmq38+OgUsMYu4NzLu7uZF Acmp6h8g Organization: Baylibre Message-ID: <9a20dfa6-d61a-637a-0311-e260e555f86f@baylibre.com> Date: Tue, 15 May 2018 09:28:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/05/2018 08:27, Hans Verkuil wrote: > Hi Neil, > > Thanks for this patch series! > > Some comments below: > > On 05/15/2018 12:40 AM, Neil Armstrong wrote: >> In non device-tree world, we can need to get the notifier by the driver >> name directly and eventually defer probe if not yet created. >> >> This patch adds a variant of the get function by using the device name >> instead and will not create a notifier if not yet created. >> >> But the i915 driver exposes at least 2 HDMI connectors, this patch also >> adds the possibility to add a connector name tied to the notifier device >> to form a tuple and associate different CEC controllers for each HDMI >> connectors. >> >> Signed-off-by: Neil Armstrong >> --- >> drivers/media/cec/cec-notifier.c | 30 ++++++++++++++++++++++++--- >> include/media/cec-notifier.h | 44 ++++++++++++++++++++++++++++++++++++++-- >> 2 files changed, 69 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/media/cec/cec-notifier.c b/drivers/media/cec/cec-notifier.c >> index 16dffa0..716070a 100644 >> --- a/drivers/media/cec/cec-notifier.c >> +++ b/drivers/media/cec/cec-notifier.c >> @@ -21,6 +21,7 @@ struct cec_notifier { >> struct list_head head; >> struct kref kref; >> struct device *dev; >> + const char *conn; >> struct cec_adapter *cec_adap; >> void (*callback)(struct cec_adapter *adap, u16 pa); >> >> @@ -30,13 +31,34 @@ struct cec_notifier { >> static LIST_HEAD(cec_notifiers); >> static DEFINE_MUTEX(cec_notifiers_lock); >> >> -struct cec_notifier *cec_notifier_get(struct device *dev) >> +struct cec_notifier *cec_notifier_get_byname(const char *name, >> + const char *conn) >> { >> struct cec_notifier *n; >> >> mutex_lock(&cec_notifiers_lock); >> list_for_each_entry(n, &cec_notifiers, head) { >> - if (n->dev == dev) { >> + if (!strcmp(dev_name(n->dev), name) && >> + (!conn || !strcmp(n->conn, conn))) { >> + kref_get(&n->kref); >> + mutex_unlock(&cec_notifiers_lock); >> + return n; >> + } >> + } >> + mutex_unlock(&cec_notifiers_lock); >> + >> + return NULL; > > This doesn't seem right. For one it doesn't act like the other cec_notifier_get* > functions in that it doesn't make a new notifier if it wasn't found yet in the > list. > > For another, I think this function shouldn't be here at all. How about calling > bus_find_device_by_name(), then use cec_notifier_get_conn()? Yes, it's safer and will keep the original cec_notifier_get() behavior. > >> +} >> +EXPORT_SYMBOL_GPL(cec_notifier_get_byname); >> + >> +struct cec_notifier *cec_notifier_get_conn(struct device *dev, const char *conn) >> +{ >> + struct cec_notifier *n; >> + >> + mutex_lock(&cec_notifiers_lock); >> + list_for_each_entry(n, &cec_notifiers, head) { >> + if (n->dev == dev && >> + (!conn || !strcmp(n->conn, conn))) { >> kref_get(&n->kref); >> mutex_unlock(&cec_notifiers_lock); >> return n; >> @@ -46,6 +68,8 @@ struct cec_notifier *cec_notifier_get(struct device *dev) >> if (!n) >> goto unlock; >> n->dev = dev; >> + if (conn) >> + n->conn = devm_kstrdup(dev, conn, GFP_KERNEL); > > The use of devm_kstrdup worries me. The problem is that when the 'dev' device > is removed, this memory is also automatically freed. But the notifier might > still have a reference through the CEC driver, so you end up with a n->conn > pointer that points to freed memory. > > I think it is better to just use kstrdup and kfree it when the last notifier > reference is released. Ok > >> n->phys_addr = CEC_PHYS_ADDR_INVALID; >> mutex_init(&n->lock); >> kref_init(&n->kref); >> @@ -54,7 +78,7 @@ struct cec_notifier *cec_notifier_get(struct device *dev) >> mutex_unlock(&cec_notifiers_lock); >> return n; >> } >> -EXPORT_SYMBOL_GPL(cec_notifier_get); >> +EXPORT_SYMBOL_GPL(cec_notifier_get_conn); >> >> static void cec_notifier_release(struct kref *kref) >> { >> diff --git a/include/media/cec-notifier.h b/include/media/cec-notifier.h >> index cf0add7..70f2974 100644 >> --- a/include/media/cec-notifier.h >> +++ b/include/media/cec-notifier.h >> @@ -20,6 +20,37 @@ struct cec_notifier; >> #if IS_REACHABLE(CONFIG_CEC_CORE) && IS_ENABLED(CONFIG_CEC_NOTIFIER) >> >> /** >> + * cec_notifier_get_byname - find a cec_notifier for the given device name >> + * and connector tuple. >> + * @name: device name that sends the events. >> + * @conn: the connector name from which the event occurs >> + * >> + * If a notifier for device @name exists, then increase the refcount and >> + * return that notifier. >> + * >> + * If it doesn't exist, return NULL >> + */ >> +struct cec_notifier *cec_notifier_get_byname(const char *name, >> + const char *conn); >> + >> +/** >> + * cec_notifier_get_conn - find or create a new cec_notifier for the given >> + * device and connector tuple. >> + * @dev: device that sends the events. >> + * @conn: the connector name from which the event occurs >> + * >> + * If a notifier for device @dev already exists, then increase the refcount >> + * and return that notifier. >> + * >> + * If it doesn't exist, then allocate a new notifier struct and return a >> + * pointer to that new struct. >> + * >> + * Return NULL if the memory could not be allocated. >> + */ >> +struct cec_notifier *cec_notifier_get_conn(struct device *dev, >> + const char *conn); >> + >> +/** >> * cec_notifier_get - find or create a new cec_notifier for the given device. >> * @dev: device that sends the events. >> * >> @@ -31,7 +62,10 @@ struct cec_notifier; >> * >> * Return NULL if the memory could not be allocated. >> */ >> -struct cec_notifier *cec_notifier_get(struct device *dev); >> +static inline struct cec_notifier *cec_notifier_get(struct device *dev) >> +{ >> + return cec_notifier_get_conn(dev, NULL); >> +} >> >> /** >> * cec_notifier_put - decrease refcount and delete when the refcount reaches 0. >> @@ -85,12 +119,18 @@ void cec_register_cec_notifier(struct cec_adapter *adap, >> struct cec_notifier *notifier); >> >> #else >> -static inline struct cec_notifier *cec_notifier_get(struct device *dev) >> +static inline struct cec_notifier *cec_notifier_get_conn(struct device *dev, >> + const char *conn) >> { >> /* A non-NULL pointer is expected on success */ >> return (struct cec_notifier *)0xdeadfeed; >> } >> >> +static inline struct cec_notifier *cec_notifier_get(struct device *dev) >> +{ >> + return cec_notifier_get_conn(dev, NULL); >> +} >> + >> static inline void cec_notifier_put(struct cec_notifier *n) >> { >> } >> > > Regards, > > Hans > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Armstrong Subject: Re: [RFC PATCH 2/5] media: cec-notifier: Get notifier by device and connector name Date: Tue, 15 May 2018 09:28:51 +0200 Message-ID: <9a20dfa6-d61a-637a-0311-e260e555f86f@baylibre.com> References: <1526337639-3568-1-git-send-email-narmstrong@baylibre.com> <1526337639-3568-3-git-send-email-narmstrong@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Hans Verkuil , airlied@linux.ie, hans.verkuil@cisco.com, lee.jones@linaro.org, olof@lixom.net, seanpaul@google.com Cc: sadolfsson@google.com, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, fparent@baylibre.com, felixe@google.com, bleung@google.com, darekm@google.com, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gMTUvMDUvMjAxOCAwODoyNywgSGFucyBWZXJrdWlsIHdyb3RlOgo+IEhpIE5laWwsCj4gCj4g VGhhbmtzIGZvciB0aGlzIHBhdGNoIHNlcmllcyEKPiAKPiBTb21lIGNvbW1lbnRzIGJlbG93Ogo+ IAo+IE9uIDA1LzE1LzIwMTggMTI6NDAgQU0sIE5laWwgQXJtc3Ryb25nIHdyb3RlOgo+PiBJbiBu b24gZGV2aWNlLXRyZWUgd29ybGQsIHdlIGNhbiBuZWVkIHRvIGdldCB0aGUgbm90aWZpZXIgYnkg dGhlIGRyaXZlcgo+PiBuYW1lIGRpcmVjdGx5IGFuZCBldmVudHVhbGx5IGRlZmVyIHByb2JlIGlm IG5vdCB5ZXQgY3JlYXRlZC4KPj4KPj4gVGhpcyBwYXRjaCBhZGRzIGEgdmFyaWFudCBvZiB0aGUg Z2V0IGZ1bmN0aW9uIGJ5IHVzaW5nIHRoZSBkZXZpY2UgbmFtZQo+PiBpbnN0ZWFkIGFuZCB3aWxs IG5vdCBjcmVhdGUgYSBub3RpZmllciBpZiBub3QgeWV0IGNyZWF0ZWQuCj4+Cj4+IEJ1dCB0aGUg aTkxNSBkcml2ZXIgZXhwb3NlcyBhdCBsZWFzdCAyIEhETUkgY29ubmVjdG9ycywgdGhpcyBwYXRj aCBhbHNvCj4+IGFkZHMgdGhlIHBvc3NpYmlsaXR5IHRvIGFkZCBhIGNvbm5lY3RvciBuYW1lIHRp ZWQgdG8gdGhlIG5vdGlmaWVyIGRldmljZQo+PiB0byBmb3JtIGEgdHVwbGUgYW5kIGFzc29jaWF0 ZSBkaWZmZXJlbnQgQ0VDIGNvbnRyb2xsZXJzIGZvciBlYWNoIEhETUkKPj4gY29ubmVjdG9ycy4K Pj4KPj4gU2lnbmVkLW9mZi1ieTogTmVpbCBBcm1zdHJvbmcgPG5hcm1zdHJvbmdAYmF5bGlicmUu Y29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvbWVkaWEvY2VjL2NlYy1ub3RpZmllci5jIHwgMzAgKysr KysrKysrKysrKysrKysrKysrKysrLS0tCj4+ICBpbmNsdWRlL21lZGlhL2NlYy1ub3RpZmllci5o ICAgICB8IDQ0ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0KPj4gIDIg ZmlsZXMgY2hhbmdlZCwgNjkgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPj4KPj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvY2VjL2NlYy1ub3RpZmllci5jIGIvZHJpdmVycy9tZWRp YS9jZWMvY2VjLW5vdGlmaWVyLmMKPj4gaW5kZXggMTZkZmZhMC4uNzE2MDcwYSAxMDA2NDQKPj4g LS0tIGEvZHJpdmVycy9tZWRpYS9jZWMvY2VjLW5vdGlmaWVyLmMKPj4gKysrIGIvZHJpdmVycy9t ZWRpYS9jZWMvY2VjLW5vdGlmaWVyLmMKPj4gQEAgLTIxLDYgKzIxLDcgQEAgc3RydWN0IGNlY19u b3RpZmllciB7Cj4+ICAJc3RydWN0IGxpc3RfaGVhZCBoZWFkOwo+PiAgCXN0cnVjdCBrcmVmIGty ZWY7Cj4+ICAJc3RydWN0IGRldmljZSAqZGV2Owo+PiArCWNvbnN0IGNoYXIgKmNvbm47Cj4+ICAJ c3RydWN0IGNlY19hZGFwdGVyICpjZWNfYWRhcDsKPj4gIAl2b2lkICgqY2FsbGJhY2spKHN0cnVj dCBjZWNfYWRhcHRlciAqYWRhcCwgdTE2IHBhKTsKPj4gIAo+PiBAQCAtMzAsMTMgKzMxLDM0IEBA IHN0cnVjdCBjZWNfbm90aWZpZXIgewo+PiAgc3RhdGljIExJU1RfSEVBRChjZWNfbm90aWZpZXJz KTsKPj4gIHN0YXRpYyBERUZJTkVfTVVURVgoY2VjX25vdGlmaWVyc19sb2NrKTsKPj4gIAo+PiAt c3RydWN0IGNlY19ub3RpZmllciAqY2VjX25vdGlmaWVyX2dldChzdHJ1Y3QgZGV2aWNlICpkZXYp Cj4+ICtzdHJ1Y3QgY2VjX25vdGlmaWVyICpjZWNfbm90aWZpZXJfZ2V0X2J5bmFtZShjb25zdCBj aGFyICpuYW1lLAo+PiArCQkJCQkgICAgIGNvbnN0IGNoYXIgKmNvbm4pCj4+ICB7Cj4+ICAJc3Ry dWN0IGNlY19ub3RpZmllciAqbjsKPj4gIAo+PiAgCW11dGV4X2xvY2soJmNlY19ub3RpZmllcnNf bG9jayk7Cj4+ICAJbGlzdF9mb3JfZWFjaF9lbnRyeShuLCAmY2VjX25vdGlmaWVycywgaGVhZCkg ewo+PiAtCQlpZiAobi0+ZGV2ID09IGRldikgewo+PiArCQlpZiAoIXN0cmNtcChkZXZfbmFtZShu LT5kZXYpLCBuYW1lKSAmJgo+PiArCQkgICAgKCFjb25uIHx8ICFzdHJjbXAobi0+Y29ubiwgY29u bikpKSB7Cj4+ICsJCQlrcmVmX2dldCgmbi0+a3JlZik7Cj4+ICsJCQltdXRleF91bmxvY2soJmNl Y19ub3RpZmllcnNfbG9jayk7Cj4+ICsJCQlyZXR1cm4gbjsKPj4gKwkJfQo+PiArCX0KPj4gKwlt dXRleF91bmxvY2soJmNlY19ub3RpZmllcnNfbG9jayk7Cj4+ICsKPj4gKwlyZXR1cm4gTlVMTDsK PiAKPiBUaGlzIGRvZXNuJ3Qgc2VlbSByaWdodC4gRm9yIG9uZSBpdCBkb2Vzbid0IGFjdCBsaWtl IHRoZSBvdGhlciBjZWNfbm90aWZpZXJfZ2V0Kgo+IGZ1bmN0aW9ucyBpbiB0aGF0IGl0IGRvZXNu J3QgbWFrZSBhIG5ldyBub3RpZmllciBpZiBpdCB3YXNuJ3QgZm91bmQgeWV0IGluIHRoZQo+IGxp c3QuCj4gCj4gRm9yIGFub3RoZXIsIEkgdGhpbmsgdGhpcyBmdW5jdGlvbiBzaG91bGRuJ3QgYmUg aGVyZSBhdCBhbGwuIEhvdyBhYm91dCBjYWxsaW5nCj4gYnVzX2ZpbmRfZGV2aWNlX2J5X25hbWUo KSwgdGhlbiB1c2UgY2VjX25vdGlmaWVyX2dldF9jb25uKCk/CgpZZXMsIGl0J3Mgc2FmZXIgYW5k IHdpbGwga2VlcCB0aGUgb3JpZ2luYWwgY2VjX25vdGlmaWVyX2dldCgpIGJlaGF2aW9yLgoKPiAK Pj4gK30KPj4gK0VYUE9SVF9TWU1CT0xfR1BMKGNlY19ub3RpZmllcl9nZXRfYnluYW1lKTsKPj4g Kwo+PiArc3RydWN0IGNlY19ub3RpZmllciAqY2VjX25vdGlmaWVyX2dldF9jb25uKHN0cnVjdCBk ZXZpY2UgKmRldiwgY29uc3QgY2hhciAqY29ubikKPj4gK3sKPj4gKwlzdHJ1Y3QgY2VjX25vdGlm aWVyICpuOwo+PiArCj4+ICsJbXV0ZXhfbG9jaygmY2VjX25vdGlmaWVyc19sb2NrKTsKPj4gKwls aXN0X2Zvcl9lYWNoX2VudHJ5KG4sICZjZWNfbm90aWZpZXJzLCBoZWFkKSB7Cj4+ICsJCWlmIChu LT5kZXYgPT0gZGV2ICYmCj4+ICsJCSAgICAoIWNvbm4gfHwgIXN0cmNtcChuLT5jb25uLCBjb25u KSkpIHsKPj4gIAkJCWtyZWZfZ2V0KCZuLT5rcmVmKTsKPj4gIAkJCW11dGV4X3VubG9jaygmY2Vj X25vdGlmaWVyc19sb2NrKTsKPj4gIAkJCXJldHVybiBuOwo+PiBAQCAtNDYsNiArNjgsOCBAQCBz dHJ1Y3QgY2VjX25vdGlmaWVyICpjZWNfbm90aWZpZXJfZ2V0KHN0cnVjdCBkZXZpY2UgKmRldikK Pj4gIAlpZiAoIW4pCj4+ICAJCWdvdG8gdW5sb2NrOwo+PiAgCW4tPmRldiA9IGRldjsKPj4gKwlp ZiAoY29ubikKPj4gKwkJbi0+Y29ubiA9IGRldm1fa3N0cmR1cChkZXYsIGNvbm4sIEdGUF9LRVJO RUwpOwo+IAo+IFRoZSB1c2Ugb2YgZGV2bV9rc3RyZHVwIHdvcnJpZXMgbWUuIFRoZSBwcm9ibGVt IGlzIHRoYXQgd2hlbiB0aGUgJ2RldicgZGV2aWNlCj4gaXMgcmVtb3ZlZCwgdGhpcyBtZW1vcnkg aXMgYWxzbyBhdXRvbWF0aWNhbGx5IGZyZWVkLiBCdXQgdGhlIG5vdGlmaWVyIG1pZ2h0Cj4gc3Rp bGwgaGF2ZSBhIHJlZmVyZW5jZSB0aHJvdWdoIHRoZSBDRUMgZHJpdmVyLCBzbyB5b3UgZW5kIHVw IHdpdGggYSBuLT5jb25uCj4gcG9pbnRlciB0aGF0IHBvaW50cyB0byBmcmVlZCBtZW1vcnkuCj4g Cj4gSSB0aGluayBpdCBpcyBiZXR0ZXIgdG8ganVzdCB1c2Uga3N0cmR1cCBhbmQga2ZyZWUgaXQg d2hlbiB0aGUgbGFzdCBub3RpZmllcgo+IHJlZmVyZW5jZSBpcyByZWxlYXNlZC4KCk9rCgo+IAo+ PiAgCW4tPnBoeXNfYWRkciA9IENFQ19QSFlTX0FERFJfSU5WQUxJRDsKPj4gIAltdXRleF9pbml0 KCZuLT5sb2NrKTsKPj4gIAlrcmVmX2luaXQoJm4tPmtyZWYpOwo+PiBAQCAtNTQsNyArNzgsNyBA QCBzdHJ1Y3QgY2VjX25vdGlmaWVyICpjZWNfbm90aWZpZXJfZ2V0KHN0cnVjdCBkZXZpY2UgKmRl dikKPj4gIAltdXRleF91bmxvY2soJmNlY19ub3RpZmllcnNfbG9jayk7Cj4+ICAJcmV0dXJuIG47 Cj4+ICB9Cj4+IC1FWFBPUlRfU1lNQk9MX0dQTChjZWNfbm90aWZpZXJfZ2V0KTsKPj4gK0VYUE9S VF9TWU1CT0xfR1BMKGNlY19ub3RpZmllcl9nZXRfY29ubik7Cj4+ICAKPj4gIHN0YXRpYyB2b2lk IGNlY19ub3RpZmllcl9yZWxlYXNlKHN0cnVjdCBrcmVmICprcmVmKQo+PiAgewo+PiBkaWZmIC0t Z2l0IGEvaW5jbHVkZS9tZWRpYS9jZWMtbm90aWZpZXIuaCBiL2luY2x1ZGUvbWVkaWEvY2VjLW5v dGlmaWVyLmgKPj4gaW5kZXggY2YwYWRkNy4uNzBmMjk3NCAxMDA2NDQKPj4gLS0tIGEvaW5jbHVk ZS9tZWRpYS9jZWMtbm90aWZpZXIuaAo+PiArKysgYi9pbmNsdWRlL21lZGlhL2NlYy1ub3RpZmll ci5oCj4+IEBAIC0yMCw2ICsyMCwzNyBAQCBzdHJ1Y3QgY2VjX25vdGlmaWVyOwo+PiAgI2lmIElT X1JFQUNIQUJMRShDT05GSUdfQ0VDX0NPUkUpICYmIElTX0VOQUJMRUQoQ09ORklHX0NFQ19OT1RJ RklFUikKPj4gIAo+PiAgLyoqCj4+ICsgKiBjZWNfbm90aWZpZXJfZ2V0X2J5bmFtZSAtIGZpbmQg YSBjZWNfbm90aWZpZXIgZm9yIHRoZSBnaXZlbiBkZXZpY2UgbmFtZQo+PiArICogYW5kIGNvbm5l Y3RvciB0dXBsZS4KPj4gKyAqIEBuYW1lOiBkZXZpY2UgbmFtZSB0aGF0IHNlbmRzIHRoZSBldmVu dHMuCj4+ICsgKiBAY29ubjogdGhlIGNvbm5lY3RvciBuYW1lIGZyb20gd2hpY2ggdGhlIGV2ZW50 IG9jY3Vycwo+PiArICoKPj4gKyAqIElmIGEgbm90aWZpZXIgZm9yIGRldmljZSBAbmFtZSBleGlz dHMsIHRoZW4gaW5jcmVhc2UgdGhlIHJlZmNvdW50IGFuZAo+PiArICogcmV0dXJuIHRoYXQgbm90 aWZpZXIuCj4+ICsgKgo+PiArICogSWYgaXQgZG9lc24ndCBleGlzdCwgcmV0dXJuIE5VTEwKPj4g KyAqLwo+PiArc3RydWN0IGNlY19ub3RpZmllciAqY2VjX25vdGlmaWVyX2dldF9ieW5hbWUoY29u c3QgY2hhciAqbmFtZSwKPj4gKwkJCQkJICAgICBjb25zdCBjaGFyICpjb25uKTsKPj4gKwo+PiAr LyoqCj4+ICsgKiBjZWNfbm90aWZpZXJfZ2V0X2Nvbm4gLSBmaW5kIG9yIGNyZWF0ZSBhIG5ldyBj ZWNfbm90aWZpZXIgZm9yIHRoZSBnaXZlbgo+PiArICogZGV2aWNlIGFuZCBjb25uZWN0b3IgdHVw bGUuCj4+ICsgKiBAZGV2OiBkZXZpY2UgdGhhdCBzZW5kcyB0aGUgZXZlbnRzLgo+PiArICogQGNv bm46IHRoZSBjb25uZWN0b3IgbmFtZSBmcm9tIHdoaWNoIHRoZSBldmVudCBvY2N1cnMKPj4gKyAq Cj4+ICsgKiBJZiBhIG5vdGlmaWVyIGZvciBkZXZpY2UgQGRldiBhbHJlYWR5IGV4aXN0cywgdGhl biBpbmNyZWFzZSB0aGUgcmVmY291bnQKPj4gKyAqIGFuZCByZXR1cm4gdGhhdCBub3RpZmllci4K Pj4gKyAqCj4+ICsgKiBJZiBpdCBkb2Vzbid0IGV4aXN0LCB0aGVuIGFsbG9jYXRlIGEgbmV3IG5v dGlmaWVyIHN0cnVjdCBhbmQgcmV0dXJuIGEKPj4gKyAqIHBvaW50ZXIgdG8gdGhhdCBuZXcgc3Ry dWN0Lgo+PiArICoKPj4gKyAqIFJldHVybiBOVUxMIGlmIHRoZSBtZW1vcnkgY291bGQgbm90IGJl IGFsbG9jYXRlZC4KPj4gKyAqLwo+PiArc3RydWN0IGNlY19ub3RpZmllciAqY2VjX25vdGlmaWVy X2dldF9jb25uKHN0cnVjdCBkZXZpY2UgKmRldiwKPj4gKwkJCQkJICAgY29uc3QgY2hhciAqY29u bik7Cj4+ICsKPj4gKy8qKgo+PiAgICogY2VjX25vdGlmaWVyX2dldCAtIGZpbmQgb3IgY3JlYXRl IGEgbmV3IGNlY19ub3RpZmllciBmb3IgdGhlIGdpdmVuIGRldmljZS4KPj4gICAqIEBkZXY6IGRl dmljZSB0aGF0IHNlbmRzIHRoZSBldmVudHMuCj4+ICAgKgo+PiBAQCAtMzEsNyArNjIsMTAgQEAg c3RydWN0IGNlY19ub3RpZmllcjsKPj4gICAqCj4+ICAgKiBSZXR1cm4gTlVMTCBpZiB0aGUgbWVt b3J5IGNvdWxkIG5vdCBiZSBhbGxvY2F0ZWQuCj4+ICAgKi8KPj4gLXN0cnVjdCBjZWNfbm90aWZp ZXIgKmNlY19ub3RpZmllcl9nZXQoc3RydWN0IGRldmljZSAqZGV2KTsKPj4gK3N0YXRpYyBpbmxp bmUgc3RydWN0IGNlY19ub3RpZmllciAqY2VjX25vdGlmaWVyX2dldChzdHJ1Y3QgZGV2aWNlICpk ZXYpCj4+ICt7Cj4+ICsJcmV0dXJuIGNlY19ub3RpZmllcl9nZXRfY29ubihkZXYsIE5VTEwpOwo+ PiArfQo+PiAgCj4+ICAvKioKPj4gICAqIGNlY19ub3RpZmllcl9wdXQgLSBkZWNyZWFzZSByZWZj b3VudCBhbmQgZGVsZXRlIHdoZW4gdGhlIHJlZmNvdW50IHJlYWNoZXMgMC4KPj4gQEAgLTg1LDEy ICsxMTksMTggQEAgdm9pZCBjZWNfcmVnaXN0ZXJfY2VjX25vdGlmaWVyKHN0cnVjdCBjZWNfYWRh cHRlciAqYWRhcCwKPj4gIAkJCSAgICAgICBzdHJ1Y3QgY2VjX25vdGlmaWVyICpub3RpZmllcik7 Cj4+ICAKPj4gICNlbHNlCj4+IC1zdGF0aWMgaW5saW5lIHN0cnVjdCBjZWNfbm90aWZpZXIgKmNl Y19ub3RpZmllcl9nZXQoc3RydWN0IGRldmljZSAqZGV2KQo+PiArc3RhdGljIGlubGluZSBzdHJ1 Y3QgY2VjX25vdGlmaWVyICpjZWNfbm90aWZpZXJfZ2V0X2Nvbm4oc3RydWN0IGRldmljZSAqZGV2 LAo+PiArCQkJCQkJCSBjb25zdCBjaGFyICpjb25uKQo+PiAgewo+PiAgCS8qIEEgbm9uLU5VTEwg cG9pbnRlciBpcyBleHBlY3RlZCBvbiBzdWNjZXNzICovCj4+ICAJcmV0dXJuIChzdHJ1Y3QgY2Vj X25vdGlmaWVyICopMHhkZWFkZmVlZDsKPj4gIH0KPj4gIAo+PiArc3RhdGljIGlubGluZSBzdHJ1 Y3QgY2VjX25vdGlmaWVyICpjZWNfbm90aWZpZXJfZ2V0KHN0cnVjdCBkZXZpY2UgKmRldikKPj4g K3sKPj4gKwlyZXR1cm4gY2VjX25vdGlmaWVyX2dldF9jb25uKGRldiwgTlVMTCk7Cj4+ICt9Cj4+ ICsKPj4gIHN0YXRpYyBpbmxpbmUgdm9pZCBjZWNfbm90aWZpZXJfcHV0KHN0cnVjdCBjZWNfbm90 aWZpZXIgKm4pCj4+ICB7Cj4+ICB9Cj4+Cj4gCj4gUmVnYXJkcywKPiAKPiAJSGFucwo+IAoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==