From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:29834 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726637AbgD2PMy (ORCPT ); Wed, 29 Apr 2020 11:12:54 -0400 Subject: Re: [PATCH v3 05/10] s390x: smp: Loop if secondary cpu returns into cpu setup again References: <20200429143518.1360468-1-frankja@linux.ibm.com> <20200429143518.1360468-6-frankja@linux.ibm.com> From: David Hildenbrand Message-ID: <9a310a43-b759-494b-9d90-7d145980d394@redhat.com> Date: Wed, 29 Apr 2020 17:12:47 +0200 MIME-Version: 1.0 In-Reply-To: <20200429143518.1360468-6-frankja@linux.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-s390-owner@vger.kernel.org List-ID: To: Janosch Frank , kvm@vger.kernel.org Cc: thuth@redhat.com, linux-s390@vger.kernel.org, borntraeger@de.ibm.com, cohuck@redhat.com On 29.04.20 16:35, Janosch Frank wrote: > Up to now a secondary cpu could have returned from the function it was > executing and ending up somewhere in cstart64.S. This was mostly > circumvented by an endless loop in the function that it executed. > > Let's add a loop to the end of the cpu setup, so we don't have to rely > on added loops in the tests. > > Signed-off-by: Janosch Frank > Reviewed-by: Cornelia Huck > --- > s390x/cstart64.S | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/s390x/cstart64.S b/s390x/cstart64.S > index 9af6bb3..ecffbe0 100644 > --- a/s390x/cstart64.S > +++ b/s390x/cstart64.S > @@ -161,7 +161,9 @@ smp_cpu_setup_state: > lctlg %c0, %c0, GEN_LC_SW_INT_CRS > /* We should only go once through cpu setup and not for every restart */ > stg %r14, GEN_LC_RESTART_NEW_PSW + 8 > - br %r14 > + brasl %r14, %r14 > + /* If the function returns, just loop here */ > +0: j 0 > > pgm_int: > SAVE_REGS > Acked-by: David Hildenbrand -- Thanks, David / dhildenb