From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [PATCH] versal: watchdog: Add support for Xilinx window watchdog
Date: Wed, 11 Mar 2020 13:31:49 +0100 [thread overview]
Message-ID: <9a438a05-e45b-d30f-3740-b7524123fa7f@xilinx.com> (raw)
In-Reply-To: <20200311115458.GH1922688@smile.fi.intel.com>
On 11. 03. 20 12:54, Andy Shevchenko wrote:
> On Wed, Mar 11, 2020 at 12:34:33PM +0100, Michal Simek wrote:
>> On 11. 03. 20 12:25, Stefan Roese wrote:
>>> On 11.03.20 11:48, Michal Simek wrote:
>>>> From: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
>
>>>> +struct wwdt_regs {
>>>> +??? u32 reserved0[1024];
>>>> +??? u32 refresh;??????? /* Refresh Register [0x1000] */
>>>> +??? u32 reserved1[1023];
>>>> +??? u32 csr;??????? /* Control/Status Register [0x2000] */
>>>> +??? u32 reserved2;
>>>> +??? u32 offset;??????? /* Offset Register [0x2008] */
>>>> +??? u32 reserved3;
>>>> +??? u32 cmp0;??????? /* Compare Value Register0 [0x2010] */
>>>> +??? u32 cmp1;??????? /* Compare Value Register1 [0x2014] */
>>>> +??? u32 reserved4[1006];
>>>> +??? u32 warmrst;??????? /* Warm Reset Register [0x2FD0] */
>>>> +};
>>>
>>> My understanding is, that we moved to using defines instead of structs
>>> for register definitions. So if you need to send a v2, then please
>>> consider using #defines here.
>>
>> When was that decision done? Any link to documentation/commit message?
>>
>> Origin driver had macros but I have asked Ashok to change it to
>> structure based.
>
> I don't know how many wasted kbytes Xilinx can afford, but in general it's a
> bad example to waste memory as above.
> Any issues with regmap approach?
If regmap is recommended way how to write u-boot driver I have really
not a problem with it.
Thanks,
Michal
next prev parent reply other threads:[~2020-03-11 12:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 10:48 [PATCH] versal: watchdog: Add support for Xilinx window watchdog Michal Simek
2020-03-11 11:25 ` Stefan Roese
2020-03-11 11:34 ` Michal Simek
2020-03-11 11:54 ` Andy Shevchenko
2020-03-11 12:31 ` Michal Simek [this message]
2020-03-11 11:56 ` Stefan Roese
2020-03-11 12:11 ` Michal Simek
2020-03-11 14:28 ` Tom Rini
2020-03-11 14:30 ` Michal Simek
2020-03-11 11:52 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a438a05-e45b-d30f-3740-b7524123fa7f@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.