From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhS9G-0003pX-RH for qemu-devel@nongnu.org; Tue, 06 Sep 2016 21:59:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhS9B-0007Hg-S8 for qemu-devel@nongnu.org; Tue, 06 Sep 2016 21:59:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46256) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhS9B-0007Hc-K1 for qemu-devel@nongnu.org; Tue, 06 Sep 2016 21:59:29 -0400 References: <1472063464-790-1-git-send-email-silbe@linux.vnet.ibm.com> <1472063464-790-2-git-send-email-silbe@linux.vnet.ibm.com> <20160906013045.GA653@al.usersys.redhat.com> <87fupchobz.fsf@oc4731375738.ibm.com> <20160907015336.GB30281@lemon> From: Eric Blake Message-ID: <9a5028af-9009-5009-0efc-a12c60f162ae@redhat.com> Date: Tue, 6 Sep 2016 20:59:27 -0500 MIME-Version: 1.0 In-Reply-To: <20160907015336.GB30281@lemon> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lxapELQJSjhjO1DeORjKlHhn6F06RK4DS" Subject: Re: [Qemu-devel] [PATCH v2 1/7] docker.py: don't hang on large docker output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , Sascha Silbe Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lxapELQJSjhjO1DeORjKlHhn6F06RK4DS From: Eric Blake To: Fam Zheng , Sascha Silbe Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org Message-ID: <9a5028af-9009-5009-0efc-a12c60f162ae@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 1/7] docker.py: don't hang on large docker output References: <1472063464-790-1-git-send-email-silbe@linux.vnet.ibm.com> <1472063464-790-2-git-send-email-silbe@linux.vnet.ibm.com> <20160906013045.GA653@al.usersys.redhat.com> <87fupchobz.fsf@oc4731375738.ibm.com> <20160907015336.GB30281@lemon> In-Reply-To: <20160907015336.GB30281@lemon> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/06/2016 08:53 PM, Fam Zheng wrote: >>> >>> Too many blank lines? Otherwise looks good. >> >> You caught me sneaking in a PEP-8 compliance fix. ;) >=20 > Ah, no problem. I just didn't know. >=20 >> >> Is qemu using a custom code style for Python sources? If so, is it >> documented somewhere? >=20 > No, and following PEP-8 is completely fine. Although it never hurts to mention stuff like this in the commit message, to make it obvious that it was intentional :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lxapELQJSjhjO1DeORjKlHhn6F06RK4DS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXz3R/AAoJEKeha0olJ0NqQRsH/0kxlbfTZm1vofCoRYJ/P5Zt UfZxjgKljuyFEzRl/2iqB2/8ATGo9K7DWs9D0UK+J/vpi+814jHlhJundd6Pa09G OO48VeZiI6sNxUzzO64AxXD28MWsL3nmz5iDT95eocY8Jt8Ofi38Q2fLaP57cD56 zGUwufa82TjDhCAGrEG1TRe1pdqJngFsnCg9pKBL7szfA84uR4C62d2euuRWTOF4 vyJvmOGPqT+E/078oRG2yjjmQ+I6ENJRzgb6TGDnf8c1voUhsGHkPSYdQtAWWj21 C2ysSMyt9YFtWcqjc9pB7btY+6OR8YviIldQKNIftdmC5qOAnX/Y/Cm2dJn0gVA= =W04W -----END PGP SIGNATURE----- --lxapELQJSjhjO1DeORjKlHhn6F06RK4DS--