Re: [PATCH v6 03/14] ASoC: SOF: Add driver debug support. - Pierre-Louis Bossart

From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Dragos Tarcatu <dragos_tarcatu@mentor.com>,
	alsa-devel@alsa-project.org,
	sound-open-firmware@alsa-project.org, tiwai@suse.de,
	Pan Xiuli <xiuli.pan@linux.intel.com>,
	Daniel Baluta <daniel.baluta@gmail.com>,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	liam.r.girdwood@linux.intel.com, vkoul@kernel.org,
	andriy.shevchenko@linux.intel.com,
	Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH v6 03/14] ASoC: SOF: Add driver debug support.
Date: Fri, 19 Apr 2019 11:09:51 -0500	[thread overview]
Message-ID: <9a5609c3-df05-2dcc-69b7-b10fe2dc221d@linux.intel.com> (raw)
In-Reply-To: <20190419155458.GV2803@sirena.org.uk>

Thanks for the review Mark

On 4/19/19 10:54 AM, Mark Brown wrote:
> On Fri, Apr 12, 2019 at 11:05:08AM -0500, Pierre-Louis Bossart wrote:
> 
>> +		if (pm_runtime_active(sdev->dev) ||
>> +		    dfse->access_type == SOF_DEBUGFS_ACCESS_ALWAYS) {
>> +			memcpy_fromio(buf, dfse->io_mem + pos, size);
>> +		} else {
>> +			dev_info(sdev->dev,
>> +				 "Copying cached debugfs data\n");
>> +			memcpy(buf, dfse->cache_buf + pos, size);
>> +		}
> 
> Might this get a bit noisy if we start hitting the info case?

Indeed, I recall we discussed removing this log but it's still there. We 
can fix this with a follow-up patch or in a v7 depending if there are 
other comments.