All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: qemu-devel@nongnu.org
Cc: Ziyue Yang <yzylivezh@hotmail.com>,
	qemu-trivial@nongnu.org, Ziyue Yang <skiver.cloud.yzy@gmail.com>,
	Michael Tokarev <mjt@tls.msk.ru>
Subject: [Qemu-devel] [PULL 29/31] gdbstub.c: update old error report statements
Date: Tue, 24 Jan 2017 12:39:33 +0300	[thread overview]
Message-ID: <9a5bfc35921a1060c5596e7cd0dfda6a30093d49.1485250702.git.mjt@msgid.tls.msk.ru> (raw)
In-Reply-To: <cover.1485250702.git.mjt@msgid.tls.msk.ru>
In-Reply-To: <cover.1485250702.git.mjt@msgid.tls.msk.ru>

From: Ziyue Yang <yzylivezh@hotmail.com>

Some updates from fprintf(stderr, ...) to error_report.

Signed-off-by: Ziyue Yang <skiver.cloud.yzy@gmail.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 gdbstub.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/gdbstub.c b/gdbstub.c
index 27e0923..2d18ed7 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -638,8 +638,8 @@ void gdb_register_coprocessor(CPUState *cpu,
     *p = s;
     if (g_pos) {
         if (g_pos != s->base_reg) {
-            fprintf(stderr, "Error: Bad gdb register numbering for '%s'\n"
-                    "Expected %d got %d\n", xml, g_pos, s->base_reg);
+            error_report("Error: Bad gdb register numbering for '%s', "
+                         "expected %d got %d", xml, g_pos, s->base_reg);
         } else {
             cpu->gdb_num_g_regs = cpu->gdb_num_regs;
         }
@@ -891,7 +891,7 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf)
         }
     case 'k':
         /* Kill the target */
-        fprintf(stderr, "\nQEMU: Terminated via GDBstub\n");
+        error_report("QEMU: Terminated via GDBstub");
         exit(0);
     case 'D':
         /* Detach packet */
@@ -1359,8 +1359,8 @@ void gdb_do_syscallv(gdb_syscall_complete_cb cb, const char *fmt, va_list va)
                 break;
             default:
             bad_format:
-                fprintf(stderr, "gdbstub: Bad syscall format string '%s'\n",
-                        fmt - 1);
+                error_report("gdbstub: Bad syscall format string '%s'",
+                             fmt - 1);
                 break;
             }
         } else {
-- 
2.1.4

  parent reply	other threads:[~2017-01-24 10:14 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24  9:39 [Qemu-devel] [PULL 00/31] Trivial patches for 2017-01-24 Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 01/31] doc: don't mention -memory, it is -m Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 02/31] hw/block/m25p80: Fix typo in local macro name Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 03/31] README: Add linux to macOS build info Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 04/31] Fix documentation and some comments (article, grammar) Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 05/31] include: Fix typos found by codespell Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 06/31] hw: " Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 07/31] qemu-options: cleanup duplicated help message for kernel_irqchip Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 08/31] usb: Fix typo in documentation Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 09/31] object.h: spelling fix Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 10/31] object: make some funcs static Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 11/31] pcie: fix typo in comments Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 12/31] qemu-img: remove dead check Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 13/31] pci-assign: avoid pointless stat Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 14/31] block: remove dead check Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 15/31] qga: fix erroneous argument to strerror Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 16/31] doc/usb2: fix typo Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 17/31] hw/i386/kvmvapic: Remove dead code in patch_hypercalls() Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 18/31] lm32: milkymist-tmu2: fix another integer overflow Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 19/31] disas/cris.c: Fix Coverity warning about unchecked NULL Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 20/31] docs: sync pci-ids.txt Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 21/31] vfio: remove a duplicated word in comments Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 22/31] util/mmap-alloc: check parameter before using Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 23/31] util/mmap-alloc: refactor a little bit for readability Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 24/31] win32: use glib gpoll if glib >= 2.50 Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 25/31] hw/display/framebuffer.c: Avoid overflow for framebuffers > 4GB Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 26/31] Drop duplicate display option documentation Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 27/31] scsi-disk: add 'fall through' comment to switch VERIFY cases Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 28/31] gdbstub.c: fix GDB connection segfault caused by empty machines Michael Tokarev
2017-01-24  9:39 ` Michael Tokarev [this message]
2017-01-24  9:39 ` [Qemu-devel] [PULL 30/31] usb: Set category and description of the MTP device Michael Tokarev
2017-01-24  9:39 ` [Qemu-devel] [PULL 31/31] hw/isa/isa-bus: Set category of the "isabus-bridge" device Michael Tokarev
2017-01-24 13:20 ` [Qemu-devel] [PULL 00/31] Trivial patches for 2017-01-24 no-reply
2017-01-24 16:55 ` Peter Maydell
2017-01-24 16:56   ` Peter Maydell
2017-01-24 17:26 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a5bfc35921a1060c5596e7cd0dfda6a30093d49.1485250702.git.mjt@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=skiver.cloud.yzy@gmail.com \
    --cc=yzylivezh@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.