From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v4 5/6] ethdev: remove deprecated
 attach/detach functions
Date: Tue, 16 Oct 2018 12:03:23 +0100
Message-ID: <9a6e10d4-be5e-5da6-c34f-aa3d4e2ed288@intel.com>
References: <20181007222554.4886-1-thomas@monjalon.net>
 <20181009223338.18307-1-thomas@monjalon.net>
 <20181009223338.18307-6-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: gaetan.rivet@6wind.com, ophirmu@mellanox.com, arybchenko@solarflare.com
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id BB0A14D27
 for <dev@dpdk.org>; Tue, 16 Oct 2018 13:03:26 +0200 (CEST)
In-Reply-To: <20181009223338.18307-6-thomas@monjalon.net>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/9/2018 11:33 PM, Thomas Monjalon wrote:
> The hotplug attach/detach features are implemented in EAL layer.
> There is a new ethdev iterator to retrieve ports from ethdev layer.
> 
> As announced earlier, the (buggy) ethdev functions are now removed.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>

<...>

> @@ -53,7 +53,6 @@ Programmer's Guide
>      packet_framework
>      vhost_lib
>      metrics_lib
> -    port_hotplug_framework

Any replacement documentation for hotplug?

<...>

> @@ -130,6 +130,12 @@ API Changes
>    functions were deprecated since 17.05 and are replaced by
>    ``rte_mbuf_raw_free()`` and ``rte_pktmbuf_prefree_seg()``.
>  
> +* ethdev: The deprecated functions attach/detach were removed in 18.11.
> +  ``rte_eth_dev_attach`` can be replaced by ``RTE_ETH_FOREACH_MATCHING_DEV``
> +  and ``rte_dev_probe`` or ``rte_eal_hotplug_add``.
> +  ``rte_eth_dev_detach`` can be replaced by
> +  ``rte_dev_remove`` or ``rte_eal_hotplug_remove``.

What is the difference between ``rte_dev_remove`` or ``rte_eal_hotplug_remove``,
which one is good for which usage, is there any documentation explaining this?