From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ranjit Menon Subject: Re: [PATCH v2] meson: fix building subdirectories separately Date: Tue, 5 Mar 2019 10:01:37 -0800 Message-ID: <9a7696ef-1cc9-4ac1-a4e6-ea58db55e742@intel.com> References: <1551803365-79357-1-git-send-email-andrius.sirvys@intel.com> <20190305172111.GA103192@bricha3-MOBL.ger.corp.intel.com> <20190305172623.GB103192@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: dev@dpdk.org Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E78514C9F for ; Tue, 5 Mar 2019 19:01:38 +0100 (CET) In-Reply-To: <20190305172623.GB103192@bricha3-MOBL.ger.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/5/2019 9:26 AM, Bruce Richardson wrote: > On Tue, Mar 05, 2019 at 05:21:12PM +0000, Bruce Richardson wrote: >> On Tue, Mar 05, 2019 at 04:29:25PM +0000, Andrius Sirvys wrote: >>> If for debugging we disable the driver directory in the meson.build file, >>> we get an error because the variable "driver_classes" does not exist. >>> This is because driver_classes is only defined in the >>> drivers/meson.build file. Defining driver_classes in dpdk/meson.build file >>> will make it easier for compiling separate directories. >>> >>> In the process, we rename driver_classes to dpdk_driver_classes for >>> consistency with the other variables. >>> >>> Signed-off-by: Andrius Sirvys >>> --- >>> v2: Fixed mispellings in commit message >>> --- >> This can be useful, and a similar change I saw in the windows RFC since it >> is incrementally adding things to the windows build, and so would hit this >> error. >> >> Therefore, >> Acked-by: Bruce Richardson > > Actually, one small thing I should have picked up on earlier - I think the > title could be reworded a bit. It's not a fix since there is nothing > technically wrong with the existing code - it's just harder to go > commenting out parts of the build without this change. How about setting > the title to: "build: move variable definition to top level", or something > similar. > > /Bruce > Yes. This will help with the Windows port. Acked-by: Ranjit Menon