All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sanjay R Mehta <sanmehta@amd.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Sanjay R Mehta <Sanju.Mehta@amd.com>
Cc: andreas.noever@gmail.com, michael.jamet@intel.com,
	YehezkelShB@gmail.com, Basavaraj.Natikar@amd.com,
	mario.limonciello@amd.com, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 RESEND] thunderbolt: Add DP out resource when DP tunnel is discovered.
Date: Mon, 1 Aug 2022 16:47:56 +0530	[thread overview]
Message-ID: <9a87289d-51f1-6e22-1998-9feba7d4dd29@amd.com> (raw)
In-Reply-To: <Yuely4dKR6Xy5Mdk@lahna>



On 8/1/2022 3:37 PM, Mika Westerberg wrote:
> Hi,
> 
> On Thu, Jul 07, 2022 at 12:31:28PM -0500, Sanjay R Mehta wrote:
>> From: Sanjay R Mehta <sanju.mehta@amd.com>
>>
>> If the boot firmware implements a connection manager of its
>> own it may create a DP tunnel and will be handed off to Linux
>> CM, but the DP out resource is not saved in the dp_resource
>> list.
>>
>> This patch adds tunnelled DP out port to the dp_resource list
>> once the DP tunnel is discovered.
>>
>> Signed-off-by: Sanjay R Mehta <sanju.mehta@amd.com>
>> Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
>>
>> ---
>> v2: Re-ordering the function declaration as per Greg's comment.
>>
>> ---
>>  drivers/thunderbolt/tb.c     | 15 +++++++++++++++
>>  drivers/thunderbolt/tb.h     |  1 +
>>  drivers/thunderbolt/tunnel.c |  2 ++
>>  3 files changed, 18 insertions(+)
>>
>> diff --git a/drivers/thunderbolt/tb.c b/drivers/thunderbolt/tb.c
>> index 9a3214f..dcd0c3e 100644
>> --- a/drivers/thunderbolt/tb.c
>> +++ b/drivers/thunderbolt/tb.c
>> @@ -1006,6 +1006,21 @@ static void tb_dp_resource_unavailable(struct tb *tb, struct tb_port *port)
>>  	tb_tunnel_dp(tb);
>>  }
>>  
>> +void tb_dp_resource_available_discovered(struct tb *tb, struct tb_port *port)
> 
> Please call this tb_discover_dp_resources() make it static and call it
> right after tb_discover_tunnels() in tb_start() or in
> tb_discover_tunnels().
> 
Thanks Mika. Sure, I'll address this & will send you the v3.


> Thanks!

      reply	other threads:[~2022-08-01 11:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07 17:31 [PATCH v2 RESEND] thunderbolt: Add DP out resource when DP tunnel is discovered Sanjay R Mehta
2022-08-01 10:07 ` Mika Westerberg
2022-08-01 11:17   ` Sanjay R Mehta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a87289d-51f1-6e22-1998-9feba7d4dd29@amd.com \
    --to=sanmehta@amd.com \
    --cc=Basavaraj.Natikar@amd.com \
    --cc=Sanju.Mehta@amd.com \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=michael.jamet@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.