From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89C6CC433E0 for ; Mon, 18 May 2020 13:17:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 624C720674 for ; Mon, 18 May 2020 13:17:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="xj1It/WG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726775AbgERNR5 (ORCPT ); Mon, 18 May 2020 09:17:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726855AbgERNR4 (ORCPT ); Mon, 18 May 2020 09:17:56 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41DA3C05BD0A for ; Mon, 18 May 2020 06:17:56 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id k5so3218803lji.11 for ; Mon, 18 May 2020 06:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aaWFz8XM3lber/1QtUDkEYgUS7TEOfr3vPPMOdwLrk4=; b=xj1It/WGw6ho2gXyehxm6yxVpJNgYenYhtlgl5YhWyN5asWO9hvDGHw8rwukxDXrfX dXgMMo0ZAZFQ8mEccZQHf50PdHilbq4KXfNFMbIfNosARIoOPCtmETgBepVHiDoNsjuH A83hapb8pSHGKAN1sMZb8UMxb3PPZOzXEJWGAalWbF/RLzFuG97AwGFScLZAvWV2/z3m E/Vn9Ns9itIfGBr03TxabMBQ53aGb1nWX+LDlRj2KXVhwV6AGa+r/FR+aKeEIn1RKWYn 7KyBPmyJIMzxnGy/lCHE9zMxdtRAgWMjgnpmyJBjZvPKtk4iu86WCuyUFTFHGnO06xBX pVAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aaWFz8XM3lber/1QtUDkEYgUS7TEOfr3vPPMOdwLrk4=; b=aGsZr85nBfYjjjkRvQH5W+/RrbBozMFJvqnZCzJ6uyJb+I84qJJHPLX80MmgFvMqdD KCrzFMc/+Ql6DHBbeuiGiYR5/MYXJCeetT8U1rnnOT3kc3Q+/KnnK2tbQBI2jQd7iqky FkXHyN4QZN9JulD02RC5VuWJ56+8Va1PXsJUFhoGUSEaYYc33v6vsQJKHfRtA4D22OEJ pE71CLeGgjU0m4Q/Tgp9rhaILIujg+OxHOfxX1Z9+Qi0C6m7lbjtSQ6rc2wSjgzoLOQb gyyL1iiGzDHYHKqN9lZfQRIe1xye6wr+hpVKXpi2ix8NCWx5mesbWqZRlKLArG94wIzM KuyQ== X-Gm-Message-State: AOAM532aU3S+CdcrOJFhLWDsmtECtTCpfW9FDiwTo8NxNJwZpufD9p7w TtRTAZBDMl6mn0VvcxnVXpy38g== X-Google-Smtp-Source: ABdhPJw19UGyEwWJ5Mq/Mme9WNx4l0h6pfEFIGaCERwgxusIQHdpFrVvwJLlfLQPp5MqmCtmQRT2Bg== X-Received: by 2002:a2e:9a82:: with SMTP id p2mr10501360lji.279.1589807874514; Mon, 18 May 2020 06:17:54 -0700 (PDT) Received: from ?IPv6:2a00:1fa0:484c:c9e:1c14:285d:1715:e170? ([2a00:1fa0:484c:c9e:1c14:285d:1715:e170]) by smtp.gmail.com with ESMTPSA id v10sm5486890lja.23.2020.05.18.06.17.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2020 06:17:52 -0700 (PDT) Subject: Re: [PATCH 17/17] ARM: dts: r8a7742: Add RWDT node To: "Lad, Prabhakar" , Geert Uytterhoeven Cc: Lad Prabhakar , Jens Axboe , Rob Herring , Wolfram Sang , Ulf Hansson , "David S. Miller" , Wim Van Sebroeck , Guenter Roeck , linux-ide@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux I2C , Linux MMC List , netdev , Linux-Renesas , Linux Watchdog Mailing List References: <1589555337-5498-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> <1589555337-5498-18-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Sergei Shtylyov Message-ID: <9ab946d2-1076-ed92-0a48-9a95d798d291@cogentembedded.com> Date: Mon, 18 May 2020 16:17:46 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Hello! On 18.05.2020 15:27, Lad, Prabhakar wrote: >>> Add a device node for the Watchdog Timer (RWDT) controller on the Renesas >>> RZ/G1H (r8a7742) SoC. >>> >>> Signed-off-by: Lad Prabhakar >>> Reviewed-by: Marian-Cristian Rotariu >> >> Thanks for your patch! >> >>> --- a/arch/arm/boot/dts/r8a7742.dtsi >>> +++ b/arch/arm/boot/dts/r8a7742.dtsi >>> @@ -201,6 +201,16 @@ >>> #size-cells = <2>; >>> ranges; >>> >>> + rwdt: watchdog@e6020000 { >>> + compatible = "renesas,r8a7742-wdt", >>> + "renesas,rcar-gen2-wdt"; >>> + reg = <0 0xe6020000 0 0x0c>; >>> + clocks = <&cpg CPG_MOD 402>; >>> + power-domains = <&sysc R8A7742_PD_ALWAYS_ON>; >>> + resets = <&cpg 402>; >>> + status = "disabled"; >> >> Missing "interrupts" property. >> > "interrupts" property isn't used by rwdt driver and can be dropped > from bindings file. DT describes the hardware, not its driver's abilities. > Cheers, > --Prabhakar MBR, Sergei