From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17041C433EF for ; Wed, 4 May 2022 19:31:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9802383EEF; Wed, 4 May 2022 21:31:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="Ktqx2ZvO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D40C183EEF; Wed, 4 May 2022 21:31:52 +0200 (CEST) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 162A483F11 for ; Wed, 4 May 2022 21:31:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ariel.dalessandro@collabora.com Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: adalessandro) with ESMTPSA id 6E3971F414DF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1651692709; bh=1nEEYhBwV3UpVEBd52XzHOLvF/dGfsD/k3CzdW4byVc=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=Ktqx2ZvO//gFq7LcAFGM2sypWcJ0Tbd88FARfXjhF6VMVI2I9Z6F3yCzLtqDuBPuZ 2k06+XCaSMz/A0GbR5wgPxhuZ3awcuZYxvIrtwNtrTQz9aoZj5OJRI6L4RUxi355r4 7D2fh/TANLyqOAjwHnuNpOOMoIHWt7+G+txeb7N6Zdg8LLrw7Lx4OM13B864Kwww3y kSCIQfibUr0T5owcn7K6N6kqNp0jlrTXdNNhPuzoX3cIkNQ12qMGx//oumO4xzf4kd 310hrsQq4QeyQoBK2DYzSRNKVTduBjUvr3+Rwpyrmv/VvKxEpY1tFhlNRF8jNghLkF FQ8TDnxUb9lSA== Message-ID: <9abf2307-a1c5-ff87-b7aa-30503655db56@collabora.com> Date: Wed, 4 May 2022 16:31:43 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH 2/4] configs: imx8m: use common imx8m.h for i.MX8MN Content-Language: en-US From: Ariel D'Alessandro To: Tim Harvey , "Peng Fan (OSS)" Cc: Stefano Babic , Fabio Estevam , Michael Trimarchi , Peng Fan , u-boot References: <20220503122113.26780-1-peng.fan@oss.nxp.com> <20220503122113.26780-2-peng.fan@oss.nxp.com> <18ab7f27-32e4-be8b-aaac-d685c176da45@collabora.com> In-Reply-To: <18ab7f27-32e4-be8b-aaac-d685c176da45@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Peng, On 5/4/22 16:30, Ariel D'Alessandro wrote: > Hi Peng, > > On 5/3/22 12:43, Tim Harvey wrote: >> On Tue, May 3, 2022 at 4:39 AM Peng Fan (OSS) wrote: >>> >>> From: Peng Fan >>> >>> Some SPL definitions could be gerneralized, so use imx8m.h for iMX8MN. >>> >> >> Peng, >> >> s/gerneralized/generalized >> >> (looks like that typo is all the patches in your series) >> >> Great cleanup - thanks! This is a great start to getting rid of the >> remaining items in the config headers. >> >> If you do end up doing a 2nd version you can probably remove the >> comments on the sizes, for example 'SZ_8K /* 8 KB */'' as I think the >> comment is not needed. >> >> Works great for imx8mn-venice-*. >> >> Tested-by: Tim Harvey #imx8mm-venice-* > > Thanks a lot for the cleanup! I agree with Tim's comments, would be > worth removing those redundant sizes comments. > > Tested on i.MX8MN BSH SMM S2 PRO board. > Tested-by: Ariel D'Alessandro Tested on i.MX8MN Variscite Symphony board Tested-by: Ariel D'Alessandro > >> >>> Signed-off-by: Peng Fan >>> --- >>> include/configs/imx8m.h | 10 ++++++++++ >>> include/configs/imx8mn_bsh_smm_s2_common.h | 17 +---------------- >>> include/configs/imx8mn_evk.h | 20 +------------------- >>> include/configs/imx8mn_var_som.h | 15 +-------------- >>> include/configs/imx8mn_venice.h | 18 +----------------- >>> 5 files changed, 14 insertions(+), 66 deletions(-) > > [snip]