From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kuehling, Felix" Subject: Re: [PATCH v3] drm/amdgpu: user pages array memory leak fix Date: Fri, 11 Oct 2019 17:33:38 +0000 Message-ID: <9abf4c92-a30c-ae3d-5544-6428c3aec2ce@amd.com> References: <20191011143620.8785-1-Philip.Yang@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191011143620.8785-1-Philip.Yang-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US Content-ID: List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Yang, Philip" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "Koenig, Christian" , "thejoe-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" T24gMjAxOS0xMC0xMSAxMDozNiBhLm0uLCBZYW5nLCBQaGlsaXAgd3JvdGU6DQo+IHVzZXJfcGFn ZXMgYXJyYXkgc2hvdWxkIGFsd2F5cyBiZSBmcmVlZCBhZnRlciB2YWxpZGF0aW9uIHJlZ2FyZGxl c3MgaWYNCj4gdXNlciBwYWdlcyBhcmUgY2hhbmdlZCBhZnRlciBibyBpcyBjcmVhdGVkIGJlY2F1 c2Ugd2l0aCBITU0gY2hhbmdlIHBhcnNlDQo+IGJvIGFsd2F5cyBhbGxvY2F0ZSB1c2VyIHBhZ2Vz IGFycmF5IHRvIGdldCB1c2VyIHBhZ2VzIGZvciB1c2VycHRyIGJvLg0KPg0KPiB2MjogcmVtb3Zl IHVudXNlZCBsb2NhbCB2YXJpYWJsZSBhbmQgYW1lbmQgY29tbWl0DQo+DQo+IHYzOiBhZGQgYmFj ayBnZXQgdXNlciBwYWdlcyBpbiBnZW1fdXNlcnB0cl9pb2N0bCwgdG8gZGV0ZWN0IGFwcGxpY2F0 aW9uDQo+IGJ1ZyB3aGVyZSBhbiB1c2VycHRyIFZNQSBpcyBub3QgYW5hbnltb3VzIG1lbW9yeSBh bmQgcmVqZWN0IGl0Lg0KPg0KPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmxhdW5jaHBhZC5uZXQv dWJ1bnR1Lytzb3VyY2UvbGludXgvK2J1Zy8xODQ0OTYyDQo+DQo+IFNpZ25lZC1vZmYtYnk6IFBo aWxpcCBZYW5nIDxQaGlsaXAuWWFuZ0BhbWQuY29tPg0KPiBUZXN0ZWQtYnk6IEpvZSBCYXJuZXR0 IDx0aGVqb2VAZ21haWwuY29tPg0KPiBSZXZpZXdlZC1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hy aXN0aWFuLmtvZW5pZ0BhbWQuY29tPg0KPiAtLS0NCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9hbWRncHVfY3MuYyB8IDQgKy0tLQ0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlv bigrKSwgMyBkZWxldGlvbnMoLSkNCj4NCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdV9jcy5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X2NzLmMNCj4gaW5kZXggYzE4YTE1M2IzZDJhLi5lN2IzOWRhYTIyZjYgMTAwNjQ0DQo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9jcy5jDQo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9jcy5jDQo+IEBAIC00NzYsNyArNDc2LDYgQEAgc3Rh dGljIGludCBhbWRncHVfY3NfbGlzdF92YWxpZGF0ZShzdHJ1Y3QgYW1kZ3B1X2NzX3BhcnNlciAq cCwNCj4gICANCj4gICAJbGlzdF9mb3JfZWFjaF9lbnRyeShsb2JqLCB2YWxpZGF0ZWQsIHR2Lmhl YWQpIHsNCj4gICAJCXN0cnVjdCBhbWRncHVfYm8gKmJvID0gdHRtX3RvX2FtZGdwdV9ibyhsb2Jq LT50di5ibyk7DQo+IC0JCWJvb2wgYmluZGluZ191c2VycHRyID0gZmFsc2U7DQo+ICAgCQlzdHJ1 Y3QgbW1fc3RydWN0ICp1c2VybW07DQo+ICAgDQo+ICAgCQl1c2VybW0gPSBhbWRncHVfdHRtX3R0 X2dldF91c2VybW0oYm8tPnRiby50dG0pOw0KPiBAQCAtNDkzLDE0ICs0OTIsMTMgQEAgc3RhdGlj IGludCBhbWRncHVfY3NfbGlzdF92YWxpZGF0ZShzdHJ1Y3QgYW1kZ3B1X2NzX3BhcnNlciAqcCwN Cj4gICANCj4gICAJCQlhbWRncHVfdHRtX3R0X3NldF91c2VyX3BhZ2VzKGJvLT50Ym8udHRtLA0K PiAgIAkJCQkJCSAgICAgbG9iai0+dXNlcl9wYWdlcyk7DQo+IC0JCQliaW5kaW5nX3VzZXJwdHIg PSB0cnVlOw0KPiAgIAkJfQ0KPiAgIA0KPiAgIAkJciA9IGFtZGdwdV9jc192YWxpZGF0ZShwLCBi byk7DQo+ICAgCQlpZiAocikNCj4gICAJCQlyZXR1cm4gcjsNCj4gICANCj4gLQkJaWYgKGJpbmRp bmdfdXNlcnB0cikgew0KPiArCQlpZiAobG9iai0+dXNlcl9wYWdlcykgew0KDQpUaGlzIGlmIGlz IG5vdCBuZWVkZWQuIGt2ZnJlZSBzaG91bGQgYmUgYWJsZSB0byBoYW5kbGUgTlVMTCBwb2ludGVy cywgDQphbmQgdW5jb25kaXRpb25hbGx5IHNldHRpbmcgdGhlIHBvaW50ZXIgdG8gTlVMTCBhZnRl cndhcmRzIGlzIG5vdCBhIA0KcHJvYmxlbSBlaXRoZXIuIFdpdGggdGhhdCBmaXhlZCwgdGhpcyBj b21taXQgaXMNCg0KUmV2aWV3ZWQtYnk6IEZlbGl4IEt1ZWhsaW5nIDxGZWxpeC5LdWVobGluZ0Bh bWQuY29tPg0KDQpIb3dldmVyLCBJIGRvbid0IHRoaW5rIHRoaXMgc2hvdWxkIGJlIHRoZSBmaW5h bCBzb2x1dGlvbi4gTXkgY29uY2VybiANCndpdGggdGhpcyBzb2x1dGlvbiBpcywgdGhhdCB5b3Ug ZW5kIHVwIGZyZWVpbmcgYW5kIHJlZ2VuZXJhdGluZyB0aGUgDQp1c2VyX3BhZ2VzIGFycmF5cyBt b3JlIGZyZXF1ZW50bHkgdGhhbiBuZWNlc3Nhcnk6IE9uIGV2ZXJ5IGNvbW1hbmQgDQpzdWJtaXNz aW9uLCBldmVuIGlmIHRoZXJlIHdhcyBubyBNTVUgbm90aWZpZXIgc2luY2UgdGhlIGxhc3QgY29t bWFuZCANCnN1Ym1pc3Npb24uIEkgd2FzIGhvcGluZyB3ZSBjb3VsZCBnZXQgYmFjayB0byBhIHNv bHV0aW9uIHdoZXJlIHdlIGNhbiANCm1haW50YWluIHRoZSBzYW1lIHVzZXJfcGFnZXMgYXJyYXkg YWNyb3NzIGNvbW1hbmQgc3VibWlzc2lvbnMsIHNpbmNlIE1NVSANCm5vdGlmaWVycyBhcmUgcmFy ZS4gVGhhdCBzaG91bGQgcmVkdWNlIG92ZXJoZWFkIGZyb20gZG9pbmcgYWxsIHRob3MgcGFnZSAN CnRhYmxlIHdhbGtzIGluIEhNTSBvbiBldmVyeSBjb21tYW5kIHN1Ym1pc3Npb25zIHdoZW4gdXNp bmcgdXNlcnB0cnMuDQoNClJlZ2FyZHMsDQogwqAgRmVsaXgNCg0KDQo+ICAgCQkJa3ZmcmVlKGxv YmotPnVzZXJfcGFnZXMpOw0KPiAgIAkJCWxvYmotPnVzZXJfcGFnZXMgPSBOVUxMOw0KPiAgIAkJ fQ0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdm eCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4