From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31228C432C0 for ; Mon, 25 Nov 2019 20:47:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 099DF2080F for ; Mon, 25 Nov 2019 20:47:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="Vc2WP6DA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725992AbfKYUrF (ORCPT ); Mon, 25 Nov 2019 15:47:05 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:3447 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725912AbfKYUrF (ORCPT ); Mon, 25 Nov 2019 15:47:05 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 25 Nov 2019 12:47:00 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 25 Nov 2019 12:46:58 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 25 Nov 2019 12:46:58 -0800 Received: from [10.110.48.28] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 25 Nov 2019 20:46:57 +0000 Subject: Re: [PATCH 17/19] powerpc: book3s64: convert to pin_user_pages() and put_user_page() To: Jan Kara CC: Andrew Morton , Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Christoph Hellwig , Dan Williams , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jason Gunthorpe , Jens Axboe , Jonathan Corbet , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Magnus Karlsson , Mauro Carvalho Chehab , Michael Ellerman , Michal Hocko , Mike Kravetz , Paul Mackerras , Shuah Khan , Vlastimil Babka , , , , , , , , , , , , , LKML References: <20191125042011.3002372-1-jhubbard@nvidia.com> <20191125042011.3002372-18-jhubbard@nvidia.com> <20191125085915.GB1797@quack2.suse.cz> From: John Hubbard X-Nvconfidentiality: public Message-ID: <9abfd0bf-ffb9-9fad-848c-caff4a490773@nvidia.com> Date: Mon, 25 Nov 2019 12:46:56 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191125085915.GB1797@quack2.suse.cz> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1574714820; bh=7Gmrre2tneNEWRU9G5+DIn5rrxtRLBtJ55Uj7bfaWRw=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=Vc2WP6DAAbNZStXBl+ln2+kB/EuUuvRZHzMpZNW80Fm3ZctGnvM4O+tZRCgS3669B /qldmeczkVi9pQJMXYF/4i2XGVt4Gm+gOJ/tFv/RnDb4dopV+tz5b0cyQc9YOTVtBS P/yYNUzd4pjDhuvvDyZmybC/J7abTjT/ntYJJMbyGr8NCKnGXhEtDqS5T7TKRE2hwU dbPgyN9eu9VXPtG/lD5Uk37zf69kjzXTl/JkUlunTht14kOdHqRRRORI90fFcZ/kGC NFhCuK40TfQ4yRLkmLaKp7qlIx6xeGOy5CzKXKx/3W33foWMDjA/xuDpoO/15JsFQy 0FiT0Aycu6K+g== Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 11/25/19 12:59 AM, Jan Kara wrote: > On Sun 24-11-19 20:20:09, John Hubbard wrote: >> 1. Convert from get_user_pages() to pin_user_pages(). >> >> 2. As required by pin_user_pages(), release these pages via >> put_user_page(). In this case, do so via put_user_pages_dirty_lock(). >> >> That has the side effect of calling set_page_dirty_lock(), instead >> of set_page_dirty(). This is probably more accurate. >> >> As Christoph Hellwig put it, "set_page_dirty() is only safe if we are >> dealing with a file backed page where we have reference on the inode it >> hangs off." [1] >> >> 3. Release each page in mem->hpages[] (instead of mem->hpas[]), because >> that is the array that pin_longterm_pages() filled in. This is more >> accurate and should be a little safer from a maintenance point of >> view. > > Except that this breaks the code. hpages is unioned with hpas... > OK. >> @@ -212,10 +211,9 @@ static void mm_iommu_unpin(struct mm_iommu_table_group_mem_t *mem) >> if (!page) >> continue; >> >> - if (mem->hpas[i] & MM_IOMMU_TABLE_GROUP_PAGE_DIRTY) >> - SetPageDirty(page); >> + put_user_pages_dirty_lock(&mem->hpages[i], 1, >> + MM_IOMMU_TABLE_GROUP_PAGE_DIRTY); > > And the dirtying condition is wrong here as well. Currently it is always > true. > > Honza > Yes. Fixed up locally. The function now looks like this (for this patch, not for the entire series, which renames "put" to "unpin"): static void mm_iommu_unpin(struct mm_iommu_table_group_mem_t *mem) { long i; struct page *page = NULL; if (!mem->hpas) return; for (i = 0; i < mem->entries; ++i) { if (!mem->hpas[i]) continue; page = pfn_to_page(mem->hpas[i] >> PAGE_SHIFT); if (!page) continue; put_user_pages_dirty_lock(&page, 1, mem->hpas[i] & MM_IOMMU_TABLE_GROUP_PAGE_DIRTY); mem->hpas[i] = 0; } } thanks, -- John Hubbard NVIDIA From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 018A0C432C3 for ; Mon, 25 Nov 2019 20:49:26 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C2962075C for ; Mon, 25 Nov 2019 20:49:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="Vc2WP6DA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C2962075C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47MK0270bczDqc8 for ; Tue, 26 Nov 2019 07:49:22 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nvidia.com (client-ip=216.228.121.65; helo=hqemgate16.nvidia.com; envelope-from=jhubbard@nvidia.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=nvidia.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=nvidia.com header.i=@nvidia.com header.b="Vc2WP6DA"; dkim-atps=neutral Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com [216.228.121.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47MJxM1mv2zDqMT for ; Tue, 26 Nov 2019 07:47:02 +1100 (AEDT) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 25 Nov 2019 12:47:00 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 25 Nov 2019 12:46:58 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 25 Nov 2019 12:46:58 -0800 Received: from [10.110.48.28] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 25 Nov 2019 20:46:57 +0000 Subject: Re: [PATCH 17/19] powerpc: book3s64: convert to pin_user_pages() and put_user_page() To: Jan Kara References: <20191125042011.3002372-1-jhubbard@nvidia.com> <20191125042011.3002372-18-jhubbard@nvidia.com> <20191125085915.GB1797@quack2.suse.cz> From: John Hubbard X-Nvconfidentiality: public Message-ID: <9abfd0bf-ffb9-9fad-848c-caff4a490773@nvidia.com> Date: Mon, 25 Nov 2019 12:46:56 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191125085915.GB1797@quack2.suse.cz> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1574714820; bh=7Gmrre2tneNEWRU9G5+DIn5rrxtRLBtJ55Uj7bfaWRw=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=Vc2WP6DAAbNZStXBl+ln2+kB/EuUuvRZHzMpZNW80Fm3ZctGnvM4O+tZRCgS3669B /qldmeczkVi9pQJMXYF/4i2XGVt4Gm+gOJ/tFv/RnDb4dopV+tz5b0cyQc9YOTVtBS P/yYNUzd4pjDhuvvDyZmybC/J7abTjT/ntYJJMbyGr8NCKnGXhEtDqS5T7TKRE2hwU dbPgyN9eu9VXPtG/lD5Uk37zf69kjzXTl/JkUlunTht14kOdHqRRRORI90fFcZ/kGC NFhCuK40TfQ4yRLkmLaKp7qlIx6xeGOy5CzKXKx/3W33foWMDjA/xuDpoO/15JsFQy 0FiT0Aycu6K+g== X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, Alex Williamson , Daniel Vetter , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 11/25/19 12:59 AM, Jan Kara wrote: > On Sun 24-11-19 20:20:09, John Hubbard wrote: >> 1. Convert from get_user_pages() to pin_user_pages(). >> >> 2. As required by pin_user_pages(), release these pages via >> put_user_page(). In this case, do so via put_user_pages_dirty_lock(). >> >> That has the side effect of calling set_page_dirty_lock(), instead >> of set_page_dirty(). This is probably more accurate. >> >> As Christoph Hellwig put it, "set_page_dirty() is only safe if we are >> dealing with a file backed page where we have reference on the inode it >> hangs off." [1] >> >> 3. Release each page in mem->hpages[] (instead of mem->hpas[]), because >> that is the array that pin_longterm_pages() filled in. This is more >> accurate and should be a little safer from a maintenance point of >> view. > > Except that this breaks the code. hpages is unioned with hpas... > OK. >> @@ -212,10 +211,9 @@ static void mm_iommu_unpin(struct mm_iommu_table_group_mem_t *mem) >> if (!page) >> continue; >> >> - if (mem->hpas[i] & MM_IOMMU_TABLE_GROUP_PAGE_DIRTY) >> - SetPageDirty(page); >> + put_user_pages_dirty_lock(&mem->hpages[i], 1, >> + MM_IOMMU_TABLE_GROUP_PAGE_DIRTY); > > And the dirtying condition is wrong here as well. Currently it is always > true. > > Honza > Yes. Fixed up locally. The function now looks like this (for this patch, not for the entire series, which renames "put" to "unpin"): static void mm_iommu_unpin(struct mm_iommu_table_group_mem_t *mem) { long i; struct page *page = NULL; if (!mem->hpas) return; for (i = 0; i < mem->entries; ++i) { if (!mem->hpas[i]) continue; page = pfn_to_page(mem->hpas[i] >> PAGE_SHIFT); if (!page) continue; put_user_pages_dirty_lock(&page, 1, mem->hpas[i] & MM_IOMMU_TABLE_GROUP_PAGE_DIRTY); mem->hpas[i] = 0; } } thanks, -- John Hubbard NVIDIA From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Hubbard Subject: Re: [PATCH 17/19] powerpc: book3s64: convert to pin_user_pages() and put_user_page() Date: Mon, 25 Nov 2019 12:46:56 -0800 Message-ID: <9abfd0bf-ffb9-9fad-848c-caff4a490773@nvidia.com> References: <20191125042011.3002372-1-jhubbard@nvidia.com> <20191125042011.3002372-18-jhubbard@nvidia.com> <20191125085915.GB1797@quack2.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com [216.228.121.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9B0C389C21 for ; Mon, 25 Nov 2019 20:46:58 +0000 (UTC) In-Reply-To: <20191125085915.GB1797@quack2.suse.cz> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jan Kara Cc: Michal Hocko , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kerne List-Id: dri-devel@lists.freedesktop.org T24gMTEvMjUvMTkgMTI6NTkgQU0sIEphbiBLYXJhIHdyb3RlOgo+IE9uIFN1biAyNC0xMS0xOSAy MDoyMDowOSwgSm9obiBIdWJiYXJkIHdyb3RlOgo+PiAxLiBDb252ZXJ0IGZyb20gZ2V0X3VzZXJf cGFnZXMoKSB0byBwaW5fdXNlcl9wYWdlcygpLgo+Pgo+PiAyLiBBcyByZXF1aXJlZCBieSBwaW5f dXNlcl9wYWdlcygpLCByZWxlYXNlIHRoZXNlIHBhZ2VzIHZpYQo+PiBwdXRfdXNlcl9wYWdlKCku IEluIHRoaXMgY2FzZSwgZG8gc28gdmlhIHB1dF91c2VyX3BhZ2VzX2RpcnR5X2xvY2soKS4KPj4K Pj4gVGhhdCBoYXMgdGhlIHNpZGUgZWZmZWN0IG9mIGNhbGxpbmcgc2V0X3BhZ2VfZGlydHlfbG9j aygpLCBpbnN0ZWFkCj4+IG9mIHNldF9wYWdlX2RpcnR5KCkuIFRoaXMgaXMgcHJvYmFibHkgbW9y ZSBhY2N1cmF0ZS4KPj4KPj4gQXMgQ2hyaXN0b3BoIEhlbGx3aWcgcHV0IGl0LCAic2V0X3BhZ2Vf ZGlydHkoKSBpcyBvbmx5IHNhZmUgaWYgd2UgYXJlCj4+IGRlYWxpbmcgd2l0aCBhIGZpbGUgYmFj a2VkIHBhZ2Ugd2hlcmUgd2UgaGF2ZSByZWZlcmVuY2Ugb24gdGhlIGlub2RlIGl0Cj4+IGhhbmdz IG9mZi4iIFsxXQo+Pgo+PiAzLiBSZWxlYXNlIGVhY2ggcGFnZSBpbiBtZW0tPmhwYWdlc1tdIChp bnN0ZWFkIG9mIG1lbS0+aHBhc1tdKSwgYmVjYXVzZQo+PiB0aGF0IGlzIHRoZSBhcnJheSB0aGF0 IHBpbl9sb25ndGVybV9wYWdlcygpIGZpbGxlZCBpbi4gVGhpcyBpcyBtb3JlCj4+IGFjY3VyYXRl IGFuZCBzaG91bGQgYmUgYSBsaXR0bGUgc2FmZXIgZnJvbSBhIG1haW50ZW5hbmNlIHBvaW50IG9m Cj4+IHZpZXcuCj4gCj4gRXhjZXB0IHRoYXQgdGhpcyBicmVha3MgdGhlIGNvZGUuIGhwYWdlcyBp cyB1bmlvbmVkIHdpdGggaHBhcy4uLgo+IAoKT0suIAoKPj4gQEAgLTIxMiwxMCArMjExLDkgQEAg c3RhdGljIHZvaWQgbW1faW9tbXVfdW5waW4oc3RydWN0IG1tX2lvbW11X3RhYmxlX2dyb3VwX21l bV90ICptZW0pCj4+ICAJCWlmICghcGFnZSkKPj4gIAkJCWNvbnRpbnVlOwo+PiAgCj4+IC0JCWlm IChtZW0tPmhwYXNbaV0gJiBNTV9JT01NVV9UQUJMRV9HUk9VUF9QQUdFX0RJUlRZKQo+PiAtCQkJ U2V0UGFnZURpcnR5KHBhZ2UpOwo+PiArCQlwdXRfdXNlcl9wYWdlc19kaXJ0eV9sb2NrKCZtZW0t PmhwYWdlc1tpXSwgMSwKPj4gKwkJCQkJICBNTV9JT01NVV9UQUJMRV9HUk9VUF9QQUdFX0RJUlRZ KTsKPiAKPiBBbmQgdGhlIGRpcnR5aW5nIGNvbmRpdGlvbiBpcyB3cm9uZyBoZXJlIGFzIHdlbGwu IEN1cnJlbnRseSBpdCBpcyBhbHdheXMKPiB0cnVlLgo+IAo+IAkJCQkJCQkJSG9uemEKPiAKClll cy4gRml4ZWQgdXAgbG9jYWxseS4gVGhlIGZ1bmN0aW9uIG5vdyBsb29rcyBsaWtlIHRoaXMgKGZv ciB0aGlzIHBhdGNoLCBub3QgZm9yCnRoZSBlbnRpcmUgc2VyaWVzLCB3aGljaCByZW5hbWVzICJw dXQiIHRvICJ1bnBpbiIpOgoKCnN0YXRpYyB2b2lkIG1tX2lvbW11X3VucGluKHN0cnVjdCBtbV9p b21tdV90YWJsZV9ncm91cF9tZW1fdCAqbWVtKQp7Cglsb25nIGk7CglzdHJ1Y3QgcGFnZSAqcGFn ZSA9IE5VTEw7CgoJaWYgKCFtZW0tPmhwYXMpCgkJcmV0dXJuOwoKCWZvciAoaSA9IDA7IGkgPCBt ZW0tPmVudHJpZXM7ICsraSkgewoJCWlmICghbWVtLT5ocGFzW2ldKQoJCQljb250aW51ZTsKCgkJ cGFnZSA9IHBmbl90b19wYWdlKG1lbS0+aHBhc1tpXSA+PiBQQUdFX1NISUZUKTsKCQlpZiAoIXBh Z2UpCgkJCWNvbnRpbnVlOwoKCQlwdXRfdXNlcl9wYWdlc19kaXJ0eV9sb2NrKCZwYWdlLCAxLAoJ CQkJbWVtLT5ocGFzW2ldICYgTU1fSU9NTVVfVEFCTEVfR1JPVVBfUEFHRV9ESVJUWSk7CgoJCW1l bS0+aHBhc1tpXSA9IDA7Cgl9Cn0KCnRoYW5rcywKLS0gCkpvaG4gSHViYmFyZApOVklESUEKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2C35C432C3 for ; Mon, 25 Nov 2019 20:47:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FDD120835 for ; Mon, 25 Nov 2019 20:47:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FDD120835 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A19716E059; Mon, 25 Nov 2019 20:47:00 +0000 (UTC) Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com [216.228.121.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9B0C389C21 for ; Mon, 25 Nov 2019 20:46:58 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 25 Nov 2019 12:47:00 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 25 Nov 2019 12:46:58 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 25 Nov 2019 12:46:58 -0800 Received: from [10.110.48.28] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 25 Nov 2019 20:46:57 +0000 Subject: Re: [PATCH 17/19] powerpc: book3s64: convert to pin_user_pages() and put_user_page() To: Jan Kara References: <20191125042011.3002372-1-jhubbard@nvidia.com> <20191125042011.3002372-18-jhubbard@nvidia.com> <20191125085915.GB1797@quack2.suse.cz> From: John Hubbard X-Nvconfidentiality: public Message-ID: <9abfd0bf-ffb9-9fad-848c-caff4a490773@nvidia.com> Date: Mon, 25 Nov 2019 12:46:56 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191125085915.GB1797@quack2.suse.cz> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-US X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1574714820; bh=7Gmrre2tneNEWRU9G5+DIn5rrxtRLBtJ55Uj7bfaWRw=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=Vc2WP6DAAbNZStXBl+ln2+kB/EuUuvRZHzMpZNW80Fm3ZctGnvM4O+tZRCgS3669B /qldmeczkVi9pQJMXYF/4i2XGVt4Gm+gOJ/tFv/RnDb4dopV+tz5b0cyQc9YOTVtBS P/yYNUzd4pjDhuvvDyZmybC/J7abTjT/ntYJJMbyGr8NCKnGXhEtDqS5T7TKRE2hwU dbPgyN9eu9VXPtG/lD5Uk37zf69kjzXTl/JkUlunTht14kOdHqRRRORI90fFcZ/kGC NFhCuK40TfQ4yRLkmLaKp7qlIx6xeGOy5CzKXKx/3W33foWMDjA/xuDpoO/15JsFQy 0FiT0Aycu6K+g== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, Alex Williamson , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , Mike Kravetz Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191125204656.mYFgPcHiHIaC2mE2XEuXT8zdjvq0C1YLo2K1tm0GnzI@z> T24gMTEvMjUvMTkgMTI6NTkgQU0sIEphbiBLYXJhIHdyb3RlOgo+IE9uIFN1biAyNC0xMS0xOSAy MDoyMDowOSwgSm9obiBIdWJiYXJkIHdyb3RlOgo+PiAxLiBDb252ZXJ0IGZyb20gZ2V0X3VzZXJf cGFnZXMoKSB0byBwaW5fdXNlcl9wYWdlcygpLgo+Pgo+PiAyLiBBcyByZXF1aXJlZCBieSBwaW5f dXNlcl9wYWdlcygpLCByZWxlYXNlIHRoZXNlIHBhZ2VzIHZpYQo+PiBwdXRfdXNlcl9wYWdlKCku IEluIHRoaXMgY2FzZSwgZG8gc28gdmlhIHB1dF91c2VyX3BhZ2VzX2RpcnR5X2xvY2soKS4KPj4K Pj4gVGhhdCBoYXMgdGhlIHNpZGUgZWZmZWN0IG9mIGNhbGxpbmcgc2V0X3BhZ2VfZGlydHlfbG9j aygpLCBpbnN0ZWFkCj4+IG9mIHNldF9wYWdlX2RpcnR5KCkuIFRoaXMgaXMgcHJvYmFibHkgbW9y ZSBhY2N1cmF0ZS4KPj4KPj4gQXMgQ2hyaXN0b3BoIEhlbGx3aWcgcHV0IGl0LCAic2V0X3BhZ2Vf ZGlydHkoKSBpcyBvbmx5IHNhZmUgaWYgd2UgYXJlCj4+IGRlYWxpbmcgd2l0aCBhIGZpbGUgYmFj a2VkIHBhZ2Ugd2hlcmUgd2UgaGF2ZSByZWZlcmVuY2Ugb24gdGhlIGlub2RlIGl0Cj4+IGhhbmdz IG9mZi4iIFsxXQo+Pgo+PiAzLiBSZWxlYXNlIGVhY2ggcGFnZSBpbiBtZW0tPmhwYWdlc1tdIChp bnN0ZWFkIG9mIG1lbS0+aHBhc1tdKSwgYmVjYXVzZQo+PiB0aGF0IGlzIHRoZSBhcnJheSB0aGF0 IHBpbl9sb25ndGVybV9wYWdlcygpIGZpbGxlZCBpbi4gVGhpcyBpcyBtb3JlCj4+IGFjY3VyYXRl IGFuZCBzaG91bGQgYmUgYSBsaXR0bGUgc2FmZXIgZnJvbSBhIG1haW50ZW5hbmNlIHBvaW50IG9m Cj4+IHZpZXcuCj4gCj4gRXhjZXB0IHRoYXQgdGhpcyBicmVha3MgdGhlIGNvZGUuIGhwYWdlcyBp cyB1bmlvbmVkIHdpdGggaHBhcy4uLgo+IAoKT0suIAoKPj4gQEAgLTIxMiwxMCArMjExLDkgQEAg c3RhdGljIHZvaWQgbW1faW9tbXVfdW5waW4oc3RydWN0IG1tX2lvbW11X3RhYmxlX2dyb3VwX21l bV90ICptZW0pCj4+ICAJCWlmICghcGFnZSkKPj4gIAkJCWNvbnRpbnVlOwo+PiAgCj4+IC0JCWlm IChtZW0tPmhwYXNbaV0gJiBNTV9JT01NVV9UQUJMRV9HUk9VUF9QQUdFX0RJUlRZKQo+PiAtCQkJ U2V0UGFnZURpcnR5KHBhZ2UpOwo+PiArCQlwdXRfdXNlcl9wYWdlc19kaXJ0eV9sb2NrKCZtZW0t PmhwYWdlc1tpXSwgMSwKPj4gKwkJCQkJICBNTV9JT01NVV9UQUJMRV9HUk9VUF9QQUdFX0RJUlRZ KTsKPiAKPiBBbmQgdGhlIGRpcnR5aW5nIGNvbmRpdGlvbiBpcyB3cm9uZyBoZXJlIGFzIHdlbGwu IEN1cnJlbnRseSBpdCBpcyBhbHdheXMKPiB0cnVlLgo+IAo+IAkJCQkJCQkJSG9uemEKPiAKClll cy4gRml4ZWQgdXAgbG9jYWxseS4gVGhlIGZ1bmN0aW9uIG5vdyBsb29rcyBsaWtlIHRoaXMgKGZv ciB0aGlzIHBhdGNoLCBub3QgZm9yCnRoZSBlbnRpcmUgc2VyaWVzLCB3aGljaCByZW5hbWVzICJw dXQiIHRvICJ1bnBpbiIpOgoKCnN0YXRpYyB2b2lkIG1tX2lvbW11X3VucGluKHN0cnVjdCBtbV9p b21tdV90YWJsZV9ncm91cF9tZW1fdCAqbWVtKQp7Cglsb25nIGk7CglzdHJ1Y3QgcGFnZSAqcGFn ZSA9IE5VTEw7CgoJaWYgKCFtZW0tPmhwYXMpCgkJcmV0dXJuOwoKCWZvciAoaSA9IDA7IGkgPCBt ZW0tPmVudHJpZXM7ICsraSkgewoJCWlmICghbWVtLT5ocGFzW2ldKQoJCQljb250aW51ZTsKCgkJ cGFnZSA9IHBmbl90b19wYWdlKG1lbS0+aHBhc1tpXSA+PiBQQUdFX1NISUZUKTsKCQlpZiAoIXBh Z2UpCgkJCWNvbnRpbnVlOwoKCQlwdXRfdXNlcl9wYWdlc19kaXJ0eV9sb2NrKCZwYWdlLCAxLAoJ CQkJbWVtLT5ocGFzW2ldICYgTU1fSU9NTVVfVEFCTEVfR1JPVVBfUEFHRV9ESVJUWSk7CgoJCW1l bS0+aHBhc1tpXSA9IDA7Cgl9Cn0KCnRoYW5rcywKLS0gCkpvaG4gSHViYmFyZApOVklESUEKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==