From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49706) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6JAR-0003Fr-JX for qemu-devel@nongnu.org; Fri, 27 May 2016 10:55:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6JAL-00068b-Js for qemu-devel@nongnu.org; Fri, 27 May 2016 10:55:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41955) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6JAL-00068S-De for qemu-devel@nongnu.org; Fri, 27 May 2016 10:55:09 -0400 References: <1459870344-16773-1-git-send-email-alex.bennee@linaro.org> <1459870344-16773-12-git-send-email-alex.bennee@linaro.org> <57485238.1020406@gmail.com> From: Paolo Bonzini Message-ID: <9ac0359b-6c90-4933-ccb9-9f4b6aadf5f9@redhat.com> Date: Fri, 27 May 2016 16:55:02 +0200 MIME-Version: 1.0 In-Reply-To: <57485238.1020406@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 11/11] tcg: enable thread-per-vCPU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Fedorov , =?UTF-8?Q?Alex_Benn=c3=a9e?= , mttcg@greensocs.com, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, cota@braap.org Cc: qemu-devel@nongnu.org, mark.burton@greensocs.com, jan.kiszka@siemens.com, rth@twiddle.net, peter.maydell@linaro.org, claudio.fontana@huawei.com, Peter Crosthwaite On 27/05/2016 15:57, Sergey Fedorov wrote: > 1. Make 'cpu->thread_kicked' access atomic > 2. Remove global 'exit_request' and use per-CPU 'exit_request' > 3. Change how 'current_cpu' is set > 4. Reorganize round-robin CPU TCG thread function > 5. Enable 'mmap_lock' for system mode emulation (do we really want this?) No, I don't think so. > 6. Enable 'tb_lock' for system mode emulation > 7. Introduce per-CPU TCG thread function At least 2/3/7 must be done at the same time, but I agree that this patch could use some splitting. :) Thanks, Paolo