From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753292AbdF2OAo (ORCPT ); Thu, 29 Jun 2017 10:00:44 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:15598 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753229AbdF2OAk (ORCPT ); Thu, 29 Jun 2017 10:00:40 -0400 From: Hugues FRUCHET To: Sakari Ailus CC: Sylwester Nawrocki , "H. Nikolaus Schaller" , Guennadi Liakhovetski , "Rob Herring" , Mark Rutland , "Maxime Coquelin" , Alexandre TORGUE , Mauro Carvalho Chehab , "Hans Verkuil" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-media@vger.kernel.org" , Benjamin Gaignard , Yannick FERTRE Subject: Re: [PATCH v1 4/6] [media] ov9650: use write_array() for resolution sequences Thread-Topic: [PATCH v1 4/6] [media] ov9650: use write_array() for resolution sequences Thread-Index: AQHS7pn1+IW9IANorESAncjB68GFXKI7wR6A Date: Thu, 29 Jun 2017 13:59:31 +0000 Message-ID: <9ac5d920-b29e-afe3-4413-3e147870a103@st.com> References: <1498143942-12682-1-git-send-email-hugues.fruchet@st.com> <1498143942-12682-5-git-send-email-hugues.fruchet@st.com> <20170626163330.GR12407@valkosipuli.retiisi.org.uk> In-Reply-To: <20170626163330.GR12407@valkosipuli.retiisi.org.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.44] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-29_10:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v5TE0lHq024671 On 06/26/2017 06:33 PM, Sakari Ailus wrote: > Hi Hugues, > > On Thu, Jun 22, 2017 at 05:05:40PM +0200, Hugues Fruchet wrote: >> Align resolution sequences on initialization sequence using >> i2c_rv structure NULL terminated .This add flexibility >> on resolution sequence size. >> Document resolution related registers by using corresponding >> define instead of hexa address/value. >> >> Signed-off-by: Hugues Fruchet >> --- >> drivers/media/i2c/ov9650.c | 98 ++++++++++++++++++++++++++++++---------------- >> 1 file changed, 64 insertions(+), 34 deletions(-) >> >> diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c >> index 4311da6..8b283c9 100644 >> --- a/drivers/media/i2c/ov9650.c >> +++ b/drivers/media/i2c/ov9650.c >> @@ -227,11 +227,16 @@ struct ov965x_ctrls { >> u8 update; >> }; >> >> +struct i2c_rv { >> + u8 addr; >> + u8 value; >> +}; >> + >> struct ov965x_framesize { >> u16 width; >> u16 height; >> u16 max_exp_lines; >> - const u8 *regs; >> + const struct i2c_rv *regs; >> }; >> >> struct ov965x_interval { >> @@ -280,9 +285,11 @@ struct ov965x { >> u8 apply_frame_fmt; >> }; >> >> -struct i2c_rv { >> - u8 addr; >> - u8 value; >> +struct ov965x_pixfmt { >> + u32 code; >> + u32 colorspace; >> + /* REG_TSLB value, only bits [3:2] may be set. */ >> + u8 tslb_reg; >> }; >> >> static const struct i2c_rv ov965x_init_regs[] = { >> @@ -342,30 +349,59 @@ struct i2c_rv { >> { REG_NULL, 0 } >> }; >> >> -#define NUM_FMT_REGS 14 >> -/* >> - * COM7, COM3, COM4, HSTART, HSTOP, HREF, VSTART, VSTOP, VREF, >> - * EXHCH, EXHCL, ADC, OCOM, OFON >> - */ >> -static const u8 frame_size_reg_addr[NUM_FMT_REGS] = { >> - 0x12, 0x0c, 0x0d, 0x17, 0x18, 0x32, 0x19, 0x1a, 0x03, >> - 0x2a, 0x2b, 0x37, 0x38, 0x39, >> -}; >> - >> -static const u8 ov965x_sxga_regs[NUM_FMT_REGS] = { >> - 0x00, 0x00, 0x00, 0x1e, 0xbe, 0xbf, 0x01, 0x81, 0x12, >> - 0x10, 0x34, 0x81, 0x93, 0x51, >> +static const struct i2c_rv ov965x_sxga_regs[] = { >> + { REG_COM7, 0x00 }, >> + { REG_COM3, 0x00 }, >> + { REG_COM4, 0x00 }, >> + { REG_HSTART, 0x1e }, >> + { REG_HSTOP, 0xbe }, >> + { 0x32, 0xbf }, >> + { REG_VSTART, 0x01 }, >> + { REG_VSTOP, 0x81 }, >> + { REG_VREF, 0x12 }, >> + { REG_EXHCH, 0x10 }, >> + { REG_EXHCL, 0x34 }, >> + { REG_ADC, 0x81 }, >> + { REG_ACOM, 0x93 }, >> + { REG_OFON, 0x51 }, >> + { REG_NULL, 0 }, >> }; >> >> -static const u8 ov965x_vga_regs[NUM_FMT_REGS] = { >> - 0x40, 0x04, 0x80, 0x26, 0xc6, 0xed, 0x01, 0x3d, 0x00, >> - 0x10, 0x40, 0x91, 0x12, 0x43, >> +static const struct i2c_rv ov965x_vga_regs[] = { >> + { REG_COM7, 0x40 }, >> + { REG_COM3, 0x04 }, >> + { REG_COM4, 0x80 }, >> + { REG_HSTART, 0x26 }, >> + { REG_HSTOP, 0xc6 }, >> + { 0x32, 0xed }, >> + { REG_VSTART, 0x01 }, >> + { REG_VSTOP, 0x3d }, >> + { REG_VREF, 0x00 }, >> + { REG_EXHCH, 0x10 }, >> + { REG_EXHCL, 0x40 }, >> + { REG_ADC, 0x91 }, >> + { REG_ACOM, 0x12 }, >> + { REG_OFON, 0x43 }, >> + { REG_NULL, 0 }, >> }; >> >> /* Determined empirically. */ >> -static const u8 ov965x_qvga_regs[NUM_FMT_REGS] = { >> - 0x10, 0x04, 0x80, 0x25, 0xc5, 0xbf, 0x00, 0x80, 0x12, >> - 0x10, 0x40, 0x91, 0x12, 0x43, >> +static const struct i2c_rv ov965x_qvga_regs[] = { >> + { REG_COM7, 0x10 }, >> + { REG_COM3, 0x04 }, >> + { REG_COM4, 0x80 }, >> + { REG_HSTART, 0x25 }, >> + { REG_HSTOP, 0xc5 }, >> + { 0x32, 0xbf }, >> + { REG_VSTART, 0x00 }, >> + { REG_VSTOP, 0x80 }, >> + { REG_VREF, 0x12 }, >> + { REG_EXHCH, 0x10 }, >> + { REG_EXHCL, 0x40 }, >> + { REG_ADC, 0x91 }, >> + { REG_ACOM, 0x12 }, >> + { REG_OFON, 0x43 }, >> + { REG_NULL, 0 }, >> }; >> >> static const struct ov965x_framesize ov965x_framesizes[] = { >> @@ -387,13 +423,6 @@ struct i2c_rv { >> }, >> }; >> >> -struct ov965x_pixfmt { >> - u32 code; >> - u32 colorspace; >> - /* REG_TSLB value, only bits [3:2] may be set. */ >> - u8 tslb_reg; >> -}; > > Any particular reason for moving struct ov965x_pixfmt definition? Not in the right patch, must be in 5/6 [media] ov9650: add multiple variant support, I'll fix in v2. > >> - >> static const struct ov965x_pixfmt ov965x_formats[] = { >> { MEDIA_BUS_FMT_YUYV8_2X8, V4L2_COLORSPACE_JPEG, 0x00}, >> { MEDIA_BUS_FMT_YVYU8_2X8, V4L2_COLORSPACE_JPEG, 0x04}, >> @@ -1268,11 +1297,12 @@ static int ov965x_set_fmt(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config >> >> static int ov965x_set_frame_size(struct ov965x *ov965x) >> { >> - int i, ret = 0; >> + int ret = 0; >> + >> + v4l2_dbg(1, debug, ov965x->client, "%s\n", __func__); >> >> - for (i = 0; ret == 0 && i < NUM_FMT_REGS; i++) >> - ret = ov965x_write(ov965x->client, frame_size_reg_addr[i], >> - ov965x->frame_size->regs[i]); >> + ret = ov965x_write_array(ov965x->client, >> + ov965x->frame_size->regs); >> return ret; >> } >> > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hugues FRUCHET Subject: Re: [PATCH v1 4/6] [media] ov9650: use write_array() for resolution sequences Date: Thu, 29 Jun 2017 13:59:31 +0000 Message-ID: <9ac5d920-b29e-afe3-4413-3e147870a103@st.com> References: <1498143942-12682-1-git-send-email-hugues.fruchet@st.com> <1498143942-12682-5-git-send-email-hugues.fruchet@st.com> <20170626163330.GR12407@valkosipuli.retiisi.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170626163330.GR12407-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org> Content-Language: en-US Content-ID: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sakari Ailus Cc: Sylwester Nawrocki , "H. Nikolaus Schaller" , Guennadi Liakhovetski , Rob Herring , Mark Rutland , Maxime Coquelin , Alexandre TORGUE , Mauro Carvalho Chehab , Hans Verkuil , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Benjamin Gaignard , Yannick FERTRE List-Id: devicetree@vger.kernel.org DQoNCk9uIDA2LzI2LzIwMTcgMDY6MzMgUE0sIFNha2FyaSBBaWx1cyB3cm90ZToNCj4gSGkgSHVn dWVzLA0KPiANCj4gT24gVGh1LCBKdW4gMjIsIDIwMTcgYXQgMDU6MDU6NDBQTSArMDIwMCwgSHVn dWVzIEZydWNoZXQgd3JvdGU6DQo+PiBBbGlnbiByZXNvbHV0aW9uIHNlcXVlbmNlcyBvbiBpbml0 aWFsaXphdGlvbiBzZXF1ZW5jZSB1c2luZw0KPj4gaTJjX3J2IHN0cnVjdHVyZSBOVUxMIHRlcm1p bmF0ZWQgLlRoaXMgYWRkIGZsZXhpYmlsaXR5DQo+PiBvbiByZXNvbHV0aW9uIHNlcXVlbmNlIHNp emUuDQo+PiBEb2N1bWVudCByZXNvbHV0aW9uIHJlbGF0ZWQgcmVnaXN0ZXJzIGJ5IHVzaW5nIGNv cnJlc3BvbmRpbmcNCj4+IGRlZmluZSBpbnN0ZWFkIG9mIGhleGEgYWRkcmVzcy92YWx1ZS4NCj4+ DQo+PiBTaWduZWQtb2ZmLWJ5OiBIdWd1ZXMgRnJ1Y2hldCA8aHVndWVzLmZydWNoZXRAc3QuY29t Pg0KPj4gLS0tDQo+PiAgIGRyaXZlcnMvbWVkaWEvaTJjL292OTY1MC5jIHwgOTggKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLQ0KPj4gICAxIGZpbGUgY2hhbmdl ZCwgNjQgaW5zZXJ0aW9ucygrKSwgMzQgZGVsZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvbWVkaWEvaTJjL292OTY1MC5jIGIvZHJpdmVycy9tZWRpYS9pMmMvb3Y5NjUwLmMN Cj4+IGluZGV4IDQzMTFkYTYuLjhiMjgzYzkgMTAwNjQ0DQo+PiAtLS0gYS9kcml2ZXJzL21lZGlh L2kyYy9vdjk2NTAuYw0KPj4gKysrIGIvZHJpdmVycy9tZWRpYS9pMmMvb3Y5NjUwLmMNCj4+IEBA IC0yMjcsMTEgKzIyNywxNiBAQCBzdHJ1Y3Qgb3Y5NjV4X2N0cmxzIHsNCj4+ICAgCXU4IHVwZGF0 ZTsNCj4+ICAgfTsNCj4+ICAgDQo+PiArc3RydWN0IGkyY19ydiB7DQo+PiArCXU4IGFkZHI7DQo+ PiArCXU4IHZhbHVlOw0KPj4gK307DQo+PiArDQo+PiAgIHN0cnVjdCBvdjk2NXhfZnJhbWVzaXpl IHsNCj4+ICAgCXUxNiB3aWR0aDsNCj4+ICAgCXUxNiBoZWlnaHQ7DQo+PiAgIAl1MTYgbWF4X2V4 cF9saW5lczsNCj4+IC0JY29uc3QgdTggKnJlZ3M7DQo+PiArCWNvbnN0IHN0cnVjdCBpMmNfcnYg KnJlZ3M7DQo+PiAgIH07DQo+PiAgIA0KPj4gICBzdHJ1Y3Qgb3Y5NjV4X2ludGVydmFsIHsNCj4+ IEBAIC0yODAsOSArMjg1LDExIEBAIHN0cnVjdCBvdjk2NXggew0KPj4gICAJdTggYXBwbHlfZnJh bWVfZm10Ow0KPj4gICB9Ow0KPj4gICANCj4+IC1zdHJ1Y3QgaTJjX3J2IHsNCj4+IC0JdTggYWRk cjsNCj4+IC0JdTggdmFsdWU7DQo+PiArc3RydWN0IG92OTY1eF9waXhmbXQgew0KPj4gKwl1MzIg Y29kZTsNCj4+ICsJdTMyIGNvbG9yc3BhY2U7DQo+PiArCS8qIFJFR19UU0xCIHZhbHVlLCBvbmx5 IGJpdHMgWzM6Ml0gbWF5IGJlIHNldC4gKi8NCj4+ICsJdTggdHNsYl9yZWc7DQo+PiAgIH07DQo+ PiAgIA0KPj4gICBzdGF0aWMgY29uc3Qgc3RydWN0IGkyY19ydiBvdjk2NXhfaW5pdF9yZWdzW10g PSB7DQo+PiBAQCAtMzQyLDMwICszNDksNTkgQEAgc3RydWN0IGkyY19ydiB7DQo+PiAgIAl7IFJF R19OVUxMLCAwIH0NCj4+ICAgfTsNCj4+ICAgDQo+PiAtI2RlZmluZSBOVU1fRk1UX1JFR1MgMTQN Cj4+IC0vKg0KPj4gLSAqIENPTTcsICBDT00zLCAgQ09NNCwgSFNUQVJULCBIU1RPUCwgSFJFRiwg VlNUQVJULCBWU1RPUCwgVlJFRiwNCj4+IC0gKiBFWEhDSCwgRVhIQ0wsIEFEQywgIE9DT00sICAg T0ZPTg0KPj4gLSAqLw0KPj4gLXN0YXRpYyBjb25zdCB1OCBmcmFtZV9zaXplX3JlZ19hZGRyW05V TV9GTVRfUkVHU10gPSB7DQo+PiAtCTB4MTIsIDB4MGMsIDB4MGQsIDB4MTcsIDB4MTgsIDB4MzIs IDB4MTksIDB4MWEsIDB4MDMsDQo+PiAtCTB4MmEsIDB4MmIsIDB4MzcsIDB4MzgsIDB4MzksDQo+ PiAtfTsNCj4+IC0NCj4+IC1zdGF0aWMgY29uc3QgdTggb3Y5NjV4X3N4Z2FfcmVnc1tOVU1fRk1U X1JFR1NdID0gew0KPj4gLQkweDAwLCAweDAwLCAweDAwLCAweDFlLCAweGJlLCAweGJmLCAweDAx LCAweDgxLCAweDEyLA0KPj4gLQkweDEwLCAweDM0LCAweDgxLCAweDkzLCAweDUxLA0KPj4gK3N0 YXRpYyBjb25zdCBzdHJ1Y3QgaTJjX3J2IG92OTY1eF9zeGdhX3JlZ3NbXSA9IHsNCj4+ICsJeyBS RUdfQ09NNywgMHgwMCB9LA0KPj4gKwl7IFJFR19DT00zLCAweDAwIH0sDQo+PiArCXsgUkVHX0NP TTQsIDB4MDAgfSwNCj4+ICsJeyBSRUdfSFNUQVJULCAweDFlIH0sDQo+PiArCXsgUkVHX0hTVE9Q LCAweGJlIH0sDQo+PiArCXsgMHgzMiwgMHhiZiB9LA0KPj4gKwl7IFJFR19WU1RBUlQsIDB4MDEg fSwNCj4+ICsJeyBSRUdfVlNUT1AsIDB4ODEgfSwNCj4+ICsJeyBSRUdfVlJFRiwgMHgxMiB9LA0K Pj4gKwl7IFJFR19FWEhDSCwgMHgxMCB9LA0KPj4gKwl7IFJFR19FWEhDTCwgMHgzNCB9LA0KPj4g Kwl7IFJFR19BREMsIDB4ODEgfSwNCj4+ICsJeyBSRUdfQUNPTSwgMHg5MyB9LA0KPj4gKwl7IFJF R19PRk9OLCAweDUxIH0sDQo+PiArCXsgUkVHX05VTEwsIDAgfSwNCj4+ICAgfTsNCj4+ICAgDQo+ PiAtc3RhdGljIGNvbnN0IHU4IG92OTY1eF92Z2FfcmVnc1tOVU1fRk1UX1JFR1NdID0gew0KPj4g LQkweDQwLCAweDA0LCAweDgwLCAweDI2LCAweGM2LCAweGVkLCAweDAxLCAweDNkLCAweDAwLA0K Pj4gLQkweDEwLCAweDQwLCAweDkxLCAweDEyLCAweDQzLA0KPj4gK3N0YXRpYyBjb25zdCBzdHJ1 Y3QgaTJjX3J2IG92OTY1eF92Z2FfcmVnc1tdID0gew0KPj4gKwl7IFJFR19DT003LCAweDQwIH0s DQo+PiArCXsgUkVHX0NPTTMsIDB4MDQgfSwNCj4+ICsJeyBSRUdfQ09NNCwgMHg4MCB9LA0KPj4g Kwl7IFJFR19IU1RBUlQsIDB4MjYgfSwNCj4+ICsJeyBSRUdfSFNUT1AsIDB4YzYgfSwNCj4+ICsJ eyAweDMyLCAweGVkIH0sDQo+PiArCXsgUkVHX1ZTVEFSVCwgMHgwMSB9LA0KPj4gKwl7IFJFR19W U1RPUCwgMHgzZCB9LA0KPj4gKwl7IFJFR19WUkVGLCAweDAwIH0sDQo+PiArCXsgUkVHX0VYSENI LCAweDEwIH0sDQo+PiArCXsgUkVHX0VYSENMLCAweDQwIH0sDQo+PiArCXsgUkVHX0FEQywgMHg5 MSB9LA0KPj4gKwl7IFJFR19BQ09NLCAweDEyIH0sDQo+PiArCXsgUkVHX09GT04sIDB4NDMgfSwN Cj4+ICsJeyBSRUdfTlVMTCwgMCB9LA0KPj4gICB9Ow0KPj4gICANCj4+ICAgLyogRGV0ZXJtaW5l ZCBlbXBpcmljYWxseS4gKi8NCj4+IC1zdGF0aWMgY29uc3QgdTggb3Y5NjV4X3F2Z2FfcmVnc1tO VU1fRk1UX1JFR1NdID0gew0KPj4gLQkweDEwLCAweDA0LCAweDgwLCAweDI1LCAweGM1LCAweGJm LCAweDAwLCAweDgwLCAweDEyLA0KPj4gLQkweDEwLCAweDQwLCAweDkxLCAweDEyLCAweDQzLA0K Pj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgaTJjX3J2IG92OTY1eF9xdmdhX3JlZ3NbXSA9IHsNCj4+ ICsJeyBSRUdfQ09NNywgMHgxMCB9LA0KPj4gKwl7IFJFR19DT00zLCAweDA0IH0sDQo+PiArCXsg UkVHX0NPTTQsIDB4ODAgfSwNCj4+ICsJeyBSRUdfSFNUQVJULCAweDI1IH0sDQo+PiArCXsgUkVH X0hTVE9QLCAweGM1IH0sDQo+PiArCXsgMHgzMiwgMHhiZiB9LA0KPj4gKwl7IFJFR19WU1RBUlQs IDB4MDAgfSwNCj4+ICsJeyBSRUdfVlNUT1AsIDB4ODAgfSwNCj4+ICsJeyBSRUdfVlJFRiwgMHgx MiB9LA0KPj4gKwl7IFJFR19FWEhDSCwgMHgxMCB9LA0KPj4gKwl7IFJFR19FWEhDTCwgMHg0MCB9 LA0KPj4gKwl7IFJFR19BREMsIDB4OTEgfSwNCj4+ICsJeyBSRUdfQUNPTSwgMHgxMiB9LA0KPj4g Kwl7IFJFR19PRk9OLCAweDQzIH0sDQo+PiArCXsgUkVHX05VTEwsIDAgfSwNCj4+ICAgfTsNCj4+ ICAgDQo+PiAgIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb3Y5NjV4X2ZyYW1lc2l6ZSBvdjk2NXhfZnJh bWVzaXplc1tdID0gew0KPj4gQEAgLTM4NywxMyArNDIzLDYgQEAgc3RydWN0IGkyY19ydiB7DQo+ PiAgIAl9LA0KPj4gICB9Ow0KPj4gICANCj4+IC1zdHJ1Y3Qgb3Y5NjV4X3BpeGZtdCB7DQo+PiAt CXUzMiBjb2RlOw0KPj4gLQl1MzIgY29sb3JzcGFjZTsNCj4+IC0JLyogUkVHX1RTTEIgdmFsdWUs IG9ubHkgYml0cyBbMzoyXSBtYXkgYmUgc2V0LiAqLw0KPj4gLQl1OCB0c2xiX3JlZzsNCj4+IC19 Ow0KPiANCj4gQW55IHBhcnRpY3VsYXIgcmVhc29uIGZvciBtb3Zpbmcgc3RydWN0IG92OTY1eF9w aXhmbXQgZGVmaW5pdGlvbj8NCg0KTm90IGluIHRoZSByaWdodCBwYXRjaCwgbXVzdCBiZSBpbiA1 LzYgW21lZGlhXSBvdjk2NTA6IGFkZCBtdWx0aXBsZSANCnZhcmlhbnQgc3VwcG9ydCwgSSdsbCBm aXggaW4gdjIuDQoNCj4gDQo+PiAtDQo+PiAgIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb3Y5NjV4X3Bp eGZtdCBvdjk2NXhfZm9ybWF0c1tdID0gew0KPj4gICAJeyBNRURJQV9CVVNfRk1UX1lVWVY4XzJY OCwgVjRMMl9DT0xPUlNQQUNFX0pQRUcsIDB4MDB9LA0KPj4gICAJeyBNRURJQV9CVVNfRk1UX1lW WVU4XzJYOCwgVjRMMl9DT0xPUlNQQUNFX0pQRUcsIDB4MDR9LA0KPj4gQEAgLTEyNjgsMTEgKzEy OTcsMTIgQEAgc3RhdGljIGludCBvdjk2NXhfc2V0X2ZtdChzdHJ1Y3QgdjRsMl9zdWJkZXYgKnNk LCBzdHJ1Y3QgdjRsMl9zdWJkZXZfcGFkX2NvbmZpZw0KPj4gICANCj4+ICAgc3RhdGljIGludCBv djk2NXhfc2V0X2ZyYW1lX3NpemUoc3RydWN0IG92OTY1eCAqb3Y5NjV4KQ0KPj4gICB7DQo+PiAt CWludCBpLCByZXQgPSAwOw0KPj4gKwlpbnQgcmV0ID0gMDsNCj4+ICsNCj4+ICsJdjRsMl9kYmco MSwgZGVidWcsIG92OTY1eC0+Y2xpZW50LCAiJXNcbiIsIF9fZnVuY19fKTsNCj4+ICAgDQo+PiAt CWZvciAoaSA9IDA7IHJldCA9PSAwICYmIGkgPCBOVU1fRk1UX1JFR1M7IGkrKykNCj4+IC0JCXJl dCA9IG92OTY1eF93cml0ZShvdjk2NXgtPmNsaWVudCwgZnJhbWVfc2l6ZV9yZWdfYWRkcltpXSwN Cj4+IC0JCQkJICAgb3Y5NjV4LT5mcmFtZV9zaXplLT5yZWdzW2ldKTsNCj4+ICsJcmV0ID0gb3Y5 NjV4X3dyaXRlX2FycmF5KG92OTY1eC0+Y2xpZW50LA0KPj4gKwkJCQkgb3Y5NjV4LT5mcmFtZV9z aXplLT5yZWdzKTsNCj4+ICAgCXJldHVybiByZXQ7DQo+PiAgIH0NCj4+ICAgDQo+IA== -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx07-00178001.pphosted.com ([62.209.51.94]:15598 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753229AbdF2OAk (ORCPT ); Thu, 29 Jun 2017 10:00:40 -0400 From: Hugues FRUCHET To: Sakari Ailus CC: Sylwester Nawrocki , "H. Nikolaus Schaller" , Guennadi Liakhovetski , "Rob Herring" , Mark Rutland , "Maxime Coquelin" , Alexandre TORGUE , Mauro Carvalho Chehab , "Hans Verkuil" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-media@vger.kernel.org" , Benjamin Gaignard , Yannick FERTRE Subject: Re: [PATCH v1 4/6] [media] ov9650: use write_array() for resolution sequences Date: Thu, 29 Jun 2017 13:59:31 +0000 Message-ID: <9ac5d920-b29e-afe3-4413-3e147870a103@st.com> References: <1498143942-12682-1-git-send-email-hugues.fruchet@st.com> <1498143942-12682-5-git-send-email-hugues.fruchet@st.com> <20170626163330.GR12407@valkosipuli.retiisi.org.uk> In-Reply-To: <20170626163330.GR12407@valkosipuli.retiisi.org.uk> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org List-ID: DQoNCk9uIDA2LzI2LzIwMTcgMDY6MzMgUE0sIFNha2FyaSBBaWx1cyB3cm90ZToNCj4gSGkgSHVn dWVzLA0KPiANCj4gT24gVGh1LCBKdW4gMjIsIDIwMTcgYXQgMDU6MDU6NDBQTSArMDIwMCwgSHVn dWVzIEZydWNoZXQgd3JvdGU6DQo+PiBBbGlnbiByZXNvbHV0aW9uIHNlcXVlbmNlcyBvbiBpbml0 aWFsaXphdGlvbiBzZXF1ZW5jZSB1c2luZw0KPj4gaTJjX3J2IHN0cnVjdHVyZSBOVUxMIHRlcm1p bmF0ZWQgLlRoaXMgYWRkIGZsZXhpYmlsaXR5DQo+PiBvbiByZXNvbHV0aW9uIHNlcXVlbmNlIHNp emUuDQo+PiBEb2N1bWVudCByZXNvbHV0aW9uIHJlbGF0ZWQgcmVnaXN0ZXJzIGJ5IHVzaW5nIGNv cnJlc3BvbmRpbmcNCj4+IGRlZmluZSBpbnN0ZWFkIG9mIGhleGEgYWRkcmVzcy92YWx1ZS4NCj4+ DQo+PiBTaWduZWQtb2ZmLWJ5OiBIdWd1ZXMgRnJ1Y2hldCA8aHVndWVzLmZydWNoZXRAc3QuY29t Pg0KPj4gLS0tDQo+PiAgIGRyaXZlcnMvbWVkaWEvaTJjL292OTY1MC5jIHwgOTggKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLQ0KPj4gICAxIGZpbGUgY2hhbmdl ZCwgNjQgaW5zZXJ0aW9ucygrKSwgMzQgZGVsZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvbWVkaWEvaTJjL292OTY1MC5jIGIvZHJpdmVycy9tZWRpYS9pMmMvb3Y5NjUwLmMN Cj4+IGluZGV4IDQzMTFkYTYuLjhiMjgzYzkgMTAwNjQ0DQo+PiAtLS0gYS9kcml2ZXJzL21lZGlh L2kyYy9vdjk2NTAuYw0KPj4gKysrIGIvZHJpdmVycy9tZWRpYS9pMmMvb3Y5NjUwLmMNCj4+IEBA IC0yMjcsMTEgKzIyNywxNiBAQCBzdHJ1Y3Qgb3Y5NjV4X2N0cmxzIHsNCj4+ICAgCXU4IHVwZGF0 ZTsNCj4+ICAgfTsNCj4+ICAgDQo+PiArc3RydWN0IGkyY19ydiB7DQo+PiArCXU4IGFkZHI7DQo+ PiArCXU4IHZhbHVlOw0KPj4gK307DQo+PiArDQo+PiAgIHN0cnVjdCBvdjk2NXhfZnJhbWVzaXpl IHsNCj4+ICAgCXUxNiB3aWR0aDsNCj4+ICAgCXUxNiBoZWlnaHQ7DQo+PiAgIAl1MTYgbWF4X2V4 cF9saW5lczsNCj4+IC0JY29uc3QgdTggKnJlZ3M7DQo+PiArCWNvbnN0IHN0cnVjdCBpMmNfcnYg KnJlZ3M7DQo+PiAgIH07DQo+PiAgIA0KPj4gICBzdHJ1Y3Qgb3Y5NjV4X2ludGVydmFsIHsNCj4+ IEBAIC0yODAsOSArMjg1LDExIEBAIHN0cnVjdCBvdjk2NXggew0KPj4gICAJdTggYXBwbHlfZnJh bWVfZm10Ow0KPj4gICB9Ow0KPj4gICANCj4+IC1zdHJ1Y3QgaTJjX3J2IHsNCj4+IC0JdTggYWRk cjsNCj4+IC0JdTggdmFsdWU7DQo+PiArc3RydWN0IG92OTY1eF9waXhmbXQgew0KPj4gKwl1MzIg Y29kZTsNCj4+ICsJdTMyIGNvbG9yc3BhY2U7DQo+PiArCS8qIFJFR19UU0xCIHZhbHVlLCBvbmx5 IGJpdHMgWzM6Ml0gbWF5IGJlIHNldC4gKi8NCj4+ICsJdTggdHNsYl9yZWc7DQo+PiAgIH07DQo+ PiAgIA0KPj4gICBzdGF0aWMgY29uc3Qgc3RydWN0IGkyY19ydiBvdjk2NXhfaW5pdF9yZWdzW10g PSB7DQo+PiBAQCAtMzQyLDMwICszNDksNTkgQEAgc3RydWN0IGkyY19ydiB7DQo+PiAgIAl7IFJF R19OVUxMLCAwIH0NCj4+ICAgfTsNCj4+ICAgDQo+PiAtI2RlZmluZSBOVU1fRk1UX1JFR1MgMTQN Cj4+IC0vKg0KPj4gLSAqIENPTTcsICBDT00zLCAgQ09NNCwgSFNUQVJULCBIU1RPUCwgSFJFRiwg VlNUQVJULCBWU1RPUCwgVlJFRiwNCj4+IC0gKiBFWEhDSCwgRVhIQ0wsIEFEQywgIE9DT00sICAg T0ZPTg0KPj4gLSAqLw0KPj4gLXN0YXRpYyBjb25zdCB1OCBmcmFtZV9zaXplX3JlZ19hZGRyW05V TV9GTVRfUkVHU10gPSB7DQo+PiAtCTB4MTIsIDB4MGMsIDB4MGQsIDB4MTcsIDB4MTgsIDB4MzIs IDB4MTksIDB4MWEsIDB4MDMsDQo+PiAtCTB4MmEsIDB4MmIsIDB4MzcsIDB4MzgsIDB4MzksDQo+ PiAtfTsNCj4+IC0NCj4+IC1zdGF0aWMgY29uc3QgdTggb3Y5NjV4X3N4Z2FfcmVnc1tOVU1fRk1U X1JFR1NdID0gew0KPj4gLQkweDAwLCAweDAwLCAweDAwLCAweDFlLCAweGJlLCAweGJmLCAweDAx LCAweDgxLCAweDEyLA0KPj4gLQkweDEwLCAweDM0LCAweDgxLCAweDkzLCAweDUxLA0KPj4gK3N0 YXRpYyBjb25zdCBzdHJ1Y3QgaTJjX3J2IG92OTY1eF9zeGdhX3JlZ3NbXSA9IHsNCj4+ICsJeyBS RUdfQ09NNywgMHgwMCB9LA0KPj4gKwl7IFJFR19DT00zLCAweDAwIH0sDQo+PiArCXsgUkVHX0NP TTQsIDB4MDAgfSwNCj4+ICsJeyBSRUdfSFNUQVJULCAweDFlIH0sDQo+PiArCXsgUkVHX0hTVE9Q LCAweGJlIH0sDQo+PiArCXsgMHgzMiwgMHhiZiB9LA0KPj4gKwl7IFJFR19WU1RBUlQsIDB4MDEg fSwNCj4+ICsJeyBSRUdfVlNUT1AsIDB4ODEgfSwNCj4+ICsJeyBSRUdfVlJFRiwgMHgxMiB9LA0K Pj4gKwl7IFJFR19FWEhDSCwgMHgxMCB9LA0KPj4gKwl7IFJFR19FWEhDTCwgMHgzNCB9LA0KPj4g Kwl7IFJFR19BREMsIDB4ODEgfSwNCj4+ICsJeyBSRUdfQUNPTSwgMHg5MyB9LA0KPj4gKwl7IFJF R19PRk9OLCAweDUxIH0sDQo+PiArCXsgUkVHX05VTEwsIDAgfSwNCj4+ICAgfTsNCj4+ICAgDQo+ PiAtc3RhdGljIGNvbnN0IHU4IG92OTY1eF92Z2FfcmVnc1tOVU1fRk1UX1JFR1NdID0gew0KPj4g LQkweDQwLCAweDA0LCAweDgwLCAweDI2LCAweGM2LCAweGVkLCAweDAxLCAweDNkLCAweDAwLA0K Pj4gLQkweDEwLCAweDQwLCAweDkxLCAweDEyLCAweDQzLA0KPj4gK3N0YXRpYyBjb25zdCBzdHJ1 Y3QgaTJjX3J2IG92OTY1eF92Z2FfcmVnc1tdID0gew0KPj4gKwl7IFJFR19DT003LCAweDQwIH0s DQo+PiArCXsgUkVHX0NPTTMsIDB4MDQgfSwNCj4+ICsJeyBSRUdfQ09NNCwgMHg4MCB9LA0KPj4g Kwl7IFJFR19IU1RBUlQsIDB4MjYgfSwNCj4+ICsJeyBSRUdfSFNUT1AsIDB4YzYgfSwNCj4+ICsJ eyAweDMyLCAweGVkIH0sDQo+PiArCXsgUkVHX1ZTVEFSVCwgMHgwMSB9LA0KPj4gKwl7IFJFR19W U1RPUCwgMHgzZCB9LA0KPj4gKwl7IFJFR19WUkVGLCAweDAwIH0sDQo+PiArCXsgUkVHX0VYSENI LCAweDEwIH0sDQo+PiArCXsgUkVHX0VYSENMLCAweDQwIH0sDQo+PiArCXsgUkVHX0FEQywgMHg5 MSB9LA0KPj4gKwl7IFJFR19BQ09NLCAweDEyIH0sDQo+PiArCXsgUkVHX09GT04sIDB4NDMgfSwN Cj4+ICsJeyBSRUdfTlVMTCwgMCB9LA0KPj4gICB9Ow0KPj4gICANCj4+ICAgLyogRGV0ZXJtaW5l ZCBlbXBpcmljYWxseS4gKi8NCj4+IC1zdGF0aWMgY29uc3QgdTggb3Y5NjV4X3F2Z2FfcmVnc1tO VU1fRk1UX1JFR1NdID0gew0KPj4gLQkweDEwLCAweDA0LCAweDgwLCAweDI1LCAweGM1LCAweGJm LCAweDAwLCAweDgwLCAweDEyLA0KPj4gLQkweDEwLCAweDQwLCAweDkxLCAweDEyLCAweDQzLA0K Pj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgaTJjX3J2IG92OTY1eF9xdmdhX3JlZ3NbXSA9IHsNCj4+ ICsJeyBSRUdfQ09NNywgMHgxMCB9LA0KPj4gKwl7IFJFR19DT00zLCAweDA0IH0sDQo+PiArCXsg UkVHX0NPTTQsIDB4ODAgfSwNCj4+ICsJeyBSRUdfSFNUQVJULCAweDI1IH0sDQo+PiArCXsgUkVH X0hTVE9QLCAweGM1IH0sDQo+PiArCXsgMHgzMiwgMHhiZiB9LA0KPj4gKwl7IFJFR19WU1RBUlQs IDB4MDAgfSwNCj4+ICsJeyBSRUdfVlNUT1AsIDB4ODAgfSwNCj4+ICsJeyBSRUdfVlJFRiwgMHgx MiB9LA0KPj4gKwl7IFJFR19FWEhDSCwgMHgxMCB9LA0KPj4gKwl7IFJFR19FWEhDTCwgMHg0MCB9 LA0KPj4gKwl7IFJFR19BREMsIDB4OTEgfSwNCj4+ICsJeyBSRUdfQUNPTSwgMHgxMiB9LA0KPj4g Kwl7IFJFR19PRk9OLCAweDQzIH0sDQo+PiArCXsgUkVHX05VTEwsIDAgfSwNCj4+ICAgfTsNCj4+ ICAgDQo+PiAgIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb3Y5NjV4X2ZyYW1lc2l6ZSBvdjk2NXhfZnJh bWVzaXplc1tdID0gew0KPj4gQEAgLTM4NywxMyArNDIzLDYgQEAgc3RydWN0IGkyY19ydiB7DQo+ PiAgIAl9LA0KPj4gICB9Ow0KPj4gICANCj4+IC1zdHJ1Y3Qgb3Y5NjV4X3BpeGZtdCB7DQo+PiAt CXUzMiBjb2RlOw0KPj4gLQl1MzIgY29sb3JzcGFjZTsNCj4+IC0JLyogUkVHX1RTTEIgdmFsdWUs IG9ubHkgYml0cyBbMzoyXSBtYXkgYmUgc2V0LiAqLw0KPj4gLQl1OCB0c2xiX3JlZzsNCj4+IC19 Ow0KPiANCj4gQW55IHBhcnRpY3VsYXIgcmVhc29uIGZvciBtb3Zpbmcgc3RydWN0IG92OTY1eF9w aXhmbXQgZGVmaW5pdGlvbj8NCg0KTm90IGluIHRoZSByaWdodCBwYXRjaCwgbXVzdCBiZSBpbiA1 LzYgW21lZGlhXSBvdjk2NTA6IGFkZCBtdWx0aXBsZSANCnZhcmlhbnQgc3VwcG9ydCwgSSdsbCBm aXggaW4gdjIuDQoNCj4gDQo+PiAtDQo+PiAgIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb3Y5NjV4X3Bp eGZtdCBvdjk2NXhfZm9ybWF0c1tdID0gew0KPj4gICAJeyBNRURJQV9CVVNfRk1UX1lVWVY4XzJY OCwgVjRMMl9DT0xPUlNQQUNFX0pQRUcsIDB4MDB9LA0KPj4gICAJeyBNRURJQV9CVVNfRk1UX1lW WVU4XzJYOCwgVjRMMl9DT0xPUlNQQUNFX0pQRUcsIDB4MDR9LA0KPj4gQEAgLTEyNjgsMTEgKzEy OTcsMTIgQEAgc3RhdGljIGludCBvdjk2NXhfc2V0X2ZtdChzdHJ1Y3QgdjRsMl9zdWJkZXYgKnNk LCBzdHJ1Y3QgdjRsMl9zdWJkZXZfcGFkX2NvbmZpZw0KPj4gICANCj4+ICAgc3RhdGljIGludCBv djk2NXhfc2V0X2ZyYW1lX3NpemUoc3RydWN0IG92OTY1eCAqb3Y5NjV4KQ0KPj4gICB7DQo+PiAt CWludCBpLCByZXQgPSAwOw0KPj4gKwlpbnQgcmV0ID0gMDsNCj4+ICsNCj4+ICsJdjRsMl9kYmco MSwgZGVidWcsIG92OTY1eC0+Y2xpZW50LCAiJXNcbiIsIF9fZnVuY19fKTsNCj4+ICAgDQo+PiAt CWZvciAoaSA9IDA7IHJldCA9PSAwICYmIGkgPCBOVU1fRk1UX1JFR1M7IGkrKykNCj4+IC0JCXJl dCA9IG92OTY1eF93cml0ZShvdjk2NXgtPmNsaWVudCwgZnJhbWVfc2l6ZV9yZWdfYWRkcltpXSwN Cj4+IC0JCQkJICAgb3Y5NjV4LT5mcmFtZV9zaXplLT5yZWdzW2ldKTsNCj4+ICsJcmV0ID0gb3Y5 NjV4X3dyaXRlX2FycmF5KG92OTY1eC0+Y2xpZW50LA0KPj4gKwkJCQkgb3Y5NjV4LT5mcmFtZV9z aXplLT5yZWdzKTsNCj4+ICAgCXJldHVybiByZXQ7DQo+PiAgIH0NCj4+ICAgDQo+IA== From mboxrd@z Thu Jan 1 00:00:00 1970 From: hugues.fruchet@st.com (Hugues FRUCHET) Date: Thu, 29 Jun 2017 13:59:31 +0000 Subject: [PATCH v1 4/6] [media] ov9650: use write_array() for resolution sequences In-Reply-To: <20170626163330.GR12407@valkosipuli.retiisi.org.uk> References: <1498143942-12682-1-git-send-email-hugues.fruchet@st.com> <1498143942-12682-5-git-send-email-hugues.fruchet@st.com> <20170626163330.GR12407@valkosipuli.retiisi.org.uk> Message-ID: <9ac5d920-b29e-afe3-4413-3e147870a103@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/26/2017 06:33 PM, Sakari Ailus wrote: > Hi Hugues, > > On Thu, Jun 22, 2017 at 05:05:40PM +0200, Hugues Fruchet wrote: >> Align resolution sequences on initialization sequence using >> i2c_rv structure NULL terminated .This add flexibility >> on resolution sequence size. >> Document resolution related registers by using corresponding >> define instead of hexa address/value. >> >> Signed-off-by: Hugues Fruchet >> --- >> drivers/media/i2c/ov9650.c | 98 ++++++++++++++++++++++++++++++---------------- >> 1 file changed, 64 insertions(+), 34 deletions(-) >> >> diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c >> index 4311da6..8b283c9 100644 >> --- a/drivers/media/i2c/ov9650.c >> +++ b/drivers/media/i2c/ov9650.c >> @@ -227,11 +227,16 @@ struct ov965x_ctrls { >> u8 update; >> }; >> >> +struct i2c_rv { >> + u8 addr; >> + u8 value; >> +}; >> + >> struct ov965x_framesize { >> u16 width; >> u16 height; >> u16 max_exp_lines; >> - const u8 *regs; >> + const struct i2c_rv *regs; >> }; >> >> struct ov965x_interval { >> @@ -280,9 +285,11 @@ struct ov965x { >> u8 apply_frame_fmt; >> }; >> >> -struct i2c_rv { >> - u8 addr; >> - u8 value; >> +struct ov965x_pixfmt { >> + u32 code; >> + u32 colorspace; >> + /* REG_TSLB value, only bits [3:2] may be set. */ >> + u8 tslb_reg; >> }; >> >> static const struct i2c_rv ov965x_init_regs[] = { >> @@ -342,30 +349,59 @@ struct i2c_rv { >> { REG_NULL, 0 } >> }; >> >> -#define NUM_FMT_REGS 14 >> -/* >> - * COM7, COM3, COM4, HSTART, HSTOP, HREF, VSTART, VSTOP, VREF, >> - * EXHCH, EXHCL, ADC, OCOM, OFON >> - */ >> -static const u8 frame_size_reg_addr[NUM_FMT_REGS] = { >> - 0x12, 0x0c, 0x0d, 0x17, 0x18, 0x32, 0x19, 0x1a, 0x03, >> - 0x2a, 0x2b, 0x37, 0x38, 0x39, >> -}; >> - >> -static const u8 ov965x_sxga_regs[NUM_FMT_REGS] = { >> - 0x00, 0x00, 0x00, 0x1e, 0xbe, 0xbf, 0x01, 0x81, 0x12, >> - 0x10, 0x34, 0x81, 0x93, 0x51, >> +static const struct i2c_rv ov965x_sxga_regs[] = { >> + { REG_COM7, 0x00 }, >> + { REG_COM3, 0x00 }, >> + { REG_COM4, 0x00 }, >> + { REG_HSTART, 0x1e }, >> + { REG_HSTOP, 0xbe }, >> + { 0x32, 0xbf }, >> + { REG_VSTART, 0x01 }, >> + { REG_VSTOP, 0x81 }, >> + { REG_VREF, 0x12 }, >> + { REG_EXHCH, 0x10 }, >> + { REG_EXHCL, 0x34 }, >> + { REG_ADC, 0x81 }, >> + { REG_ACOM, 0x93 }, >> + { REG_OFON, 0x51 }, >> + { REG_NULL, 0 }, >> }; >> >> -static const u8 ov965x_vga_regs[NUM_FMT_REGS] = { >> - 0x40, 0x04, 0x80, 0x26, 0xc6, 0xed, 0x01, 0x3d, 0x00, >> - 0x10, 0x40, 0x91, 0x12, 0x43, >> +static const struct i2c_rv ov965x_vga_regs[] = { >> + { REG_COM7, 0x40 }, >> + { REG_COM3, 0x04 }, >> + { REG_COM4, 0x80 }, >> + { REG_HSTART, 0x26 }, >> + { REG_HSTOP, 0xc6 }, >> + { 0x32, 0xed }, >> + { REG_VSTART, 0x01 }, >> + { REG_VSTOP, 0x3d }, >> + { REG_VREF, 0x00 }, >> + { REG_EXHCH, 0x10 }, >> + { REG_EXHCL, 0x40 }, >> + { REG_ADC, 0x91 }, >> + { REG_ACOM, 0x12 }, >> + { REG_OFON, 0x43 }, >> + { REG_NULL, 0 }, >> }; >> >> /* Determined empirically. */ >> -static const u8 ov965x_qvga_regs[NUM_FMT_REGS] = { >> - 0x10, 0x04, 0x80, 0x25, 0xc5, 0xbf, 0x00, 0x80, 0x12, >> - 0x10, 0x40, 0x91, 0x12, 0x43, >> +static const struct i2c_rv ov965x_qvga_regs[] = { >> + { REG_COM7, 0x10 }, >> + { REG_COM3, 0x04 }, >> + { REG_COM4, 0x80 }, >> + { REG_HSTART, 0x25 }, >> + { REG_HSTOP, 0xc5 }, >> + { 0x32, 0xbf }, >> + { REG_VSTART, 0x00 }, >> + { REG_VSTOP, 0x80 }, >> + { REG_VREF, 0x12 }, >> + { REG_EXHCH, 0x10 }, >> + { REG_EXHCL, 0x40 }, >> + { REG_ADC, 0x91 }, >> + { REG_ACOM, 0x12 }, >> + { REG_OFON, 0x43 }, >> + { REG_NULL, 0 }, >> }; >> >> static const struct ov965x_framesize ov965x_framesizes[] = { >> @@ -387,13 +423,6 @@ struct i2c_rv { >> }, >> }; >> >> -struct ov965x_pixfmt { >> - u32 code; >> - u32 colorspace; >> - /* REG_TSLB value, only bits [3:2] may be set. */ >> - u8 tslb_reg; >> -}; > > Any particular reason for moving struct ov965x_pixfmt definition? Not in the right patch, must be in 5/6 [media] ov9650: add multiple variant support, I'll fix in v2. > >> - >> static const struct ov965x_pixfmt ov965x_formats[] = { >> { MEDIA_BUS_FMT_YUYV8_2X8, V4L2_COLORSPACE_JPEG, 0x00}, >> { MEDIA_BUS_FMT_YVYU8_2X8, V4L2_COLORSPACE_JPEG, 0x04}, >> @@ -1268,11 +1297,12 @@ static int ov965x_set_fmt(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config >> >> static int ov965x_set_frame_size(struct ov965x *ov965x) >> { >> - int i, ret = 0; >> + int ret = 0; >> + >> + v4l2_dbg(1, debug, ov965x->client, "%s\n", __func__); >> >> - for (i = 0; ret == 0 && i < NUM_FMT_REGS; i++) >> - ret = ov965x_write(ov965x->client, frame_size_reg_addr[i], >> - ov965x->frame_size->regs[i]); >> + ret = ov965x_write_array(ov965x->client, >> + ov965x->frame_size->regs); >> return ret; >> } >> >