From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B446AC43334 for ; Tue, 28 Jun 2022 06:28:35 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.356978.585363 (Exim 4.92) (envelope-from ) id 1o64hx-00013P-6S; Tue, 28 Jun 2022 06:28:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 356978.585363; Tue, 28 Jun 2022 06:28:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o64hx-00013I-3Y; Tue, 28 Jun 2022 06:28:21 +0000 Received: by outflank-mailman (input) for mailman id 356978; Tue, 28 Jun 2022 06:28:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o64hw-00013A-AZ for xen-devel@lists.xenproject.org; Tue, 28 Jun 2022 06:28:20 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 7f87094d-f6ab-11ec-bd2d-47488cf2e6aa; Tue, 28 Jun 2022 08:28:18 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E4571152B; Mon, 27 Jun 2022 23:28:17 -0700 (PDT) Received: from [10.57.39.195] (unknown [10.57.39.195]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BCC7C3F5A1; Mon, 27 Jun 2022 23:28:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f87094d-f6ab-11ec-bd2d-47488cf2e6aa Message-ID: <9aca51aa-16f5-53de-46b1-94785faccecb@arm.com> Date: Tue, 28 Jun 2022 08:28:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 6/7] xsm/flask: Use unsigned int instead of plain unsigned Content-Language: en-US To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Daniel De Graaf , Jason Andryuk References: <20220627131543.410971-1-michal.orzel@arm.com> <20220627131543.410971-7-michal.orzel@arm.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Daniel, On 27.06.2022 21:19, Daniel P. Smith wrote: > > On 6/27/22 09:15, Michal Orzel wrote: >> This is just for the style and consistency reasons as the former is >> being used more often than the latter. >> >> Signed-off-by: Michal Orzel >> --- >> xen/xsm/flask/ss/avtab.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/xen/xsm/flask/ss/avtab.c b/xen/xsm/flask/ss/avtab.c >> index 017f5183de..9761d028d8 100644 >> --- a/xen/xsm/flask/ss/avtab.c >> +++ b/xen/xsm/flask/ss/avtab.c >> @@ -349,7 +349,7 @@ int avtab_read_item(struct avtab *a, void *fp, struct policydb *pol, >> struct avtab_key key; >> struct avtab_datum datum; >> int i, rc; >> - unsigned set; >> + unsigned int set; >> >> memset(&key, 0, sizeof(struct avtab_key)); >> memset(&datum, 0, sizeof(struct avtab_datum)); > > Is this not v2? Jason gave a Rb on the similar patch if I am not mistaken. > No it is not. This applies to all the patches in this series that was pushed as a new one due to different justification/commit titles/commit msgs (see cover letter). > v/r, > dps Cheers, Michal