From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F634C43387 for ; Mon, 14 Jan 2019 18:52:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E20322064C for ; Mon, 14 Jan 2019 18:52:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726806AbfANSw3 (ORCPT ); Mon, 14 Jan 2019 13:52:29 -0500 Received: from proxima.lasnet.de ([78.47.171.185]:43489 "EHLO proxima.lasnet.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726734AbfANSw2 (ORCPT ); Mon, 14 Jan 2019 13:52:28 -0500 Received: from localhost.localdomain (p200300E9D70DB1A9F35C53A5883DC5AE.dip0.t-ipconnect.de [IPv6:2003:e9:d70d:b1a9:f35c:53a5:883d:c5ae]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: stefan@datenfreihafen.org) by proxima.lasnet.de (Postfix) with ESMTPSA id 38434C8C28; Mon, 14 Jan 2019 19:52:25 +0100 (CET) Subject: Re: [PATCH net-next] 6lowpan: fix debugfs_simple_attr.cocci warnings To: Alexander Aring , YueHaibing Cc: Alexander Aring , Jukka Rissanen , linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org, kernel-janitors@vger.kernel.org References: <1545274433-146957-1-git-send-email-yuehaibing@huawei.com> <20181224161258.gvvq25k3ufuyt3ej@x220t> From: Stefan Schmidt Message-ID: <9acdfea8-caf7-6349-4963-5c638425a8ab@datenfreihafen.org> Date: Mon, 14 Jan 2019 19:52:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <20181224161258.gvvq25k3ufuyt3ej@x220t> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hello. On 24.12.18 17:12, Alexander Aring wrote: > Hi, > > On Thu, Dec 20, 2018 at 02:53:53AM +0000, YueHaibing wrote: >> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE >> for debugfs files. >> >> Semantic patch information: >> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() >> imposes some significant overhead as compared to >> DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). >> > > Ok. > >> Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci >> >> Signed-off-by: YueHaibing > > Acked-by: Alexander Aring Marcel, Johan, can one of you apply this? My rule is still that 6lowpan patches are going through the bluetooth tree. If you want me to pick the sporadic patch here and there for 6lowpan let me know. regards Stefan Schmidt From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Schmidt Date: Mon, 14 Jan 2019 18:52:23 +0000 Subject: Re: [PATCH net-next] 6lowpan: fix debugfs_simple_attr.cocci warnings Message-Id: <9acdfea8-caf7-6349-4963-5c638425a8ab@datenfreihafen.org> List-Id: References: <1545274433-146957-1-git-send-email-yuehaibing@huawei.com> <20181224161258.gvvq25k3ufuyt3ej@x220t> In-Reply-To: <20181224161258.gvvq25k3ufuyt3ej@x220t> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Aring , YueHaibing Cc: Alexander Aring , Jukka Rissanen , linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org, kernel-janitors@vger.kernel.org Hello. On 24.12.18 17:12, Alexander Aring wrote: > Hi, > > On Thu, Dec 20, 2018 at 02:53:53AM +0000, YueHaibing wrote: >> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE >> for debugfs files. >> >> Semantic patch information: >> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() >> imposes some significant overhead as compared to >> DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). >> > > Ok. > >> Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci >> >> Signed-off-by: YueHaibing > > Acked-by: Alexander Aring Marcel, Johan, can one of you apply this? My rule is still that 6lowpan patches are going through the bluetooth tree. If you want me to pick the sporadic patch here and there for 6lowpan let me know. regards Stefan Schmidt