All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Chanho Park <chanho61.park@samsung.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	linux-phy@lists.infradead.org
Subject: Re: [PATCH v5 1/2] phy: samsung-ufs: move phy-exynos7-ufs header
Date: Fri, 9 Jul 2021 19:36:39 +0200	[thread overview]
Message-ID: <9b097613-3d54-65f8-ffb2-123b266fc29b@canonical.com> (raw)
In-Reply-To: <4e2adf91-9495-17f8-0e65-169346f9583d@canonical.com>

On 09/07/2021 19:31, Krzysztof Kozlowski wrote:
> On 09/07/2021 11:45, Chanho Park wrote:
>> Instead of using exynos7 ufs definition in phy-exynos7-ufs.h, we should
>> put it into phy-exynos7-ufs.c to be included different objects or units.
>>
>> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
>> ---
>>  drivers/phy/samsung/Makefile                              | 4 +++-
>>  .../phy/samsung/{phy-exynos7-ufs.h => phy-exynos7-ufs.c}  | 8 ++------
>>  drivers/phy/samsung/phy-samsung-ufs.h                     | 5 ++++-
>>  3 files changed, 9 insertions(+), 8 deletions(-)
>>  rename drivers/phy/samsung/{phy-exynos7-ufs.h => phy-exynos7-ufs.c} (93%)
>>
>> diff --git a/drivers/phy/samsung/Makefile b/drivers/phy/samsung/Makefile
>> index 3959100fe8a2..68518ae30c1b 100644
>> --- a/drivers/phy/samsung/Makefile
>> +++ b/drivers/phy/samsung/Makefile
>> @@ -2,7 +2,9 @@
>>  obj-$(CONFIG_PHY_EXYNOS_DP_VIDEO)	+= phy-exynos-dp-video.o
>>  obj-$(CONFIG_PHY_EXYNOS_MIPI_VIDEO)	+= phy-exynos-mipi-video.o
>>  obj-$(CONFIG_PHY_EXYNOS_PCIE)		+= phy-exynos-pcie.o
>> -obj-$(CONFIG_PHY_SAMSUNG_UFS)		+= phy-samsung-ufs.o
>> +obj-$(CONFIG_PHY_SAMSUNG_UFS)		+= phy-exynos-ufs.o
>> +phy-exynos-ufs-y			+= phy-samsung-ufs.o
>> +phy-exynos-ufs-y			+= phy-exynos7-ufs.o
> 
> How does it support module builds? The previous code was working fine
> when built as module. Maybe I miss something, but I don't see the need
> for this change.

Ah, I see now, your previous patch was creating separate modules. Makes
sens, thanks!

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


Best regards,
Krzysztof

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2021-07-09 17:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210709100037epcas2p4893e64c9007777d054b59b2688a9dba8@epcas2p4.samsung.com>
2021-07-09  9:45 ` [PATCH v5 0/2] Support exynosautov9 ufs phy driver Chanho Park
     [not found]   ` <CGME20210709100037epcas2p2be75773648d859ec29d96a901b6d9a5c@epcas2p2.samsung.com>
2021-07-09  9:45     ` [PATCH v5 1/2] phy: samsung-ufs: move phy-exynos7-ufs header Chanho Park
2021-07-09 17:31       ` Krzysztof Kozlowski
2021-07-09 17:36         ` Krzysztof Kozlowski [this message]
     [not found]   ` <CGME20210709100038epcas2p231dc148962cc46065f7a896e7d30cbba@epcas2p2.samsung.com>
2021-07-09  9:45     ` [PATCH v5 2/2] phy: samsung-ufs: support exynosauto ufs phy driver Chanho Park
2021-07-09 17:33       ` Krzysztof Kozlowski
2021-07-12  0:37         ` Chanho Park
2021-07-20 11:13   ` [PATCH v5 0/2] Support exynosautov9 " Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b097613-3d54-65f8-ffb2-123b266fc29b@canonical.com \
    --to=krzysztof.kozlowski@canonical.com \
    --cc=alim.akhtar@samsung.com \
    --cc=chanho61.park@samsung.com \
    --cc=jh80.chung@samsung.com \
    --cc=kishon@ti.com \
    --cc=linux-phy@lists.infradead.org \
    --cc=m.szyprowski@samsung.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.