From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14F9AC636D6 for ; Thu, 2 Feb 2023 17:00:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232468AbjBBRAU (ORCPT ); Thu, 2 Feb 2023 12:00:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231821AbjBBRAD (ORCPT ); Thu, 2 Feb 2023 12:00:03 -0500 Received: from mailout-taastrup.gigahost.dk (mailout-taastrup.gigahost.dk [46.183.139.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30CA5E3B2; Thu, 2 Feb 2023 09:00:02 -0800 (PST) Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id B73B0188374A; Thu, 2 Feb 2023 17:00:00 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id AA3FC250007B; Thu, 2 Feb 2023 17:00:00 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id A43119B403E1; Thu, 2 Feb 2023 17:00:00 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Thu, 02 Feb 2023 18:00:00 +0100 From: netdev@kapio-technology.com To: Simon Horman Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , "maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" , Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , =?UTF-8?Q?Cl=C3=A9m?= =?UTF-8?Q?ent_L=C3=A9ger?= , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Russell King , Christian Marangi , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" , "moderated list:ETHERNET BRIDGE" Subject: Re: [PATCH net-next 5/5] net: dsa: mv88e6xxx: implementation of dynamic ATU entries In-Reply-To: References: <20230130173429.3577450-1-netdev@kapio-technology.com> <20230130173429.3577450-6-netdev@kapio-technology.com> User-Agent: Gigahost Webmail Message-ID: <9b12275969a204739ccfab972d90f20f@kapio-technology.com> X-Sender: netdev@kapio-technology.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-01-31 19:56, Simon Horman wrote: >> --- a/drivers/net/dsa/mv88e6xxx/chip.c >> +++ b/drivers/net/dsa/mv88e6xxx/chip.c >> @@ -42,6 +42,7 @@ >> #include "ptp.h" >> #include "serdes.h" >> #include "smi.h" >> +#include "switchdev.h" >> >> static void assert_reg_lock(struct mv88e6xxx_chip *chip) >> { >> @@ -2726,18 +2727,25 @@ static int mv88e6xxx_port_fdb_add(struct >> dsa_switch *ds, int port, >> const unsigned char *addr, u16 vid, >> u16 fdb_flags, struct dsa_db db) >> { >> + bool is_dynamic = !!(fdb_flags & DSA_FDB_FLAG_DYNAMIC); >> struct mv88e6xxx_chip *chip = ds->priv; >> + u8 state; >> int err; >> >> - /* Ignore entries with flags set */ >> - if (fdb_flags) >> - return 0; >> + state = MV88E6XXX_G1_ATU_DATA_STATE_UC_STATIC; >> + if (is_dynamic) >> + state = MV88E6XXX_G1_ATU_DATA_STATE_UC_AGE_7_NEWEST; > > What if flags other than DSA_FDB_FLAG_DYNAMIC are set (in future)? They will have to be caught and handled here if there is support for it, e.g. something like... else if (someflag) dosomething(); For now only one flag will actually be set and they are mutually exclusive, as they will not make sense together with the potential flags I know, but that can change at some time of course. > >> + else >> + if (fdb_flags) > > nit: else if (fdb_flags) > >> + return 0; >> > > ... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1294C61DA4 for ; Thu, 2 Feb 2023 17:01:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G+aA67ydJg8r5Gql0PMS7o1nUNQutSk67UnQFmmCdB4=; b=LY8/ddMj38U9xl8qfcklAKUrUu /mFACOVxuhGsaP5H8uVwU/UogjNrkHvPk3V8VdkzK5A/G2YLoJdZJhSgwd/Xfm4japVjMcysCbZZE qPRnStNTW1EjH5VNH6MtiE8So1Ebb6nd2Wt2vOzrodluoueklOWEnbFBT8NPwHMLDqF4XAjVnbPU6 FXlDwxn1dDERq4bjjYkzws3PCqD+pU/WI3BjV9SrV6wxH5Na1HJ2dbZo12JYyNma/H8A6i9X21fDY xIDVXW88ItHaRI8kLufRCTlnxwgkRl24fKnkJLjmJ1gYd/sQY7pzfOoqgVD9cgfuYGGgba0pGsp6g aTt03KMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNcwP-00Gk21-Qj; Thu, 02 Feb 2023 17:00:05 +0000 Received: from mailout-taastrup.gigahost.dk ([46.183.139.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNcwM-00Gk07-HG; Thu, 02 Feb 2023 17:00:03 +0000 Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id B73B0188374A; Thu, 2 Feb 2023 17:00:00 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id AA3FC250007B; Thu, 2 Feb 2023 17:00:00 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id A43119B403E1; Thu, 2 Feb 2023 17:00:00 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Thu, 02 Feb 2023 18:00:00 +0100 From: netdev@kapio-technology.com To: Simon Horman Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , "maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" , Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , =?UTF-8?Q?Cl=C3=A9m?= =?UTF-8?Q?ent_L=C3=A9ger?= , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Russell King , Christian Marangi , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" , "moderated list:ETHERNET BRIDGE" Subject: Re: [PATCH net-next 5/5] net: dsa: mv88e6xxx: implementation of dynamic ATU entries In-Reply-To: References: <20230130173429.3577450-1-netdev@kapio-technology.com> <20230130173429.3577450-6-netdev@kapio-technology.com> User-Agent: Gigahost Webmail Message-ID: <9b12275969a204739ccfab972d90f20f@kapio-technology.com> X-Sender: netdev@kapio-technology.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230202_090002_801182_1BBF40D1 X-CRM114-Status: GOOD ( 13.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023-01-31 19:56, Simon Horman wrote: >> --- a/drivers/net/dsa/mv88e6xxx/chip.c >> +++ b/drivers/net/dsa/mv88e6xxx/chip.c >> @@ -42,6 +42,7 @@ >> #include "ptp.h" >> #include "serdes.h" >> #include "smi.h" >> +#include "switchdev.h" >> >> static void assert_reg_lock(struct mv88e6xxx_chip *chip) >> { >> @@ -2726,18 +2727,25 @@ static int mv88e6xxx_port_fdb_add(struct >> dsa_switch *ds, int port, >> const unsigned char *addr, u16 vid, >> u16 fdb_flags, struct dsa_db db) >> { >> + bool is_dynamic = !!(fdb_flags & DSA_FDB_FLAG_DYNAMIC); >> struct mv88e6xxx_chip *chip = ds->priv; >> + u8 state; >> int err; >> >> - /* Ignore entries with flags set */ >> - if (fdb_flags) >> - return 0; >> + state = MV88E6XXX_G1_ATU_DATA_STATE_UC_STATIC; >> + if (is_dynamic) >> + state = MV88E6XXX_G1_ATU_DATA_STATE_UC_AGE_7_NEWEST; > > What if flags other than DSA_FDB_FLAG_DYNAMIC are set (in future)? They will have to be caught and handled here if there is support for it, e.g. something like... else if (someflag) dosomething(); For now only one flag will actually be set and they are mutually exclusive, as they will not make sense together with the potential flags I know, but that can change at some time of course. > >> + else >> + if (fdb_flags) > > nit: else if (fdb_flags) > >> + return 0; >> > > ... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 016FA40606 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 5588E405BE MIME-Version: 1.0 Date: Thu, 02 Feb 2023 18:00:00 +0100 From: netdev@kapio-technology.com In-Reply-To: References: <20230130173429.3577450-1-netdev@kapio-technology.com> <20230130173429.3577450-6-netdev@kapio-technology.com> Message-ID: <9b12275969a204739ccfab972d90f20f@kapio-technology.com> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH net-next 5/5] net: dsa: mv88e6xxx: implementation of dynamic ATU entries List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Simon Horman Cc: Andrew Lunn , Alexandre Belloni , Nikolay Aleksandrov , Kurt Kanzenbach , Eric Dumazet , Ivan Vecera , Florian Fainelli , "moderated list:ETHERNET BRIDGE" , Russell King , Roopa Prabhu , kuba@kernel.org, Paolo Abeni , =?UTF-8?Q?Cl=C3=A9m?= =?UTF-8?Q?ent_L=C3=A9ger?= , Christian Marangi , Woojung Huh , Landen Chao , Jiri Pirko , Hauke Mehrtens , Sean Wang , DENG Qingfang , Claudiu Manoil , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , netdev@vger.kernel.org, open list , "maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" , "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" , Vladimir Oltean , davem@davemloft.net On 2023-01-31 19:56, Simon Horman wrote: >> --- a/drivers/net/dsa/mv88e6xxx/chip.c >> +++ b/drivers/net/dsa/mv88e6xxx/chip.c >> @@ -42,6 +42,7 @@ >> #include "ptp.h" >> #include "serdes.h" >> #include "smi.h" >> +#include "switchdev.h" >> >> static void assert_reg_lock(struct mv88e6xxx_chip *chip) >> { >> @@ -2726,18 +2727,25 @@ static int mv88e6xxx_port_fdb_add(struct >> dsa_switch *ds, int port, >> const unsigned char *addr, u16 vid, >> u16 fdb_flags, struct dsa_db db) >> { >> + bool is_dynamic = !!(fdb_flags & DSA_FDB_FLAG_DYNAMIC); >> struct mv88e6xxx_chip *chip = ds->priv; >> + u8 state; >> int err; >> >> - /* Ignore entries with flags set */ >> - if (fdb_flags) >> - return 0; >> + state = MV88E6XXX_G1_ATU_DATA_STATE_UC_STATIC; >> + if (is_dynamic) >> + state = MV88E6XXX_G1_ATU_DATA_STATE_UC_AGE_7_NEWEST; > > What if flags other than DSA_FDB_FLAG_DYNAMIC are set (in future)? They will have to be caught and handled here if there is support for it, e.g. something like... else if (someflag) dosomething(); For now only one flag will actually be set and they are mutually exclusive, as they will not make sense together with the potential flags I know, but that can change at some time of course. > >> + else >> + if (fdb_flags) > > nit: else if (fdb_flags) > >> + return 0; >> > > ...