All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] iot2050: binman: add missing-msg for blobs
@ 2021-12-09 16:10 Ivan Mikhaylov
  2021-12-10  0:15 ` Simon Glass
  0 siblings, 1 reply; 4+ messages in thread
From: Ivan Mikhaylov @ 2021-12-09 16:10 UTC (permalink / raw)
  To: Simon Glass, Jan Kiszka; +Cc: u-boot, Ivan Mikhaylov

From: Ivan Mikhaylov <ivan.mikhaylov@siemens.com>

Add the 'missing-msg' for blobs for more detailed output on missing system
firmware and SEBoot blobs.

Signed-off-by: Ivan Mikhaylov <ivan.mikhaylov@siemens.com>
---
 arch/arm/dts/k3-am65-iot2050-boot-image.dtsi |  5 +++++
 tools/binman/missing-blob-help               | 11 +++++++++++
 2 files changed, 16 insertions(+)

diff --git a/arch/arm/dts/k3-am65-iot2050-boot-image.dtsi b/arch/arm/dts/k3-am65-iot2050-boot-image.dtsi
index b0c758477d..4f0435cea5 100644
--- a/arch/arm/dts/k3-am65-iot2050-boot-image.dtsi
+++ b/arch/arm/dts/k3-am65-iot2050-boot-image.dtsi
@@ -19,6 +19,7 @@
 		blob-ext@0x000000 {
 			offset = <0x000000>;
 			filename = "tiboot3.bin";
+			missing-msg = "iot2050-seboot";
 		};
 
 		blob@0x080000 {
@@ -187,21 +188,25 @@
 		blob-ext@0x6c0000 {
 			offset = <0x6c0000>;
 			filename = "sysfw.itb";
+			missing-msg = "iot2050-sysfw";
 		};
 		/* PG1 sysfw, advanced variant */
 		blob-ext@0x740000 {
 			offset = <0x740000>;
 			filename = "sysfw.itb_HS";
+			missing-msg = "iot2050-sysfw";
 		};
 		/* PG2 sysfw, basic variant */
 		blob-ext@0x7c0000 {
 			offset = <0x7c0000>;
 			filename = "sysfw_sr2.itb";
+			missing-msg = "iot2050-sysfw";
 		};
 		/* PG2 sysfw, advanced variant */
 		blob-ext@0x840000 {
 			offset = <0x840000>;
 			filename = "sysfw_sr2.itb_HS";
+			missing-msg = "iot2050-sysfw";
 		};
 	};
 };
diff --git a/tools/binman/missing-blob-help b/tools/binman/missing-blob-help
index dc2d9c9811..d7c0c6bf16 100644
--- a/tools/binman/missing-blob-help
+++ b/tools/binman/missing-blob-help
@@ -18,6 +18,17 @@ scp-sunxi:
 SCP firmware is required for system suspend, but is otherwise optional.
 Please read the section on SCP firmware in board/sunxi/README.sunxi64
 
+iot2050-seboot:
+See the documentation for IOT2050 board. Your image missing SEBoot
+which is mandatory for board startup. Prebuilt SEBoot located at
+meta-iot2050/tree/master/recipes-bsp/u-boot/files/prebuild/tiboot3.bin.
+
+iot2050-sysfw:
+See the documentation for IOT2050 board. Your image missing system
+firmware which is mandatory for board startup. Prebuilt system firmware
+located at meta-iot2050/tree/master/recipes-bsp/u-boot/files/prebuild/
+with sysfw prefix.
+
 k3-rti-wdt-firmware:
 If CONFIG_WDT_K3_RTI_LOAD_FW is enabled, a firmware image is needed for
 the R5F core(s) to trigger the system reset. One possible source is
-- 
2.34.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] iot2050: binman: add missing-msg for blobs
  2021-12-09 16:10 [PATCH] iot2050: binman: add missing-msg for blobs Ivan Mikhaylov
@ 2021-12-10  0:15 ` Simon Glass
  2021-12-10 13:26   ` Ivan Mikhaylov
  2021-12-15  0:33   ` Simon Glass
  0 siblings, 2 replies; 4+ messages in thread
From: Simon Glass @ 2021-12-10  0:15 UTC (permalink / raw)
  To: Ivan Mikhaylov; +Cc: Jan Kiszka, u-boot, Ivan Mikhaylov

Hi Ivan,

On Thu, 9 Dec 2021 at 06:11, Ivan Mikhaylov <fr0st61te@gmail.com> wrote:
>
> From: Ivan Mikhaylov <ivan.mikhaylov@siemens.com>
>
> Add the 'missing-msg' for blobs for more detailed output on missing system
> firmware and SEBoot blobs.
>
> Signed-off-by: Ivan Mikhaylov <ivan.mikhaylov@siemens.com>
> ---
>  arch/arm/dts/k3-am65-iot2050-boot-image.dtsi |  5 +++++
>  tools/binman/missing-blob-help               | 11 +++++++++++
>  2 files changed, 16 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

nits below (I can fix when applying if you like?)

>
> diff --git a/arch/arm/dts/k3-am65-iot2050-boot-image.dtsi b/arch/arm/dts/k3-am65-iot2050-boot-image.dtsi
> index b0c758477d..4f0435cea5 100644
> --- a/arch/arm/dts/k3-am65-iot2050-boot-image.dtsi
> +++ b/arch/arm/dts/k3-am65-iot2050-boot-image.dtsi
> @@ -19,6 +19,7 @@
>                 blob-ext@0x000000 {
>                         offset = <0x000000>;
>                         filename = "tiboot3.bin";
> +                       missing-msg = "iot2050-seboot";
>                 };
>
>                 blob@0x080000 {
> @@ -187,21 +188,25 @@
>                 blob-ext@0x6c0000 {
>                         offset = <0x6c0000>;
>                         filename = "sysfw.itb";
> +                       missing-msg = "iot2050-sysfw";
>                 };
>                 /* PG1 sysfw, advanced variant */
>                 blob-ext@0x740000 {
>                         offset = <0x740000>;
>                         filename = "sysfw.itb_HS";
> +                       missing-msg = "iot2050-sysfw";
>                 };
>                 /* PG2 sysfw, basic variant */
>                 blob-ext@0x7c0000 {
>                         offset = <0x7c0000>;
>                         filename = "sysfw_sr2.itb";
> +                       missing-msg = "iot2050-sysfw";
>                 };
>                 /* PG2 sysfw, advanced variant */
>                 blob-ext@0x840000 {
>                         offset = <0x840000>;
>                         filename = "sysfw_sr2.itb_HS";
> +                       missing-msg = "iot2050-sysfw";
>                 };
>         };
>  };
> diff --git a/tools/binman/missing-blob-help b/tools/binman/missing-blob-help
> index dc2d9c9811..d7c0c6bf16 100644
> --- a/tools/binman/missing-blob-help
> +++ b/tools/binman/missing-blob-help
> @@ -18,6 +18,17 @@ scp-sunxi:
>  SCP firmware is required for system suspend, but is otherwise optional.
>  Please read the section on SCP firmware in board/sunxi/README.sunxi64
>
> +iot2050-seboot:
> +See the documentation for IOT2050 board. Your image missing SEBoot

image is missing

> +which is mandatory for board startup. Prebuilt SEBoot located at
> +meta-iot2050/tree/master/recipes-bsp/u-boot/files/prebuild/tiboot3.bin.
> +
> +iot2050-sysfw:
> +See the documentation for IOT2050 board. Your image missing system

image is missing

> +firmware which is mandatory for board startup. Prebuilt system firmware
> +located at meta-iot2050/tree/master/recipes-bsp/u-boot/files/prebuild/
> +with sysfw prefix.
> +
>  k3-rti-wdt-firmware:
>  If CONFIG_WDT_K3_RTI_LOAD_FW is enabled, a firmware image is needed for
>  the R5F core(s) to trigger the system reset. One possible source is
> --
> 2.34.0
>

Regards,
Simon

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] iot2050: binman: add missing-msg for blobs
  2021-12-10  0:15 ` Simon Glass
@ 2021-12-10 13:26   ` Ivan Mikhaylov
  2021-12-15  0:33   ` Simon Glass
  1 sibling, 0 replies; 4+ messages in thread
From: Ivan Mikhaylov @ 2021-12-10 13:26 UTC (permalink / raw)
  To: Simon Glass; +Cc: Jan Kiszka, u-boot, Ivan Mikhaylov

On Thu, 2021-12-09 at 17:15 -0700, Simon Glass wrote:
> Hi Ivan,
> 
> On Thu, 9 Dec 2021 at 06:11, Ivan Mikhaylov <fr0st61te@gmail.com>
> wrote:
> > 
> > From: Ivan Mikhaylov <ivan.mikhaylov@siemens.com>
> > 
> > Add the 'missing-msg' for blobs for more detailed output on missing
> > system
> > firmware and SEBoot blobs.
> > 
> > Signed-off-by: Ivan Mikhaylov <ivan.mikhaylov@siemens.com>
> > ---
> >  arch/arm/dts/k3-am65-iot2050-boot-image.dtsi |  5 +++++
> >  tools/binman/missing-blob-help               | 11 +++++++++++
> >  2 files changed, 16 insertions(+)
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> nits below (I can fix when applying if you like?)

Simon, yes, please.

Thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] iot2050: binman: add missing-msg for blobs
  2021-12-10  0:15 ` Simon Glass
  2021-12-10 13:26   ` Ivan Mikhaylov
@ 2021-12-15  0:33   ` Simon Glass
  1 sibling, 0 replies; 4+ messages in thread
From: Simon Glass @ 2021-12-15  0:33 UTC (permalink / raw)
  To: Ivan Mikhaylov; +Cc: Jan Kiszka, u-boot, Ivan Mikhaylov, Simon Glass

On Thu, 2021-12-09 at 17:15 -0700, Simon Glass wrote:
> Hi Ivan,
>
> On Thu, 9 Dec 2021 at 06:11, Ivan Mikhaylov <fr0st61te@gmail.com>
> wrote:
> >
> > From: Ivan Mikhaylov <ivan.mikhaylov@siemens.com>
> >
> > Add the 'missing-msg' for blobs for more detailed output on missing
> > system
> > firmware and SEBoot blobs.
> >
> > Signed-off-by: Ivan Mikhaylov <ivan.mikhaylov@siemens.com>
> > ---
> >  arch/arm/dts/k3-am65-iot2050-boot-image.dtsi |  5 +++++
> >  tools/binman/missing-blob-help               | 11 +++++++++++
> >  2 files changed, 16 insertions(+)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> nits below (I can fix when applying if you like?)

Simon, yes, please.

Thanks.

Applied to u-boot-dm/next, thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-12-15  0:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-09 16:10 [PATCH] iot2050: binman: add missing-msg for blobs Ivan Mikhaylov
2021-12-10  0:15 ` Simon Glass
2021-12-10 13:26   ` Ivan Mikhaylov
2021-12-15  0:33   ` Simon Glass

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.