From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19B34C433EF for ; Tue, 2 Nov 2021 16:08:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE39C60720 for ; Tue, 2 Nov 2021 16:08:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DE39C60720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DB203730F9; Tue, 2 Nov 2021 16:08:16 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF56B730F8; Tue, 2 Nov 2021 16:08:14 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10156"; a="231255565" X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="231255565" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 08:53:46 -0700 X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="531596994" Received: from vanderss-mobl.ger.corp.intel.com (HELO [10.249.254.234]) ([10.249.254.234]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 08:53:45 -0700 Message-ID: <9b449605-c2d2-c415-af28-822765f921bc@linux.intel.com> Date: Tue, 2 Nov 2021 16:53:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] drm/i915: fixup dma_fence_wait usage Content-Language: en-US To: Matthew Auld , intel-gfx@lists.freedesktop.org References: <20211102155055.100138-1-matthew.auld@intel.com> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= In-Reply-To: <20211102155055.100138-1-matthew.auld@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 11/2/21 16:50, Matthew Auld wrote: > dma_fence_wait expects a boolean for whether it should be interruptible, > not a timeout value. > > Signed-off-by: Matthew Auld > Cc: Thomas Hellström > --- > drivers/gpu/drm/i915/i915_vma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c > index 90546fa58fc1..8781c4f61952 100644 > --- a/drivers/gpu/drm/i915/i915_vma.c > +++ b/drivers/gpu/drm/i915/i915_vma.c > @@ -349,7 +349,7 @@ int i915_vma_wait_for_bind(struct i915_vma *vma) > fence = dma_fence_get_rcu_safe(&vma->active.excl.fence); > rcu_read_unlock(); > if (fence) { > - err = dma_fence_wait(fence, MAX_SCHEDULE_TIMEOUT); > + err = dma_fence_wait(fence, true); > dma_fence_put(fence); > } > } LGTM. Reviewed-by: Thomas Hellström From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E075C433F5 for ; Tue, 2 Nov 2021 16:08:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C63160720 for ; Tue, 2 Nov 2021 16:08:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5C63160720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D2B6D730F8; Tue, 2 Nov 2021 16:08:16 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF56B730F8; Tue, 2 Nov 2021 16:08:14 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10156"; a="231255565" X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="231255565" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 08:53:46 -0700 X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="531596994" Received: from vanderss-mobl.ger.corp.intel.com (HELO [10.249.254.234]) ([10.249.254.234]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 08:53:45 -0700 Message-ID: <9b449605-c2d2-c415-af28-822765f921bc@linux.intel.com> Date: Tue, 2 Nov 2021 16:53:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Content-Language: en-US To: Matthew Auld , intel-gfx@lists.freedesktop.org References: <20211102155055.100138-1-matthew.auld@intel.com> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= In-Reply-To: <20211102155055.100138-1-matthew.auld@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH] drm/i915: fixup dma_fence_wait usage X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 11/2/21 16:50, Matthew Auld wrote: > dma_fence_wait expects a boolean for whether it should be interruptible, > not a timeout value. > > Signed-off-by: Matthew Auld > Cc: Thomas Hellström > --- > drivers/gpu/drm/i915/i915_vma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c > index 90546fa58fc1..8781c4f61952 100644 > --- a/drivers/gpu/drm/i915/i915_vma.c > +++ b/drivers/gpu/drm/i915/i915_vma.c > @@ -349,7 +349,7 @@ int i915_vma_wait_for_bind(struct i915_vma *vma) > fence = dma_fence_get_rcu_safe(&vma->active.excl.fence); > rcu_read_unlock(); > if (fence) { > - err = dma_fence_wait(fence, MAX_SCHEDULE_TIMEOUT); > + err = dma_fence_wait(fence, true); > dma_fence_put(fence); > } > } LGTM. Reviewed-by: Thomas Hellström