From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn5u1-0004np-6f for qemu-devel@nongnu.org; Thu, 22 Sep 2016 11:27:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bn5tw-0002cU-Uz for qemu-devel@nongnu.org; Thu, 22 Sep 2016 11:27:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44650) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn5tw-0002cN-Oo for qemu-devel@nongnu.org; Thu, 22 Sep 2016 11:27:04 -0400 References: <1473678761-8885-1-git-send-email-pbonzini@redhat.com> <1473678761-8885-7-git-send-email-pbonzini@redhat.com> <87bmzgarel.fsf@linaro.org> From: Paolo Bonzini Message-ID: <9b5c24ae-f956-2bff-6a8a-ce5e77a0bfd5@redhat.com> Date: Thu, 22 Sep 2016 17:27:00 +0200 MIME-Version: 1.0 In-Reply-To: <87bmzgarel.fsf@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 06/16] cpus-common: move CPU list management to common code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= Cc: qemu-devel@nongnu.org, sergey.fedorov@linaro.org On 22/09/2016 17:24, Alex Benn=C3=A9e wrote: > I see this is code moved from elsewhere but I feel a little comment > about this should probably accompany the variable. I think it means onc= e > you have added a CPU without an explicit index all future CPUs will be > auto assigned and you can no longer add CPUs with a specific index? >=20 > Does this mean you can't hotplug additional CPUs without having > specified a CPU topology at start-up? I honestly have no idea. Paolo