From: Quentin Schulz <quentin.schulz@free-electrons.com> To: Icenowy Zheng <icenowy@aosc.io>, Chen-Yu Tsai <wens@csie.org>, Maxime Ripard <maxime.ripard@free-electrons.com>, Jonathan Cameron <jic23@kernel.org>, Lee Jones <lee.jones@linaro.org> Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [RFC PATCH 4/7] power: supply: axp20x-battery: support AXP803 Date: Mon, 25 Sep 2017 10:58:46 +0200 [thread overview] Message-ID: <9b72b982-85b2-22e0-076a-15c066619006@free-electrons.com> (raw) In-Reply-To: <20170920151814.22461-5-icenowy@aosc.io> Hi Icenowy, On 20/09/2017 17:18, Icenowy Zheng wrote: > The AXP803 PMIC has battery support like other AXP PMICs, but with > different definition of max target charging voltage and constant > charging current. > > Add support for AXP803 battery in axp20x-battery driver. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > --- > drivers/power/supply/axp20x_battery.c | 88 +++++++++++++++++++++++++++++++---- > 1 file changed, 78 insertions(+), 10 deletions(-) > > diff --git a/drivers/power/supply/axp20x_battery.c b/drivers/power/supply/axp20x_battery.c > index 7494f0f0eadb..c9a9fb320c92 100644 > --- a/drivers/power/supply/axp20x_battery.c > +++ b/drivers/power/supply/axp20x_battery.c > @@ -49,6 +49,8 @@ [...] > static void constant_charge_current_to_raw(struct axp20x_batt_ps *axp, int *val) > { > - if (axp->axp_id == AXP209_ID) > + switch (axp->axp_id) { > + case AXP209_ID: > *val = (*val - 300000) / 100000; > - else > + break; > + case AXP221_ID: > *val = (*val - 300000) / 150000; > + break; > + case AXP803_ID: > + *val = (*val - 200000) / 200000; > + /* > + * The maximum charge current on AXP803 is 2.8A, and the > + * datasheet says "1110-1111 reserved" in this part. > + * So we return an invalid value -1 in this situation, > + * which will be dealed by the caller of this function, > + */ Good, we could do that for the two others compatible as well. They are not explicitly marked as reserved but it stops at 1100 for AXP223/AXP221 for example. > + if (*val > 13) > + *val = -1; > + break; > + } > } > > static int axp20x_get_constant_charge_current(struct axp20x_batt_ps *axp, > @@ -269,9 +322,13 @@ static int axp20x_battery_get_prop(struct power_supply *psy, > if (ret) > return ret; > > - if (axp20x_batt->axp_id == AXP221_ID && > - !(reg & AXP22X_FG_VALID)) > - return -EINVAL; > + switch (axp20x_batt->axp_id) { > + case AXP221_ID: > + case AXP803_ID: > + if (!(reg & AXP22X_FG_VALID)) > + return -EINVAL; > + break; > + }; Looks weird to me. if (axp20x_batt->axp_id != AXP209_ID && !(reg & AXP22X_FG_VALID)) would be a better match? [...] Thanks, Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
WARNING: multiple messages have this Message-ID
From: Quentin Schulz <quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> To: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>, Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>, Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>, Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Subject: Re: [RFC PATCH 4/7] power: supply: axp20x-battery: support AXP803 Date: Mon, 25 Sep 2017 10:58:46 +0200 [thread overview] Message-ID: <9b72b982-85b2-22e0-076a-15c066619006@free-electrons.com> (raw) In-Reply-To: <20170920151814.22461-5-icenowy-h8G6r0blFSE@public.gmane.org> Hi Icenowy, On 20/09/2017 17:18, Icenowy Zheng wrote: > The AXP803 PMIC has battery support like other AXP PMICs, but with > different definition of max target charging voltage and constant > charging current. > > Add support for AXP803 battery in axp20x-battery driver. > > Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org> > --- > drivers/power/supply/axp20x_battery.c | 88 +++++++++++++++++++++++++++++++---- > 1 file changed, 78 insertions(+), 10 deletions(-) > > diff --git a/drivers/power/supply/axp20x_battery.c b/drivers/power/supply/axp20x_battery.c > index 7494f0f0eadb..c9a9fb320c92 100644 > --- a/drivers/power/supply/axp20x_battery.c > +++ b/drivers/power/supply/axp20x_battery.c > @@ -49,6 +49,8 @@ [...] > static void constant_charge_current_to_raw(struct axp20x_batt_ps *axp, int *val) > { > - if (axp->axp_id == AXP209_ID) > + switch (axp->axp_id) { > + case AXP209_ID: > *val = (*val - 300000) / 100000; > - else > + break; > + case AXP221_ID: > *val = (*val - 300000) / 150000; > + break; > + case AXP803_ID: > + *val = (*val - 200000) / 200000; > + /* > + * The maximum charge current on AXP803 is 2.8A, and the > + * datasheet says "1110-1111 reserved" in this part. > + * So we return an invalid value -1 in this situation, > + * which will be dealed by the caller of this function, > + */ Good, we could do that for the two others compatible as well. They are not explicitly marked as reserved but it stops at 1100 for AXP223/AXP221 for example. > + if (*val > 13) > + *val = -1; > + break; > + } > } > > static int axp20x_get_constant_charge_current(struct axp20x_batt_ps *axp, > @@ -269,9 +322,13 @@ static int axp20x_battery_get_prop(struct power_supply *psy, > if (ret) > return ret; > > - if (axp20x_batt->axp_id == AXP221_ID && > - !(reg & AXP22X_FG_VALID)) > - return -EINVAL; > + switch (axp20x_batt->axp_id) { > + case AXP221_ID: > + case AXP803_ID: > + if (!(reg & AXP22X_FG_VALID)) > + return -EINVAL; > + break; > + }; Looks weird to me. if (axp20x_batt->axp_id != AXP209_ID && !(reg & AXP22X_FG_VALID)) would be a better match? [...] Thanks, Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
WARNING: multiple messages have this Message-ID
From: quentin.schulz@free-electrons.com (Quentin Schulz) To: linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH 4/7] power: supply: axp20x-battery: support AXP803 Date: Mon, 25 Sep 2017 10:58:46 +0200 [thread overview] Message-ID: <9b72b982-85b2-22e0-076a-15c066619006@free-electrons.com> (raw) In-Reply-To: <20170920151814.22461-5-icenowy@aosc.io> Hi Icenowy, On 20/09/2017 17:18, Icenowy Zheng wrote: > The AXP803 PMIC has battery support like other AXP PMICs, but with > different definition of max target charging voltage and constant > charging current. > > Add support for AXP803 battery in axp20x-battery driver. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > --- > drivers/power/supply/axp20x_battery.c | 88 +++++++++++++++++++++++++++++++---- > 1 file changed, 78 insertions(+), 10 deletions(-) > > diff --git a/drivers/power/supply/axp20x_battery.c b/drivers/power/supply/axp20x_battery.c > index 7494f0f0eadb..c9a9fb320c92 100644 > --- a/drivers/power/supply/axp20x_battery.c > +++ b/drivers/power/supply/axp20x_battery.c > @@ -49,6 +49,8 @@ [...] > static void constant_charge_current_to_raw(struct axp20x_batt_ps *axp, int *val) > { > - if (axp->axp_id == AXP209_ID) > + switch (axp->axp_id) { > + case AXP209_ID: > *val = (*val - 300000) / 100000; > - else > + break; > + case AXP221_ID: > *val = (*val - 300000) / 150000; > + break; > + case AXP803_ID: > + *val = (*val - 200000) / 200000; > + /* > + * The maximum charge current on AXP803 is 2.8A, and the > + * datasheet says "1110-1111 reserved" in this part. > + * So we return an invalid value -1 in this situation, > + * which will be dealed by the caller of this function, > + */ Good, we could do that for the two others compatible as well. They are not explicitly marked as reserved but it stops at 1100 for AXP223/AXP221 for example. > + if (*val > 13) > + *val = -1; > + break; > + } > } > > static int axp20x_get_constant_charge_current(struct axp20x_batt_ps *axp, > @@ -269,9 +322,13 @@ static int axp20x_battery_get_prop(struct power_supply *psy, > if (ret) > return ret; > > - if (axp20x_batt->axp_id == AXP221_ID && > - !(reg & AXP22X_FG_VALID)) > - return -EINVAL; > + switch (axp20x_batt->axp_id) { > + case AXP221_ID: > + case AXP803_ID: > + if (!(reg & AXP22X_FG_VALID)) > + return -EINVAL; > + break; > + }; Looks weird to me. if (axp20x_batt->axp_id != AXP209_ID && !(reg & AXP22X_FG_VALID)) would be a better match? [...] Thanks, Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
next prev parent reply other threads:[~2017-09-25 8:59 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-20 15:18 [RFC PATCH 0/7] AXP803 AC/Battery support Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-20 15:18 ` [RFC PATCH 1/7] dt-bindings: add compatibles for AXP803 Battery/USB power supplies Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-25 9:14 ` Quentin Schulz 2017-09-25 9:14 ` Quentin Schulz 2017-09-25 9:14 ` Quentin Schulz 2017-09-20 15:18 ` [RFC PATCH 2/7] iio: adc: axp20x-adc: allow to skip ADC rate setup now Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-25 7:20 ` Quentin Schulz 2017-09-25 7:20 ` Quentin Schulz 2017-09-20 15:18 ` [RFC PATCH 3/7] iio: adc: axp20x-adc: add support for AXP803 Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-24 14:32 ` Jonathan Cameron 2017-09-24 14:32 ` Jonathan Cameron 2017-09-24 14:32 ` Jonathan Cameron 2017-09-25 8:48 ` Quentin Schulz 2017-09-25 8:48 ` Quentin Schulz 2017-09-25 8:48 ` Quentin Schulz 2017-09-20 15:18 ` [RFC PATCH 4/7] power: supply: axp20x-battery: support AXP803 Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-24 14:34 ` Jonathan Cameron 2017-09-24 14:34 ` Jonathan Cameron 2017-09-24 14:34 ` Jonathan Cameron 2017-09-25 8:58 ` Quentin Schulz [this message] 2017-09-25 8:58 ` Quentin Schulz 2017-09-25 8:58 ` Quentin Schulz 2017-09-20 15:18 ` [RFC PATCH 5/7] mfd: axp20x: add cells for AXP803 ADC/AC Power/Battery Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-20 15:18 ` [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-25 9:11 ` Quentin Schulz 2017-09-25 9:11 ` Quentin Schulz 2017-09-25 9:11 ` Quentin Schulz 2017-09-25 9:14 ` Icenowy Zheng 2017-09-25 9:14 ` Icenowy Zheng 2017-09-25 9:14 ` Icenowy Zheng 2017-09-25 9:19 ` [linux-sunxi] " Chen-Yu Tsai 2017-09-25 9:19 ` Chen-Yu Tsai 2017-09-25 9:19 ` Chen-Yu Tsai 2017-09-25 9:19 ` Chen-Yu Tsai 2017-09-25 9:24 ` Quentin Schulz 2017-09-25 9:24 ` Quentin Schulz 2017-09-25 9:24 ` Quentin Schulz 2017-09-20 15:18 ` [RFC PATCH 7/7] arm64: allwinner: a64: enable AC and Battery for Pine64 Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-21 14:46 ` [RFC PATCH 0/7] AXP803 AC/Battery support Jonathan Cameron 2017-09-21 14:46 ` Jonathan Cameron 2017-09-21 14:46 ` Jonathan Cameron 2017-09-21 15:20 ` Icenowy Zheng 2017-09-21 15:20 ` Icenowy Zheng 2017-09-21 15:20 ` Icenowy Zheng 2017-09-24 14:36 ` Jonathan Cameron 2017-09-24 14:36 ` Jonathan Cameron 2017-09-25 9:22 ` Quentin Schulz 2017-09-25 9:22 ` Quentin Schulz 2017-09-25 9:22 ` Quentin Schulz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9b72b982-85b2-22e0-076a-15c066619006@free-electrons.com \ --to=quentin.schulz@free-electrons.com \ --cc=devicetree@vger.kernel.org \ --cc=icenowy@aosc.io \ --cc=jic23@kernel.org \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-sunxi@googlegroups.com \ --cc=maxime.ripard@free-electrons.com \ --cc=wens@csie.org \ --subject='Re: [RFC PATCH 4/7] power: supply: axp20x-battery: support AXP803' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.