From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH v2] ARM: dts: exynos: remove Exynos4212 support (dead code) Date: Tue, 10 Jan 2017 09:06:44 -0300 Message-ID: <9b7dd5ac-c78b-a03c-9d9d-8d09b59d00f5@osg.samsung.com> References: <1483950880-16016-1-git-send-email-m.szyprowski@samsung.com> <4b68a14f-72e1-6aaf-0629-2ebb1dffc8e8@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:33493 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1761513AbdAJMGw (ORCPT ); Tue, 10 Jan 2017 07:06:52 -0500 In-Reply-To: <4b68a14f-72e1-6aaf-0629-2ebb1dffc8e8@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Marek Szyprowski , linux-samsung-soc@vger.kernel.org Cc: Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Kukjin Kim , Inki Dae Hello Marek, On 01/10/2017 04:48 AM, Marek Szyprowski wrote: > Hi Javier, > > On 2017-01-09 17:59, Javier Martinez Canillas wrote: >> Hello Marek, >> >> On 01/09/2017 05:34 AM, Marek Szyprowski wrote: >>> There are no Exynos4212 based boards in mainline, so there is no need to >>> keep additional files for SoCs, which are never used. This patch removes >>> support for Exynos4212 SoCs and moves previously shared Exynos4412 >>> definitions to a single file to simplify future maintenance. >>> >>> Signed-off-by: Marek Szyprowski >>> --- >> Patch looks good to me. >> >> Reviewed-by: Javier Martinez Canillas >> >> There are still a lot of references to Exynos4212 after this patch though. >> I see Kconfig symbols, macros, SoC specific logic and compatibles strings >> in Exynos platform code, drivers and DT bindings. >> >> Are you planning to also remove these as a follow-up? > > Yes, I plan to send follow-ups, especially for clocks, pincontrol drivers and > Kconfigs. However I don't plan to change compatible strings to keep > so called compatibility with old dtbs as requested by Krzysztof some time ago. > Drivers for Exynos4412 hw modules will still use "exynos4x12", "exynos4212" > and "exynos4412" strings as they do now. > I see, that makes sense. Thanks for the explanation. > Best regards Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America