From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0EE2C7EE23 for ; Mon, 5 Jun 2023 13:35:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234141AbjFENfK (ORCPT ); Mon, 5 Jun 2023 09:35:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234118AbjFENef (ORCPT ); Mon, 5 Jun 2023 09:34:35 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E66A6EE for ; Mon, 5 Jun 2023 06:34:32 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-9741a0fd134so809144066b.0 for ; Mon, 05 Jun 2023 06:34:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685972071; x=1688564071; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5rq3Widh6hOEiY5YdsfneGamzIlwkE0sJ5k3vngcFSc=; b=H1IHNMyQRtp1DX11ax4fGQWgXmX7bBwuCedLwUTO/0JImjrcWQ7PGrGucaNUYW9QWq OUft8vP7ux3whhgItsECM02LirXUQBIyB6Ybw9GTQC2z3G1v9H7yKm7biLhmZQAmiF84 fxrMtDdPeYmoM9gROxzDXjylvVQydkQmK7fvG5bBtrNELPq2EFtAbWquJc67We1IWHvV HBU8TNQWja6X0MwKURm6oaVdSzqmJN6qbm5yOpZarC2wmli/OIP6zZ1esJivH5vJaiA4 ODag4hmmTEijO9vsz5QmSXv3wxbgmkd1Lx74f0Zmt6RoBg/OR/6gQJp/fxXMXcaHcn+1 nWLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685972071; x=1688564071; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5rq3Widh6hOEiY5YdsfneGamzIlwkE0sJ5k3vngcFSc=; b=STKzM5D8OBy4/FnnesJgYQq030KP3fHts+1ruXpRy6FgH8P1HUv4q/bP7dpiW/Nr+5 tUwOsDCXTzXy17HkWrqlt56TPhWmjNSzleIM2/3tqgMPfpJzBvTNlcGAQEfgIVEP+wMc y3dW1mZIAFUgaUNH7rwNoZfHlOcanXOqj6/KiukyIBAVplh8PKcvbUw76Vid5wEVBEyk Rj4viHG9kalTanICxHQ2KuFrWOMeUP10Rb5LTnF7/X3eucAJSYM1ralvSdlaOYrt5xXU REY2UWY50EaqqJt5Z3f6sat4X0tAVwlqqBQQ+zIhGwpyoURT/CQK9jwSs7y5sLsr6mnF dyNQ== X-Gm-Message-State: AC+VfDypALBPLwfvO6rBhyzf3iZ5HFgGjDRh8YJhwsN7GTnkQWX3p5XW 33Ov8nVa9s8Jdu2mNpnFLoPU1g== X-Google-Smtp-Source: ACHHUZ7s745giAKDDO4doxV94noEtK/FRaEwLZP9MaulFyeyXHe/0hxRLNnut3NFVjxtd4jewVlWpA== X-Received: by 2002:a17:907:848:b0:974:61dc:107c with SMTP id ww8-20020a170907084800b0097461dc107cmr6376623ejb.44.1685972071027; Mon, 05 Jun 2023 06:34:31 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id g19-20020a170906869300b0097461a7ebdcsm4251734ejx.82.2023.06.05.06.34.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jun 2023 06:34:30 -0700 (PDT) Message-ID: <9b8a4221-beac-4394-8d71-a9060d4457f1@linaro.org> Date: Mon, 5 Jun 2023 15:34:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 21/21] net: macb: add support for gmac to sam9x7 Content-Language: en-US To: Nicolas Ferre , Varshini Rajendran , tglx@linutronix.de, maz@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, gregkh@linuxfoundation.org, linux@armlinux.org.uk, mturquette@baylibre.com, sboyd@kernel.org, sre@kernel.org, broonie@kernel.org, arnd@arndb.de, gregory.clement@bootlin.com, sudeep.holla@arm.com, balamanikandan.gunasundar@microchip.com, mihai.sain@microchip.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org Cc: Hari.PrasathGE@microchip.com, cristian.birsan@microchip.com, durai.manickamkr@microchip.com, manikandan.m@microchip.com, dharma.b@microchip.com, nayabbasha.sayed@microchip.com, balakrishnan.s@microchip.com References: <20230603200243.243878-1-varshini.rajendran@microchip.com> <20230603200243.243878-22-varshini.rajendran@microchip.com> <3e262485-bf5f-1a98-e399-e02add3eaa89@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <3e262485-bf5f-1a98-e399-e02add3eaa89@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/06/2023 14:07, Nicolas Ferre wrote: > On 05/06/2023 at 08:42, Krzysztof Kozlowski wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On 03/06/2023 22:02, Varshini Rajendran wrote: >>> From: Nicolas Ferre >>> >>> Add support for GMAC in sam9x7 SoC family >>> >>> Signed-off-by: Varshini Rajendran >>> Signed-off-by: Nicolas Ferre >>> --- >>> drivers/net/ethernet/cadence/macb_main.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c >>> index 29a1199dad14..609c8e9305ba 100644 >>> --- a/drivers/net/ethernet/cadence/macb_main.c >>> +++ b/drivers/net/ethernet/cadence/macb_main.c >>> @@ -4913,6 +4913,7 @@ static const struct of_device_id macb_dt_ids[] = { >>> { .compatible = "microchip,mpfs-macb", .data = &mpfs_config }, >>> { .compatible = "microchip,sama7g5-gem", .data = &sama7g5_gem_config }, >>> { .compatible = "microchip,sama7g5-emac", .data = &sama7g5_emac_config }, >>> + { .compatible = "microchip,sam9x7-gem", .data = &sama7g5_gem_config }, >> >> These are compatible, aren't they? Why do you need new entry? > > The hardware itself is different, even if the new features are not > supported yet in the macb driver. > The macb driver will certainly evolve in order to add these features so > we decided to match a new compatible string all the way to the driver. You claim to be fully compatible with sama7g5-gem, so adding new features does not warrant not-reusing old match entry now. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13B44C7EE24 for ; Mon, 5 Jun 2023 13:35:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B0G1jIgtDfukulUc4CjqpkvzZ+JhyM9KH9OAiAsOqw0=; b=vN9iP5XvrlB7NQ BORpHU2+Zl5LfWMHOmD/PxO26oXG44mbPEfA1k6GlwK2vIWW4O+N0IJjxm8UcRXK1aD6xoy79nury TG4ZuGI/xTUM8i9NSJ+4TjBJDS809w0ZJIp4sLaxF7UpM2I+BD42eAIjDZu8oz0A7vhzaEoc3U7v1 2K5/S2hvIAQfKKxaM2UQSpwgK2ByptTQom9T5y7wXbx6CafQq17JQt2BlwXn3bzeXWlVSP0RFKQLh yqRmjBVzrBkmRU4MamwMgR3q++WC/8o/rAJsC7denTYITkBKPmyDMHazvmIF31xIOd/P0d/kiP+mf ytwDjpc+kcy8xZZ36FKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6AM1-00FdJL-0z; Mon, 05 Jun 2023 13:34:37 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6ALy-00FdI5-2c for linux-arm-kernel@lists.infradead.org; Mon, 05 Jun 2023 13:34:36 +0000 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-9741a0fd134so809143966b.0 for ; Mon, 05 Jun 2023 06:34:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685972071; x=1688564071; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5rq3Widh6hOEiY5YdsfneGamzIlwkE0sJ5k3vngcFSc=; b=H1IHNMyQRtp1DX11ax4fGQWgXmX7bBwuCedLwUTO/0JImjrcWQ7PGrGucaNUYW9QWq OUft8vP7ux3whhgItsECM02LirXUQBIyB6Ybw9GTQC2z3G1v9H7yKm7biLhmZQAmiF84 fxrMtDdPeYmoM9gROxzDXjylvVQydkQmK7fvG5bBtrNELPq2EFtAbWquJc67We1IWHvV HBU8TNQWja6X0MwKURm6oaVdSzqmJN6qbm5yOpZarC2wmli/OIP6zZ1esJivH5vJaiA4 ODag4hmmTEijO9vsz5QmSXv3wxbgmkd1Lx74f0Zmt6RoBg/OR/6gQJp/fxXMXcaHcn+1 nWLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685972071; x=1688564071; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5rq3Widh6hOEiY5YdsfneGamzIlwkE0sJ5k3vngcFSc=; b=P+TFFP4vA/RZdn9rHpmse9DFp2Xi5wgmfxxL7My6a3lAb/DLGp1Bb9rZWuNkNxebZC am2ac7Ec2Sry4a1b50SZmbn5EggbqqZJtZ3LT+lAkUdxXql0ah7hlRZ/g5+eBYxMedqp mpLmbzkiuy3RFrcUNJxxNBy+F307dPYy4BNnMzcOMGM5lRjI+mPtwuWSalAa+O6Tjp5b 4BcpAf+4jKJ1qnzqIsT5YcxHXXLRBm3TjR5MV6DczNSXc7uIi168MIIpwJam0q130EbQ BgPtrkFTXrDcrD5WGcZZ9pbRyeJhWzq/FtrkeGPfxC8I1tFa/foOScSqsLptbdZJzmw9 qyVw== X-Gm-Message-State: AC+VfDyHbKD3kOcJvWgcpP+cyGGlUKV5+Znk+pxutGIo6wr6SvYaKcm9 CsSlXP4TS5kGL97J2DRs3hLmMA== X-Google-Smtp-Source: ACHHUZ7s745giAKDDO4doxV94noEtK/FRaEwLZP9MaulFyeyXHe/0hxRLNnut3NFVjxtd4jewVlWpA== X-Received: by 2002:a17:907:848:b0:974:61dc:107c with SMTP id ww8-20020a170907084800b0097461dc107cmr6376623ejb.44.1685972071027; Mon, 05 Jun 2023 06:34:31 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id g19-20020a170906869300b0097461a7ebdcsm4251734ejx.82.2023.06.05.06.34.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jun 2023 06:34:30 -0700 (PDT) Message-ID: <9b8a4221-beac-4394-8d71-a9060d4457f1@linaro.org> Date: Mon, 5 Jun 2023 15:34:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 21/21] net: macb: add support for gmac to sam9x7 Content-Language: en-US To: Nicolas Ferre , Varshini Rajendran , tglx@linutronix.de, maz@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, gregkh@linuxfoundation.org, linux@armlinux.org.uk, mturquette@baylibre.com, sboyd@kernel.org, sre@kernel.org, broonie@kernel.org, arnd@arndb.de, gregory.clement@bootlin.com, sudeep.holla@arm.com, balamanikandan.gunasundar@microchip.com, mihai.sain@microchip.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org Cc: Hari.PrasathGE@microchip.com, cristian.birsan@microchip.com, durai.manickamkr@microchip.com, manikandan.m@microchip.com, dharma.b@microchip.com, nayabbasha.sayed@microchip.com, balakrishnan.s@microchip.com References: <20230603200243.243878-1-varshini.rajendran@microchip.com> <20230603200243.243878-22-varshini.rajendran@microchip.com> <3e262485-bf5f-1a98-e399-e02add3eaa89@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <3e262485-bf5f-1a98-e399-e02add3eaa89@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230605_063434_854794_28D00305 X-CRM114-Status: GOOD ( 16.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/06/2023 14:07, Nicolas Ferre wrote: > On 05/06/2023 at 08:42, Krzysztof Kozlowski wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On 03/06/2023 22:02, Varshini Rajendran wrote: >>> From: Nicolas Ferre >>> >>> Add support for GMAC in sam9x7 SoC family >>> >>> Signed-off-by: Varshini Rajendran >>> Signed-off-by: Nicolas Ferre >>> --- >>> drivers/net/ethernet/cadence/macb_main.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c >>> index 29a1199dad14..609c8e9305ba 100644 >>> --- a/drivers/net/ethernet/cadence/macb_main.c >>> +++ b/drivers/net/ethernet/cadence/macb_main.c >>> @@ -4913,6 +4913,7 @@ static const struct of_device_id macb_dt_ids[] = { >>> { .compatible = "microchip,mpfs-macb", .data = &mpfs_config }, >>> { .compatible = "microchip,sama7g5-gem", .data = &sama7g5_gem_config }, >>> { .compatible = "microchip,sama7g5-emac", .data = &sama7g5_emac_config }, >>> + { .compatible = "microchip,sam9x7-gem", .data = &sama7g5_gem_config }, >> >> These are compatible, aren't they? Why do you need new entry? > > The hardware itself is different, even if the new features are not > supported yet in the macb driver. > The macb driver will certainly evolve in order to add these features so > we decided to match a new compatible string all the way to the driver. You claim to be fully compatible with sama7g5-gem, so adding new features does not warrant not-reusing old match entry now. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel