From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmKt9-0002JH-FQ for qemu-devel@nongnu.org; Mon, 28 Aug 2017 10:19:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmKsy-0001TW-PW for qemu-devel@nongnu.org; Mon, 28 Aug 2017 10:19:33 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38005 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dmKsy-0001TO-J0 for qemu-devel@nongnu.org; Mon, 28 Aug 2017 10:19:28 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v7SEFJ2d136789 for ; Mon, 28 Aug 2017 10:19:27 -0400 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0a-001b2d01.pphosted.com with ESMTP id 2cmjmxt012-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 28 Aug 2017 10:19:27 -0400 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 28 Aug 2017 15:19:25 +0100 References: <3ed8b810b6592daee6a775037ce21f850e40647d.1503667215.git.alifm@linux.vnet.ibm.com> <20170825160408.2775c8b5.cohuck@redhat.com> <00d41b2b-cf22-c9e2-8d9f-de947f4d3f18@linux.vnet.ibm.com> <20170828102214.7aad9112.cohuck@redhat.com> <20170828150653.7cdc8c5a.cohuck@redhat.com> <20170828160554.45855dfa.cohuck@redhat.com> From: Halil Pasic Date: Mon, 28 Aug 2017 16:19:21 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: <9b9880e4-71fd-4bc5-961b-ab0e2b298f03@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Farhan Ali , Cornelia Huck Cc: Christian Borntraeger , qemu-devel@nongnu.org, farman@linux.vnet.ibm.com, walling@linux.vnet.ibm.com On 08/28/2017 04:15 PM, Farhan Ali wrote: > > > On 08/28/2017 10:05 AM, Cornelia Huck wrote: >>>>> It's the alignment of the CCW which causes the problem. >>>>> >>>>> The exact error message when starting the guest was: >>>>> >>>>> ! No virtio device found ! >>>>> >>>>> Since it worked for SCSI and CDL, and failed for LDL disks on that particular system, we are not really sure what caused the failure. >>>>> Debugging it further showed the CCW for LDL disks were not aligned at double word boundary. >> This is really, really odd, as the low-level ccw code is the same for >> any disk type... >> > Exactly! > >>>>> Trying the test on a different system with LDL disks worked fine, with the aligned(8) fix. >>>> Do you happen to have an old s390-ccw.img laying around in the test folder? QEMU might pick up >>>> this one (e.g. when calling it without libvirt from the command line). >>>> >>> I explicitly mention the bios to use with '-bios' option and pick up the >>> latest bios. Without the aligned fix I see the error and with the fix it >>> works fine. >> Wait, so the fix fixes it? Or am I confused now? >> > > It fixes in my system and one other system we tried on. But fails on a system where this issue was first noticed. This is very confusing. So you have tried -bios on the system where the issue was first noticed and the issue still persists despite of the fixed bios is specified?