From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 710ECC43217 for ; Mon, 17 Jan 2022 15:00:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235069AbiAQPAt (ORCPT ); Mon, 17 Jan 2022 10:00:49 -0500 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:47284 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbiAQPAs (ORCPT ); Mon, 17 Jan 2022 10:00:48 -0500 Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id CAADA3F203 for ; Mon, 17 Jan 2022 15:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1642431646; bh=P1t3TusiuWvEJQvj6KQ3UI4zLwE3rcF19O3O8iabinU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S+hn/P/+ORd5yFuloev1kgWwDaFAaeiN7nXsJ/Qp+89KwtPN2IBixal8kgeBesRlT JuMKK4SrCzKujGFYUxxNKQOm0z40SXJhTOLhDq6j0VDJeJCpv8mH7761XWr1F55ZmH hJ6gp4DxAbO+DO2M4AqyUubDXzpV8h+tekH2Au09TTKSWGEiW3p+iDEQWOH4Oa52oQ Te3cUZi13alBYA2rH2c53+6rO+sWQgDlZw+xmz1+DhnLX3WgX7EiPopvGNz/ix18YE oGpKWMwnMk5fZO+SJ/inzEoQh6y3cF13LtsklT1mh+862F2jLFwWz2QhcrJ7wYrqwZ qQnXAJqSWbkpA== Received: by mail-ed1-f70.google.com with SMTP id r14-20020aa7da0e000000b004021fa39843so3753225eds.15 for ; Mon, 17 Jan 2022 07:00:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=P1t3TusiuWvEJQvj6KQ3UI4zLwE3rcF19O3O8iabinU=; b=OmO8FBXwiE79BBmOhRXcHxn0ysWj0lAoJoA8Nd9WkB0iE3DrZWsTn/eiESwUBDGZNR r2bIR48Bpo+cFZj08dGnxJ6zzAE5cBKzv3V5KFp30FkVyj9f7g3UWHI6N+7Ff21zFNP8 ofyckDVk6wMBAbi1PrtPK25uirni3xUGOxl3sFtKpDOz1lkT31rh+39+OO2GOaZkQPs9 M/9qB2w7VWLYaddnkZ+M4dJUMAXc8k4MPkbXmYE7hXn3J74Hj9a58gmESIpV+8pDqBTr l8GW+y0IfqQttW5AuCWlt/kav9akXW3aeGfd2/p4PQ1ID8vV8dlYmHQxLvWrrM3SUmYP 77jQ== X-Gm-Message-State: AOAM533/HpxLfcG1tqg+cWAvJ50kIvwhYqB+PGE4ydZGdstnutFOnn2U CvamCryurfbk8PVvVASMT5zXIInvtEIFJityfk7ldnGew57xmDCRFI/GGh4L3fPOfjaG3I5dyN8 7OXdks6RA1D4L+HbU5q2cxbXlviY08oNVzRQrlHHfSA== X-Received: by 2002:a17:906:8053:: with SMTP id x19mr11918936ejw.485.1642431646520; Mon, 17 Jan 2022 07:00:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJwi5fMBz8oaksx3ekbOg74TUZaXBrRwCj5lzvu6SsBncvDyD0ZOfpPjH3B+rGmVa8PY2miIKA== X-Received: by 2002:a17:906:8053:: with SMTP id x19mr11918904ejw.485.1642431646225; Mon, 17 Jan 2022 07:00:46 -0800 (PST) Received: from [192.168.0.39] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id bg20sm3958261ejb.59.2022.01.17.07.00.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jan 2022 07:00:45 -0800 (PST) Message-ID: <9b98fd89-87b5-5026-fb0c-16bb956801ea@canonical.com> Date: Mon, 17 Jan 2022 16:00:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH 13/23] dt-bindings: arm: add Tesla FSD ARM SoC Content-Language: en-US To: Arnd Bergmann , Alim Akhtar Cc: Linux ARM , Linux Kernel Mailing List , SoC Team , linux-clk , DTML , Olof Johansson , Linus Walleij , Catalin Marinas , Rob Herring , Sylwester Nawrocki , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Pankaj Dubey , linux-fsd@tesla.com References: <20220113121143.22280-1-alim.akhtar@samsung.com> <20220113121143.22280-14-alim.akhtar@samsung.com> <53c17ddc-a049-72ed-7237-de23db7889da@canonical.com> <085801d80967$e4b8fe00$ae2afa00$@samsung.com> <5ab62673-8d46-ec1d-1c80-696421ab69ca@canonical.com> <00c901d80ba5$c9ae6ab0$5d0b4010$@samsung.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/01/2022 15:14, Arnd Bergmann wrote: > On Mon, Jan 17, 2022 at 2:26 PM Alim Akhtar wrote: >> >>> I cannot judge how different this is from Exynos subarchitecture - looking at >>> patches it is not different - so I could understand a FSD sub-arch with only one >>> SoC. >>> >> I understand, it is a bit difficult to visualize it with the current patch set. >> As discuss on the other thread, FSD is different, more over the vendor is different, internal design is different. > > Is it based on another SoC design then? Most new SoCs are derived from > some other > one, so it makes sense to put it into the same family. E.g. the Apple > M1 takes bits from > both Exynos and PA-Semi SoCs but has more newly added components than > either one. It seems Apple M1 shares only few bits with SoC. I am aware of only UART driver as directly re-usable. > > I would argue that if this SoC shares the pinctrl, clock, spi, adc, > and timer implementation Plus: UART, watchdog, PWM, I2C, I2S, USB PHY, DWC3 USB (in Exynos flavor), UFS (also in Exynos-looking flavor), MFC (video codec), some similarities in DW PCIe, TMU (thermal). Looking at DTS there are differences but just few comparing to most of shared blocks. Additionally SoC BSP (and maybe SoC itself...) was actually developed or co-developed by Samsung, judging by copyrights in the BSP code. Even the original DTSI has: TURBO TRAV SoC device tree source Copyright (c) 2017 Samsung Electronics Co., Ltd. Tesla could still customize it a lot, but it is a strong hint that most of it came from Samsung LSI and shares with existing Samsung designs. Have in mind that recent Exynos chips are significantly different than early ARMv7 or ARMv8 designs and we still consider them part of Exynos family. > with Exynos, we should consider it part of the Exynos family, > regardless of what other > blocks may exist next to those. Yes. I don't see the benefit of keeping it outside of Exynos. It will sprinkle "depends on ARCH_EXYNOS || ARCH_FSD" all over (or depend on Exynos like you suggested). Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FD21C433F5 for ; Mon, 17 Jan 2022 15:04:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yLsRtg3u3rMbtoCOpI6sGZdP/crxTAIuRK8W7L0wvUw=; b=eck2N2gkPwOQeo 8Pzs7Vk0zNXDrUbuObGYZhSDV0M7LpP0f7fMtU+StWstEX2Uo1fPK/xJLyZJjfLMM5xKu+JIHBhdC vye2Mp2nvRlQnJ7Mf3+kjmXTt7K9FEqYCJq/GSakweCw+K/vFcONuhcgirIdCdlWVOncNxkP84eMC /Oo99NFE2Ep7dgzXeHXTOIKx9lB38hqclWMZnYvzHlkntgxjZXqEQBHv0Q3+xNDKN1MdKOEj/lUdw onRvjt7+K2BHYcYVQAsFM4pOzXGXsiOtQ0RkqlJDNEqisS+8RApfzabsTzO5e5s6GUNvAyudSkh3q /g8zgilaO7fFmZGIf6Lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9TWk-00FJJF-MC; Mon, 17 Jan 2022 15:02:37 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9TVA-00FIW3-5U for linux-arm-kernel@lists.infradead.org; Mon, 17 Jan 2022 15:00:57 +0000 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id D0B293F1C8 for ; Mon, 17 Jan 2022 15:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1642431646; bh=P1t3TusiuWvEJQvj6KQ3UI4zLwE3rcF19O3O8iabinU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S+hn/P/+ORd5yFuloev1kgWwDaFAaeiN7nXsJ/Qp+89KwtPN2IBixal8kgeBesRlT JuMKK4SrCzKujGFYUxxNKQOm0z40SXJhTOLhDq6j0VDJeJCpv8mH7761XWr1F55ZmH hJ6gp4DxAbO+DO2M4AqyUubDXzpV8h+tekH2Au09TTKSWGEiW3p+iDEQWOH4Oa52oQ Te3cUZi13alBYA2rH2c53+6rO+sWQgDlZw+xmz1+DhnLX3WgX7EiPopvGNz/ix18YE oGpKWMwnMk5fZO+SJ/inzEoQh6y3cF13LtsklT1mh+862F2jLFwWz2QhcrJ7wYrqwZ qQnXAJqSWbkpA== Received: by mail-ed1-f69.google.com with SMTP id bm21-20020a0564020b1500b00402c34373f9so2237186edb.2 for ; Mon, 17 Jan 2022 07:00:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=P1t3TusiuWvEJQvj6KQ3UI4zLwE3rcF19O3O8iabinU=; b=xzVs3HEBLeKHVA0ANsxLYqoaCx0h7aaNMMVWnBDPyi5BD5gRPcCqMttZzuSD9w4a4M GPUdJPWE2aoVnACXdYaf0fOMvJwIj21hLsOFSsyHsWv87lEmYyZdrHHA7+SCkco5+1zN tHtPr4FK5NWLSZ8EU+GuhSR+z3Khld8LFu196ziQZGzyEUGNKcqWKAcTr7S+1w1vbBYz S2PxkCn/mRWwOk+JPBmgdEAeexXJaAqlM0g9AyTuesSApyfpd2NYCS02AL7oG5UKrfy0 xma2T9kqwfuVCrs7meKoLh8EA609ly57Rz6m79Qi+RS4AqZnkZaTxIrg1VizV3EkgVlZ ThWA== X-Gm-Message-State: AOAM533b84CExQ16BEAl9PAwfi4cxDxwZuLr+auF4U/mMAoCEtwFVvhw EHiXkN0cfUHi2h3limwOFW0dybyDIPgyfHgucReKm+cNj5H9trTeaWwmc5L2aNKiA9df3/WbtnV 1jJN8h1U8Ob06odaJEwdY36bvPuJ1eTIUc/312R0vdGs45OtWPfTD X-Received: by 2002:a17:906:8053:: with SMTP id x19mr11918928ejw.485.1642431646496; Mon, 17 Jan 2022 07:00:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJwi5fMBz8oaksx3ekbOg74TUZaXBrRwCj5lzvu6SsBncvDyD0ZOfpPjH3B+rGmVa8PY2miIKA== X-Received: by 2002:a17:906:8053:: with SMTP id x19mr11918904ejw.485.1642431646225; Mon, 17 Jan 2022 07:00:46 -0800 (PST) Received: from [192.168.0.39] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id bg20sm3958261ejb.59.2022.01.17.07.00.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jan 2022 07:00:45 -0800 (PST) Message-ID: <9b98fd89-87b5-5026-fb0c-16bb956801ea@canonical.com> Date: Mon, 17 Jan 2022 16:00:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH 13/23] dt-bindings: arm: add Tesla FSD ARM SoC Content-Language: en-US To: Arnd Bergmann , Alim Akhtar Cc: Linux ARM , Linux Kernel Mailing List , SoC Team , linux-clk , DTML , Olof Johansson , Linus Walleij , Catalin Marinas , Rob Herring , Sylwester Nawrocki , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Pankaj Dubey , linux-fsd@tesla.com References: <20220113121143.22280-1-alim.akhtar@samsung.com> <20220113121143.22280-14-alim.akhtar@samsung.com> <53c17ddc-a049-72ed-7237-de23db7889da@canonical.com> <085801d80967$e4b8fe00$ae2afa00$@samsung.com> <5ab62673-8d46-ec1d-1c80-696421ab69ca@canonical.com> <00c901d80ba5$c9ae6ab0$5d0b4010$@samsung.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220117_070056_394845_899D238F X-CRM114-Status: GOOD ( 24.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/01/2022 15:14, Arnd Bergmann wrote: > On Mon, Jan 17, 2022 at 2:26 PM Alim Akhtar wrote: >> >>> I cannot judge how different this is from Exynos subarchitecture - looking at >>> patches it is not different - so I could understand a FSD sub-arch with only one >>> SoC. >>> >> I understand, it is a bit difficult to visualize it with the current patch set. >> As discuss on the other thread, FSD is different, more over the vendor is different, internal design is different. > > Is it based on another SoC design then? Most new SoCs are derived from > some other > one, so it makes sense to put it into the same family. E.g. the Apple > M1 takes bits from > both Exynos and PA-Semi SoCs but has more newly added components than > either one. It seems Apple M1 shares only few bits with SoC. I am aware of only UART driver as directly re-usable. > > I would argue that if this SoC shares the pinctrl, clock, spi, adc, > and timer implementation Plus: UART, watchdog, PWM, I2C, I2S, USB PHY, DWC3 USB (in Exynos flavor), UFS (also in Exynos-looking flavor), MFC (video codec), some similarities in DW PCIe, TMU (thermal). Looking at DTS there are differences but just few comparing to most of shared blocks. Additionally SoC BSP (and maybe SoC itself...) was actually developed or co-developed by Samsung, judging by copyrights in the BSP code. Even the original DTSI has: TURBO TRAV SoC device tree source Copyright (c) 2017 Samsung Electronics Co., Ltd. Tesla could still customize it a lot, but it is a strong hint that most of it came from Samsung LSI and shares with existing Samsung designs. Have in mind that recent Exynos chips are significantly different than early ARMv7 or ARMv8 designs and we still consider them part of Exynos family. > with Exynos, we should consider it part of the Exynos family, > regardless of what other > blocks may exist next to those. Yes. I don't see the benefit of keeping it outside of Exynos. It will sprinkle "depends on ARCH_EXYNOS || ARCH_FSD" all over (or depend on Exynos like you suggested). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel