RE: [PATCH] wifi: rtl8xxxu: enable MFP support - Ping-Ke Shih

From: Ping-Ke Shih <pkshih@realtek.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
	Martin Kaistra <martin.kaistra@linutronix.de>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Jes Sorensen <Jes.Sorensen@gmail.com>,
	Kalle Valo <kvalo@kernel.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: RE: [PATCH] wifi: rtl8xxxu: enable MFP support
Date: Mon, 15 Apr 2024 00:57:08 +0000	[thread overview]
Message-ID: <9ba097ae2db4418a9b95aa22f53f9367@realtek.com> (raw)
In-Reply-To: <fa903f58-2362-49a1-9880-2b3fcbe1869e@gmail.com>

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:

> > @@ -7998,6 +8002,7 @@ static int rtl8xxxu_probe(struct usb_interface *interface,
> >       ieee80211_hw_set(hw, HAS_RATE_CONTROL);
> >       ieee80211_hw_set(hw, SUPPORT_FAST_XMIT);
> >       ieee80211_hw_set(hw, AMPDU_AGGREGATION);
> > +     ieee80211_hw_set(hw, MFP_CAPABLE);
> >
> >       wiphy_ext_feature_set(hw->wiphy, NL80211_EXT_FEATURE_CQM_RSSI_LIST);
> >
> 
> I ran into this problem recently with rtl8192du:
> https://lore.kernel.org/linux-wireless/ed12ec17-ae6e-45fa-a72f-23e0a34654da@gmail.com/
> 
> Does the same fix work for you in rtl8xxxu? Checking the "security"
> field of the RX descriptor is simpler than calling two functions.
> Sorry to bother you when the patch is already applied.
> 
> Also, won't you send the patch to the stable tree?

I'm not aware of two patches did the similar thing. Thanks for pointing this. 

Martin, please check if you met the same problem as Bitterblue's one. If you
want to add this fix to stable tree, please provide two patches -- one is to
revert this patch, and an new one to add Bitterblue's method with Cc stable.

Ping-Ke 