From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Subject: Re: [PATCH 2/3] ARM64: DT: add video codec devicetree node
Date: Wed, 16 Aug 2017 17:31:47 +0300
Message-ID: <9ba128c6-8018-6307-448c-a7f9ea1400c6@linaro.org>
References: <20170612124317.29313-1-robdclark@gmail.com>
 <20170612124317.29313-2-robdclark@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from mail-wr0-f171.google.com ([209.85.128.171]:34854 "EHLO
        mail-wr0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751752AbdHPObu (ORCPT
        <rfc822;linux-arm-msm@vger.kernel.org>);
        Wed, 16 Aug 2017 10:31:50 -0400
Received: by mail-wr0-f171.google.com with SMTP id 49so9110001wrw.2
        for <linux-arm-msm@vger.kernel.org>; Wed, 16 Aug 2017 07:31:50 -0700 (PDT)
In-Reply-To: <20170612124317.29313-2-robdclark@gmail.com>
Content-Language: en-US
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Rob Clark <robdclark@gmail.com>, linux-arm-msm@vger.kernel.org, Andy Gross <agross@codeaurora.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>, Stanimir Varbanov <stanimir.varbanov@linaro.org>

Hi Rob, Andy,

On 06/12/2017 03:43 PM, Rob Clark wrote:
> From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> 
> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> Signed-off-by: Rob Clark <robdclark@gmail.com>
> ---
>  arch/arm64/boot/dts/qcom/msm8916.dtsi | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 24c24ab..1dcd632 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -88,6 +88,13 @@
>  			no-map;
>  		};
>  
> +		venus_mem: venus@89900000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0x0 0x89900000 0x0 0x800000>;
> +			alignment = <0x1000>;
> +			no-map;
> +		};

In the spirit of 377a22d3caec3d2cda0cc996101121145ac43ff2 "media: venus:
don't abuse dma_alloc for non-DMA allocations" commit the above
venus_mem should be changed to:

		venus_mem: venus@89900000 {
			reg = <0x0 0x89900000 0x0 0x600000>;
			no-map;
		};

> +
>  		mba_mem: mba@8ea00000 {
>  			no-map;
>  			reg = <0 0x8ea00000 0 0x100000>;
> @@ -1214,6 +1221,27 @@
>  				};
>  			};
>  		};
> +
> +		venus: video-codec@1d00000 {
> +			compatible = "qcom,msm8916-venus";
> +			reg = <0x01d00000 0xff000>;
> +			interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
> +			power-domains = <&gcc VENUS_GDSC>;
> +			clocks = <&gcc GCC_VENUS0_VCODEC0_CLK>,
> +				 <&gcc GCC_VENUS0_AHB_CLK>,
> +				 <&gcc GCC_VENUS0_AXI_CLK>;
> +			clock-names = "core", "iface", "bus";
> +			memory-region = <&venus_mem>;
> +			status = "okay";

Is that correct, shouldn't the status be disabled and enabled in the
board dts(i) files?

> +
> +			video-decoder {
> +				compatible = "venus-decoder";
> +			};
> +
> +			video-encoder {
> +				compatible = "venus-encoder";
> +			};
> +		};
>  	};
>  
>  	smd {
> 

-- 
regards,
Stan