From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AB35C04EBD for ; Tue, 16 Oct 2018 10:26:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D10D42083C for ; Tue, 16 Oct 2018 10:26:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D10D42083C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727064AbeJPSQ1 (ORCPT ); Tue, 16 Oct 2018 14:16:27 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:41692 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726165AbeJPSQ1 (ORCPT ); Tue, 16 Oct 2018 14:16:27 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 0233EFF506AF1; Tue, 16 Oct 2018 18:26:39 +0800 (CST) Received: from [127.0.0.1] (10.177.31.14) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.399.0; Tue, 16 Oct 2018 18:26:35 +0800 Subject: Re: [PATCH] jffs2: free jffs2_sb_info through jffs2_kill_sb() To: Richard Weinberger CC: "linux-mtd @ lists . infradead . org" , LKML , David Woodhouse , , Arnd Bergmann , Al Viro , Brian Norris References: <20181006090935.41714-1-houtao1@huawei.com> <6401cb90-a1fe-afd5-c302-ddae40876736@huawei.com> From: Hou Tao Message-ID: <9bb38d45-41c7-9f16-bf6b-d21ba6617f1c@huawei.com> Date: Tue, 16 Oct 2018 18:26:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.31.14] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/10/16 14:41, Richard Weinberger wrote: > On Tue, Oct 16, 2018 at 7:53 AM Hou Tao wrote: >> >> ping ? >> >> On 2018/10/6 17:09, Hou Tao wrote: >>> When an invalid mount option is passed to jffs2, jffs2_parse_options() >>> will fail and jffs2_sb_info will be freed, but then jffs2_sb_info will >>> be used (use-after-free) and freeed (double-free) in jffs2_kill_sb(). >>> >>> Fix it by removing the buggy invocation of kfree() when getting invalid >>> mount options. >>> >>> Cc: stable@kernel.org >>> Signed-off-by: Hou Tao >>> --- >>> fs/jffs2/super.c | 4 +--- >>> 1 file changed, 1 insertion(+), 3 deletions(-) >>> >>> diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c >>> index 87bdf0f4cba1..902a7dd10e5c 100644 >>> --- a/fs/jffs2/super.c >>> +++ b/fs/jffs2/super.c >>> @@ -285,10 +285,8 @@ static int jffs2_fill_super(struct super_block *sb, void *data, int silent) >>> sb->s_fs_info = c; >>> >>> ret = jffs2_parse_options(c, data); >>> - if (ret) { >>> - kfree(c); >>> + if (ret) >>> return -EINVAL; >>> - } > > Reviewed-by: Richard Weinberger > > We can carry this via the MTD tree. Thanks for that. Regards, Tao