All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Srba <Michael.Srba@seznam.cz>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 3/3] arm64: dts: update device trees to specify clock-frequency in imx219 node
Date: Sun, 6 Dec 2020 18:20:26 +0100	[thread overview]
Message-ID: <9bba5765-667c-7a9f-4fc1-0b189375daaf@seznam.cz> (raw)
In-Reply-To: <CAMuHMdXO4p_uckdA=hysACxgJqdM=tL0MMz95N=F3_Wa=3XV+w@mail.gmail.com>


> Hi Michael,
>
> On Sat, Dec 5, 2020 at 7:36 PM <michael.srba@seznam.cz> wrote:
>> From: Michael Srba <Michael.Srba@seznam.cz>
>>
>> This patch adds the clock-frequency property to all device trees that use
>> the imx219 binding, with the value of exactly 24Mhz which was previously
>> implicitly assumed.
>>
>> Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
> Thanks for your patch!
>
>> --- a/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi
>> @@ -82,6 +82,7 @@ imx219: imx219@10 {
>>                 compatible = "sony,imx219";
>>                 reg = <0x10>;
>>                 clocks = <&osc25250_clk>;
>> +               clock-frequency = <24000000>;
>>                 VANA-supply = <&imx219_vana_2v8>;
>>                 VDIG-supply = <&imx219_vdig_1v8>;
>>                 VDDL-supply = <&imx219_vddl_1v2>;
>> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
>> index f0829e905506..db4b801b17b5 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
>> @@ -59,6 +59,7 @@ &imx219 {
>>         port {
>>                 imx219_ep: endpoint {
>>                         clock-lanes = <0>;
>> +                       clock-frequency = <24000000>;
> Why is this change needed? This is not the imx219 node, but its endpoint
> subnode (the imx219 is imported from aistarvision-mipi-adapter-2.1.dtsi).
My bad, I must have been really tired.
will rectify this

>>                         data-lanes = <1 2>;
>>                         link-frequencies = /bits/ 64 <456000000>;
>>                         /* uncomment remote-endpoint property to tie imx219 to
> -
> Gr{oetje,eeting}s,
>
>                         Geert
>
Michael

WARNING: multiple messages have this Message-ID
From: Michael Srba <Michael.Srba@seznam.cz>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Fabio Estevam <festevam@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Magnus Damm <magnus.damm@gmail.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH 3/3] arm64: dts: update device trees to specify clock-frequency in imx219 node
Date: Sun, 6 Dec 2020 18:20:26 +0100	[thread overview]
Message-ID: <9bba5765-667c-7a9f-4fc1-0b189375daaf@seznam.cz> (raw)
In-Reply-To: <CAMuHMdXO4p_uckdA=hysACxgJqdM=tL0MMz95N=F3_Wa=3XV+w@mail.gmail.com>


> Hi Michael,
>
> On Sat, Dec 5, 2020 at 7:36 PM <michael.srba@seznam.cz> wrote:
>> From: Michael Srba <Michael.Srba@seznam.cz>
>>
>> This patch adds the clock-frequency property to all device trees that use
>> the imx219 binding, with the value of exactly 24Mhz which was previously
>> implicitly assumed.
>>
>> Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
> Thanks for your patch!
>
>> --- a/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi
>> @@ -82,6 +82,7 @@ imx219: imx219@10 {
>>                 compatible = "sony,imx219";
>>                 reg = <0x10>;
>>                 clocks = <&osc25250_clk>;
>> +               clock-frequency = <24000000>;
>>                 VANA-supply = <&imx219_vana_2v8>;
>>                 VDIG-supply = <&imx219_vdig_1v8>;
>>                 VDDL-supply = <&imx219_vddl_1v2>;
>> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
>> index f0829e905506..db4b801b17b5 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
>> @@ -59,6 +59,7 @@ &imx219 {
>>         port {
>>                 imx219_ep: endpoint {
>>                         clock-lanes = <0>;
>> +                       clock-frequency = <24000000>;
> Why is this change needed? This is not the imx219 node, but its endpoint
> subnode (the imx219 is imported from aistarvision-mipi-adapter-2.1.dtsi).
My bad, I must have been really tired.
will rectify this

>>                         data-lanes = <1 2>;
>>                         link-frequencies = /bits/ 64 <456000000>;
>>                         /* uncomment remote-endpoint property to tie imx219 to
> -
> Gr{oetje,eeting}s,
>
>                         Geert
>
Michael

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-12-06 17:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-05 18:33 [PATCH 1/3] media: i2c: imx219: add support for specifying clock-frequencies michael.srba
2020-12-05 18:33 ` michael.srba
2020-12-05 18:33 ` [PATCH 2/3] media: dt-bindings: media: i2c: imx219: document clock-frequency property michael.srba
2020-12-05 18:33   ` michael.srba
2020-12-07  9:46   ` Krzysztof Kozlowski
2020-12-07  9:46     ` Krzysztof Kozlowski
2020-12-05 18:33 ` [PATCH 3/3] arm64: dts: update device trees to specify clock-frequency in imx219 node michael.srba
2020-12-05 18:33   ` michael.srba
2020-12-05 18:55   ` Geert Uytterhoeven
2020-12-05 18:55     ` Geert Uytterhoeven
2020-12-06 17:20     ` Michael Srba [this message]
2020-12-06 17:20       ` Michael Srba
2020-12-05 18:54 ` [PATCH 1/3] media: i2c: imx219: add support for specifying clock-frequencies Geert Uytterhoeven
2020-12-05 18:54   ` Geert Uytterhoeven
2020-12-06 17:18   ` Michael Srba
2020-12-06 17:18     ` Michael Srba
2020-12-07  9:44 ` Krzysztof Kozlowski
2020-12-07  9:44   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bba5765-667c-7a9f-4fc1-0b189375daaf@seznam.cz \
    --to=michael.srba@seznam.cz \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --subject='Re: [PATCH 3/3] arm64: dts: update device trees to specify clock-frequency in imx219 node' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.