From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B70FC4361B for ; Sun, 6 Dec 2020 17:21:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE9E92224C for ; Sun, 6 Dec 2020 17:21:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726318AbgLFRV2 (ORCPT ); Sun, 6 Dec 2020 12:21:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726043AbgLFRV2 (ORCPT ); Sun, 6 Dec 2020 12:21:28 -0500 Received: from mxf2.seznam.cz (mxf2.seznam.cz [IPv6:2a02:598:2::123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1B04C0613D1; Sun, 6 Dec 2020 09:20:42 -0800 (PST) Received: from email.seznam.cz by email-smtpc20b.ng.seznam.cz (email-smtpc20b.ng.seznam.cz [10.23.18.25]) id 25cda0067ec3f46f24646c58; Sun, 06 Dec 2020 18:20:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seznam.cz; s=beta; t=1607275229; bh=Xa+1KZEu4DSBX1VK7gEW8PMltXYhhx/+mEhX6AFrfn4=; h=Received:Subject:To:Cc:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding: Content-Language; b=YpF7fa2AANOlMA/VsPXkgD8TOQQrKbVodF/5V8dF8XmoO1IZzwKukHDBnv/+c3MzH ilyQRFf3kySSzTR9zY1BZOJexm6d8M/3FSn4BG8QAKLo6C/9OeTrpzDp3h/D0BBpf3 8MDi2GCLKCW2wvBVEoG9APt4V2FFpPVr3OFTii5A= Received: from [192.168.1.213] (ip-228-128.dynamic.ccinternet.cz [212.69.128.228]) by email-relay17.ng.seznam.cz (Seznam SMTPD 1.3.122) with ESMTP; Sun, 06 Dec 2020 18:20:27 +0100 (CET) Subject: Re: [PATCH 3/3] arm64: dts: update device trees to specify clock-frequency in imx219 node To: Geert Uytterhoeven Cc: Dave Stevenson , Mauro Carvalho Chehab , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Geert Uytterhoeven , Magnus Damm , Linux Media Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , Linux-Renesas References: <20201205183355.6488-1-michael.srba@seznam.cz> <20201205183355.6488-3-michael.srba@seznam.cz> From: Michael Srba Message-ID: <9bba5765-667c-7a9f-4fc1-0b189375daaf@seznam.cz> Date: Sun, 6 Dec 2020 18:20:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > Hi Michael, > > On Sat, Dec 5, 2020 at 7:36 PM wrote: >> From: Michael Srba >> >> This patch adds the clock-frequency property to all device trees that use >> the imx219 binding, with the value of exactly 24Mhz which was previously >> implicitly assumed. >> >> Signed-off-by: Michael Srba > Thanks for your patch! > >> --- a/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi >> +++ b/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi >> @@ -82,6 +82,7 @@ imx219: imx219@10 { >> compatible = "sony,imx219"; >> reg = <0x10>; >> clocks = <&osc25250_clk>; >> + clock-frequency = <24000000>; >> VANA-supply = <&imx219_vana_2v8>; >> VDIG-supply = <&imx219_vdig_1v8>; >> VDDL-supply = <&imx219_vddl_1v2>; >> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts >> index f0829e905506..db4b801b17b5 100644 >> --- a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts >> @@ -59,6 +59,7 @@ &imx219 { >> port { >> imx219_ep: endpoint { >> clock-lanes = <0>; >> + clock-frequency = <24000000>; > Why is this change needed? This is not the imx219 node, but its endpoint > subnode (the imx219 is imported from aistarvision-mipi-adapter-2.1.dtsi). My bad, I must have been really tired. will rectify this >> data-lanes = <1 2>; >> link-frequencies = /bits/ 64 <456000000>; >> /* uncomment remote-endpoint property to tie imx219 to > - > Gr{oetje,eeting}s, > > Geert > Michael From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DD15C433FE for ; Sun, 6 Dec 2020 17:21:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEC822224C for ; Sun, 6 Dec 2020 17:21:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEC822224C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=seznam.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VLOf77972A3Sc9tUCe+MfyngAHse2GQAM1PLAkCdInM=; b=n33bggcvPMCjJi37LdCrfYqdc E/W9qzqs1FItO42gm6oHaMuZz05ubvM2qNuySa6mo8mZL3wTQ9CHERXsoMNzTQt+ItoqDFo86stMe 59dlp0GIPDvNt5+SJmmLIKYOHAVc1fFaR0wc+Cx5VfhS4xXQqa7k5zz+kR/IqaHmGGB0R0pJZi8lk pWXtbJ3j514LtXaGYQ3bEtl07HRVd+/O5JJaDk5woPdRLeZ8LljLJMdKzPhXotwmXpyS15wWbmlPW fmmFWVDFKbZrQiFtMIdNaEtmKAiV2Ewbe/8SB6XuH1jlgbNbamyvCpNzGrrm1Bwu/+YIDDMWidcc6 PmLKW7/rQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1klxiD-0008HF-AB; Sun, 06 Dec 2020 17:20:41 +0000 Received: from mxf2.seznam.cz ([2a02:598:2::123]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1klxi9-0008GV-S5 for linux-arm-kernel@lists.infradead.org; Sun, 06 Dec 2020 17:20:38 +0000 Received: from email.seznam.cz by email-smtpc20b.ng.seznam.cz (email-smtpc20b.ng.seznam.cz [10.23.18.25]) id 25cda0067ec3f46f24646c58; Sun, 06 Dec 2020 18:20:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seznam.cz; s=beta; t=1607275229; bh=Xa+1KZEu4DSBX1VK7gEW8PMltXYhhx/+mEhX6AFrfn4=; h=Received:Subject:To:Cc:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding: Content-Language; b=YpF7fa2AANOlMA/VsPXkgD8TOQQrKbVodF/5V8dF8XmoO1IZzwKukHDBnv/+c3MzH ilyQRFf3kySSzTR9zY1BZOJexm6d8M/3FSn4BG8QAKLo6C/9OeTrpzDp3h/D0BBpf3 8MDi2GCLKCW2wvBVEoG9APt4V2FFpPVr3OFTii5A= Received: from [192.168.1.213] (ip-228-128.dynamic.ccinternet.cz [212.69.128.228]) by email-relay17.ng.seznam.cz (Seznam SMTPD 1.3.122) with ESMTP; Sun, 06 Dec 2020 18:20:27 +0100 (CET) Subject: Re: [PATCH 3/3] arm64: dts: update device trees to specify clock-frequency in imx219 node To: Geert Uytterhoeven References: <20201205183355.6488-1-michael.srba@seznam.cz> <20201205183355.6488-3-michael.srba@seznam.cz> From: Michael Srba Message-ID: <9bba5765-667c-7a9f-4fc1-0b189375daaf@seznam.cz> Date: Sun, 6 Dec 2020 18:20:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201206_122038_044800_34D9812F X-CRM114-Status: GOOD ( 17.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Geert Uytterhoeven , Dave Stevenson , Fabio Estevam , Sascha Hauer , Magnus Damm , Linux-Renesas , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Mauro Carvalho Chehab , Shawn Guo , Linux ARM , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Hi Michael, > > On Sat, Dec 5, 2020 at 7:36 PM wrote: >> From: Michael Srba >> >> This patch adds the clock-frequency property to all device trees that use >> the imx219 binding, with the value of exactly 24Mhz which was previously >> implicitly assumed. >> >> Signed-off-by: Michael Srba > Thanks for your patch! > >> --- a/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi >> +++ b/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi >> @@ -82,6 +82,7 @@ imx219: imx219@10 { >> compatible = "sony,imx219"; >> reg = <0x10>; >> clocks = <&osc25250_clk>; >> + clock-frequency = <24000000>; >> VANA-supply = <&imx219_vana_2v8>; >> VDIG-supply = <&imx219_vdig_1v8>; >> VDDL-supply = <&imx219_vddl_1v2>; >> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts >> index f0829e905506..db4b801b17b5 100644 >> --- a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts >> @@ -59,6 +59,7 @@ &imx219 { >> port { >> imx219_ep: endpoint { >> clock-lanes = <0>; >> + clock-frequency = <24000000>; > Why is this change needed? This is not the imx219 node, but its endpoint > subnode (the imx219 is imported from aistarvision-mipi-adapter-2.1.dtsi). My bad, I must have been really tired. will rectify this >> data-lanes = <1 2>; >> link-frequencies = /bits/ 64 <456000000>; >> /* uncomment remote-endpoint property to tie imx219 to > - > Gr{oetje,eeting}s, > > Geert > Michael _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel