From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E1C9A364A4; Mon, 18 Mar 2024 11:22:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710760966; cv=none; b=I7UaZ5QhvLQvzuulGwwlwPTVJcmhmwo2mOLbxXFT5laFi9LR4Ni2T90SAylIonVjRyZPcYbIhRAXUNxIirqUqP39DzmlXn35CdbcURnqdGrYmmp3rHSDOu+i0WHaekZMlR+Cy0WZZSg1lKRjaZtlzDmLmIsYcLntm3Oo2NJp2hE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710760966; c=relaxed/simple; bh=/XlGRfj+bypUxiL/nVJQfK2Y04gmJmgRzWZLHLYUIPM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n4Razs/J/d4ZHPN03+cXz7kNICTlvS0t8CKdlHcBABNqqNBQYUGB5zmNZjA0ouZrBnZBUArmfq1BnozlDlOp+pqiAahWt8eMg7OdvrEMa2ae9BL9kVCit3yJxYLAPjI4Oicdq5FGsmkb4UctqHrfLmDan8oPmSkRTsB2ValOwbM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3E50C106F; Mon, 18 Mar 2024 04:23:19 -0700 (PDT) Received: from [10.57.12.69] (unknown [10.57.12.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DD3383F7CE; Mon, 18 Mar 2024 04:22:40 -0700 (PDT) Message-ID: <9bd6668c-17c9-4fdf-ad06-3fd41814ba28@arm.com> Date: Mon, 18 Mar 2024 11:22:41 +0000 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 04/28] arm64: RME: Check for RME support at KVM init Content-Language: en-GB To: Ganapatrao Kulkarni , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev References: <20230127112248.136810-1-suzuki.poulose@arm.com> <20230127112932.38045-1-steven.price@arm.com> <20230127112932.38045-5-steven.price@arm.com> From: Steven Price In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 18/03/2024 07:17, Ganapatrao Kulkarni wrote: > > > On 27-01-2023 04:59 pm, Steven Price wrote: >> Query the RMI version number and check if it is a compatible version. A >> static key is also provided to signal that a supported RMM is available. >> >> Functions are provided to query if a VM or VCPU is a realm (or rec) >> which currently will always return false. >> >> Signed-off-by: Steven Price >> --- >>   arch/arm64/include/asm/kvm_emulate.h | 17 ++++++++++ >>   arch/arm64/include/asm/kvm_host.h    |  4 +++ >>   arch/arm64/include/asm/kvm_rme.h     | 22 +++++++++++++ >>   arch/arm64/include/asm/virt.h        |  1 + >>   arch/arm64/kvm/Makefile              |  3 +- >>   arch/arm64/kvm/arm.c                 |  8 +++++ >>   arch/arm64/kvm/rme.c                 | 49 ++++++++++++++++++++++++++++ >>   7 files changed, 103 insertions(+), 1 deletion(-) >>   create mode 100644 arch/arm64/include/asm/kvm_rme.h >>   create mode 100644 arch/arm64/kvm/rme.c >> [...] >> diff --git a/arch/arm64/kvm/rme.c b/arch/arm64/kvm/rme.c >> new file mode 100644 >> index 000000000000..f6b587bc116e >> --- /dev/null >> +++ b/arch/arm64/kvm/rme.c >> @@ -0,0 +1,49 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Copyright (C) 2023 ARM Ltd. >> + */ >> + >> +#include >> + >> +#include >> +#include >> + >> +static int rmi_check_version(void) >> +{ >> +    struct arm_smccc_res res; >> +    int version_major, version_minor; >> + >> +    arm_smccc_1_1_invoke(SMC_RMI_VERSION, &res); >> + >> +    if (res.a0 == SMCCC_RET_NOT_SUPPORTED) >> +        return -ENXIO; >> + >> +    version_major = RMI_ABI_VERSION_GET_MAJOR(res.a0); >> +    version_minor = RMI_ABI_VERSION_GET_MINOR(res.a0); >> + >> +    if (version_major != RMI_ABI_MAJOR_VERSION) { >> +        kvm_err("Unsupported RMI ABI (version %d.%d) we support %d\n", > > Can we please replace "we support" to host supports. > Also in the patch present in the repo, you are using variable > our_version, can this be changed to host_version? Sure, I do have a bad habit using "we" - thanks for point it out. Steve >> +            version_major, version_minor, >> +            RMI_ABI_MAJOR_VERSION); >> +        return -ENXIO; >> +    } >> + >> +    kvm_info("RMI ABI version %d.%d\n", version_major, version_minor); >> + >> +    return 0; >> +} >> + >> +int kvm_init_rme(void) >> +{ >> +    if (PAGE_SIZE != SZ_4K) >> +        /* Only 4k page size on the host is supported */ >> +        return 0; >> + >> +    if (rmi_check_version()) >> +        /* Continue without realm support */ >> +        return 0; >> + >> +    /* Future patch will enable static branch kvm_rme_is_available */ >> + >> +    return 0; >> +} > > Thanks, > Ganapat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AEC6C54E5D for ; Mon, 18 Mar 2024 11:23:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e5B5iIcJLWlbSEETNA2bnD1xGmKo9ZVeeEH1ap7RLxM=; b=D30E4SB6sWSuaw Ibtmcm26aD8nDcFTynhT1FCEkTq2LKvQXfw6UcGYrHeQeDucz5IkqCl2WOt7OmJ3aBL2xEPTFRQX+ lYpmP4oXWB+07hGKAyDLCZ4RVyLnxx7c/hf+DIbSsUMkWjNNlXNVmU98BsXowssPHBjvkyVGJ15zX cY/HK+WkKjm01zak2MQbYDhwuPbK2HC1qabyObNaqMNvLSAHvUl/uahaDj2e2z1GmnhikD2njDNw3 k0mEwxpeqr2voiYwgoQMTO9cskgCvdG8M9FHiLs7wJtgF85r3OT7Q+91fOuv8eQFysfST05jInv3c NX+Kowj5gv9yWXV8QqYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmB4u-00000008LFi-42YN; Mon, 18 Mar 2024 11:22:52 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmB4p-00000008LCN-2UI5 for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2024 11:22:49 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3E50C106F; Mon, 18 Mar 2024 04:23:19 -0700 (PDT) Received: from [10.57.12.69] (unknown [10.57.12.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DD3383F7CE; Mon, 18 Mar 2024 04:22:40 -0700 (PDT) Message-ID: <9bd6668c-17c9-4fdf-ad06-3fd41814ba28@arm.com> Date: Mon, 18 Mar 2024 11:22:41 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 04/28] arm64: RME: Check for RME support at KVM init Content-Language: en-GB To: Ganapatrao Kulkarni , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev References: <20230127112248.136810-1-suzuki.poulose@arm.com> <20230127112932.38045-1-steven.price@arm.com> <20230127112932.38045-5-steven.price@arm.com> From: Steven Price In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240318_042248_105620_CD3728A7 X-CRM114-Status: GOOD ( 20.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTgvMDMvMjAyNCAwNzoxNywgR2FuYXBhdHJhbyBLdWxrYXJuaSB3cm90ZToKPiAKPiAKPiBP biAyNy0wMS0yMDIzIDA0OjU5IHBtLCBTdGV2ZW4gUHJpY2Ugd3JvdGU6Cj4+IFF1ZXJ5IHRoZSBS TUkgdmVyc2lvbiBudW1iZXIgYW5kIGNoZWNrIGlmIGl0IGlzIGEgY29tcGF0aWJsZSB2ZXJzaW9u LiBBCj4+IHN0YXRpYyBrZXkgaXMgYWxzbyBwcm92aWRlZCB0byBzaWduYWwgdGhhdCBhIHN1cHBv cnRlZCBSTU0gaXMgYXZhaWxhYmxlLgo+Pgo+PiBGdW5jdGlvbnMgYXJlIHByb3ZpZGVkIHRvIHF1 ZXJ5IGlmIGEgVk0gb3IgVkNQVSBpcyBhIHJlYWxtIChvciByZWMpCj4+IHdoaWNoIGN1cnJlbnRs eSB3aWxsIGFsd2F5cyByZXR1cm4gZmFsc2UuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IFN0ZXZlbiBQ cmljZSA8c3RldmVuLnByaWNlQGFybS5jb20+Cj4+IC0tLQo+PiDCoCBhcmNoL2FybTY0L2luY2x1 ZGUvYXNtL2t2bV9lbXVsYXRlLmggfCAxNyArKysrKysrKysrCj4+IMKgIGFyY2gvYXJtNjQvaW5j bHVkZS9hc20va3ZtX2hvc3QuaMKgwqDCoCB8wqAgNCArKysKPj4gwqAgYXJjaC9hcm02NC9pbmNs dWRlL2FzbS9rdm1fcm1lLmjCoMKgwqDCoCB8IDIyICsrKysrKysrKysrKysKPj4gwqAgYXJjaC9h cm02NC9pbmNsdWRlL2FzbS92aXJ0LmjCoMKgwqDCoMKgwqDCoCB8wqAgMSArCj4+IMKgIGFyY2gv YXJtNjQva3ZtL01ha2VmaWxlwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfMKgIDMgKy0KPj4g wqAgYXJjaC9hcm02NC9rdm0vYXJtLmPCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8 wqAgOCArKysrKwo+PiDCoCBhcmNoL2FybTY0L2t2bS9ybWUuY8KgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIHwgNDkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+PiDCoCA3IGZp bGVzIGNoYW5nZWQsIDEwMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4+IMKgIGNyZWF0 ZSBtb2RlIDEwMDY0NCBhcmNoL2FybTY0L2luY2x1ZGUvYXNtL2t2bV9ybWUuaAo+PiDCoCBjcmVh dGUgbW9kZSAxMDA2NDQgYXJjaC9hcm02NC9rdm0vcm1lLmMKPj4KClsuLi5dCgo+PiBkaWZmIC0t Z2l0IGEvYXJjaC9hcm02NC9rdm0vcm1lLmMgYi9hcmNoL2FybTY0L2t2bS9ybWUuYwo+PiBuZXcg ZmlsZSBtb2RlIDEwMDY0NAo+PiBpbmRleCAwMDAwMDAwMDAwMDAuLmY2YjU4N2JjMTE2ZQo+PiAt LS0gL2Rldi9udWxsCj4+ICsrKyBiL2FyY2gvYXJtNjQva3ZtL3JtZS5jCj4+IEBAIC0wLDAgKzEs NDkgQEAKPj4gKy8vIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4wCj4+ICsvKgo+PiAr ICogQ29weXJpZ2h0IChDKSAyMDIzIEFSTSBMdGQuCj4+ICsgKi8KPj4gKwo+PiArI2luY2x1ZGUg PGxpbnV4L2t2bV9ob3N0Lmg+Cj4+ICsKPj4gKyNpbmNsdWRlIDxhc20vcm1pX2NtZHMuaD4KPj4g KyNpbmNsdWRlIDxhc20vdmlydC5oPgo+PiArCj4+ICtzdGF0aWMgaW50IHJtaV9jaGVja192ZXJz aW9uKHZvaWQpCj4+ICt7Cj4+ICvCoMKgwqAgc3RydWN0IGFybV9zbWNjY19yZXMgcmVzOwo+PiAr wqDCoMKgIGludCB2ZXJzaW9uX21ham9yLCB2ZXJzaW9uX21pbm9yOwo+PiArCj4+ICvCoMKgwqAg YXJtX3NtY2NjXzFfMV9pbnZva2UoU01DX1JNSV9WRVJTSU9OLCAmcmVzKTsKPj4gKwo+PiArwqDC oMKgIGlmIChyZXMuYTAgPT0gU01DQ0NfUkVUX05PVF9TVVBQT1JURUQpCj4+ICvCoMKgwqDCoMKg wqDCoCByZXR1cm4gLUVOWElPOwo+PiArCj4+ICvCoMKgwqAgdmVyc2lvbl9tYWpvciA9IFJNSV9B QklfVkVSU0lPTl9HRVRfTUFKT1IocmVzLmEwKTsKPj4gK8KgwqDCoCB2ZXJzaW9uX21pbm9yID0g Uk1JX0FCSV9WRVJTSU9OX0dFVF9NSU5PUihyZXMuYTApOwo+PiArCj4+ICvCoMKgwqAgaWYgKHZl cnNpb25fbWFqb3IgIT0gUk1JX0FCSV9NQUpPUl9WRVJTSU9OKSB7Cj4+ICvCoMKgwqDCoMKgwqDC oCBrdm1fZXJyKCJVbnN1cHBvcnRlZCBSTUkgQUJJICh2ZXJzaW9uICVkLiVkKSB3ZSBzdXBwb3J0 ICVkXG4iLAo+IAo+IENhbiB3ZSBwbGVhc2UgcmVwbGFjZSAid2Ugc3VwcG9ydCIgdG8gaG9zdCBz dXBwb3J0cy4KPiBBbHNvIGluIHRoZSBwYXRjaCBwcmVzZW50IGluIHRoZSByZXBvLCB5b3UgYXJl IHVzaW5nIHZhcmlhYmxlCj4gb3VyX3ZlcnNpb24sIGNhbiB0aGlzIGJlIGNoYW5nZWQgdG8gaG9z dF92ZXJzaW9uPwoKU3VyZSwgSSBkbyBoYXZlIGEgYmFkIGhhYml0IHVzaW5nICJ3ZSIgLSB0aGFu a3MgZm9yIHBvaW50IGl0IG91dC4KClN0ZXZlCgo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB2 ZXJzaW9uX21ham9yLCB2ZXJzaW9uX21pbm9yLAo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBS TUlfQUJJX01BSk9SX1ZFUlNJT04pOwo+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FTlhJTzsK Pj4gK8KgwqDCoCB9Cj4+ICsKPj4gK8KgwqDCoCBrdm1faW5mbygiUk1JIEFCSSB2ZXJzaW9uICVk LiVkXG4iLCB2ZXJzaW9uX21ham9yLCB2ZXJzaW9uX21pbm9yKTsKPj4gKwo+PiArwqDCoMKgIHJl dHVybiAwOwo+PiArfQo+PiArCj4+ICtpbnQga3ZtX2luaXRfcm1lKHZvaWQpCj4+ICt7Cj4+ICvC oMKgwqAgaWYgKFBBR0VfU0laRSAhPSBTWl80SykKPj4gK8KgwqDCoMKgwqDCoMKgIC8qIE9ubHkg NGsgcGFnZSBzaXplIG9uIHRoZSBob3N0IGlzIHN1cHBvcnRlZCAqLwo+PiArwqDCoMKgwqDCoMKg wqAgcmV0dXJuIDA7Cj4+ICsKPj4gK8KgwqDCoCBpZiAocm1pX2NoZWNrX3ZlcnNpb24oKSkKPj4g K8KgwqDCoMKgwqDCoMKgIC8qIENvbnRpbnVlIHdpdGhvdXQgcmVhbG0gc3VwcG9ydCAqLwo+PiAr wqDCoMKgwqDCoMKgwqAgcmV0dXJuIDA7Cj4+ICsKPj4gK8KgwqDCoCAvKiBGdXR1cmUgcGF0Y2gg d2lsbCBlbmFibGUgc3RhdGljIGJyYW5jaCBrdm1fcm1lX2lzX2F2YWlsYWJsZSAqLwo+PiArCj4+ ICvCoMKgwqAgcmV0dXJuIDA7Cj4+ICt9Cj4gCj4gVGhhbmtzLAo+IEdhbmFwYXQKCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==