From: Andrew Cooper <amc96@srcf.net>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH v2 2/3] tools/libs/gnttab: decouple more from mini-os
Date: Wed, 12 Jan 2022 08:34:16 +0000 [thread overview]
Message-ID: <9be0e9b7-c382-1643-92e6-be320fda37d9@srcf.net> (raw)
In-Reply-To: <6e7dbf91-8c0e-900a-dacc-5afa36b6261d@suse.com>
On 12/01/2022 07:27, Juergen Gross wrote:
> On 11.01.22 21:08, Andrew Cooper wrote:
>
>> The least bad way I can think of doing this would be to leave void
>> minios_gnttab_close_fd(int fd) exactly as it was, and instead of
>> converting it's use here, use a separate static function straight away
>> for the file ops. (Will be necessary anyway if you like my suggestion
>> of passing file too). Then in the whole function in "tools/libs: final
>> cleanup making mini-os callbacks static", rather than just making it
>> static.
>
> I can change it if you really want.
Well, it will happen as a natural side effect of passing file* rather
than fd, but I do think it is a safer course of action.
~Andrew
next prev parent reply other threads:[~2022-01-12 8:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 15:03 [PATCH v2 0/3] tools/libs: decouple more from mini-os Juergen Gross
2022-01-11 15:03 ` [PATCH v2 1/3] tools/libs/evtchn: " Juergen Gross
2022-01-11 19:56 ` Andrew Cooper
2022-01-12 7:22 ` Juergen Gross
2022-01-12 13:21 ` Juergen Gross
2022-01-11 15:03 ` [PATCH v2 2/3] tools/libs/gnttab: " Juergen Gross
2022-01-11 20:08 ` Andrew Cooper
2022-01-12 7:27 ` Juergen Gross
2022-01-12 8:34 ` Andrew Cooper [this message]
2022-01-11 15:03 ` [PATCH v2 3/3] tools/libs/ctrl: remove file related handling Juergen Gross
2022-01-11 20:10 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9be0e9b7-c382-1643-92e6-be320fda37d9@srcf.net \
--to=amc96@srcf.net \
--cc=anthony.perard@citrix.com \
--cc=jgross@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.